Check if Type is a vector before calling function Type::getVectorNumElements.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@178208 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Akira Hatanaka 2013-03-28 01:28:02 +00:00
parent 1fd36e41e4
commit d7216a28d6
2 changed files with 19 additions and 3 deletions

View File

@ -127,13 +127,14 @@ Instruction *InstCombiner::FoldSelectOpOp(SelectInst &SI, Instruction *TI,
// If this is a non-volatile load or a cast from the same type,
// merge.
if (TI->isCast()) {
if (TI->getOperand(0)->getType() != FI->getOperand(0)->getType())
Type *FIOpndTy = FI->getOperand(0)->getType();
if (TI->getOperand(0)->getType() != FIOpndTy)
return 0;
// The select condition may be a vector. We may only change the operand
// type if the vector width remains the same (and matches the condition).
Type *CondTy = SI.getCondition()->getType();
if (CondTy->isVectorTy() && CondTy->getVectorNumElements() !=
FI->getOperand(0)->getType()->getVectorNumElements())
if (CondTy->isVectorTy() && (!FIOpndTy->isVectorTy() ||
CondTy->getVectorNumElements() != FIOpndTy->getVectorNumElements()))
return 0;
} else {
return 0; // unknown unary op.

View File

@ -0,0 +1,15 @@
; The code in InstCombiner::FoldSelectOpOp was calling
; Type::getVectorNumElements without checking first if the type was a vector.
; RUN: opt < %s -instcombine -S -O3
define i32 @vselect1(i32 %a.coerce, i32 %b.coerce, i32 %c.coerce) {
entry:
%0 = bitcast i32 %a.coerce to <2 x i16>
%1 = bitcast i32 %b.coerce to <2 x i16>
%2 = bitcast i32 %c.coerce to <2 x i16>
%cmp = icmp sge <2 x i16> %2, zeroinitializer
%or = select <2 x i1> %cmp, <2 x i16> %0, <2 x i16> %1
%3 = bitcast <2 x i16> %or to i32
ret i32 %3
}