6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-03-19 04:31:17 +00:00
Code Issues Projects Releases Wiki Activity

Use Twine, instead of StringRef, for consistency.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@93249 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Devang Patel 2010-01-12 18:57:56 +00:00
parent 26028f27dd
commit d77fdba573
2 changed files with 21 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/llvm/Metadata.h
View File

@ -194,10 +194,10 @@ class NamedMDNode : public Value, public ilist_node<NamedMDNode> {
void setParent(Module *M) { Parent = M; }
protected:
explicit NamedMDNode(LLVMContext &C, StringRef N, MDNode*const *Vals,
explicit NamedMDNode(LLVMContext &C, const Twine &N, MDNode*const *Vals,
unsigned NumVals, Module *M = 0);
public:
static NamedMDNode *Create(LLVMContext &C, StringRef N,
static NamedMDNode *Create(LLVMContext &C, const Twine &N,
MDNode *const *MDs,
unsigned NumMDs, Module *M = 0) {
return new NamedMDNode(C, N, MDs, NumMDs, M);
@ -229,7 +229,7 @@ public:
void addOperand(MDNode *M);
/// setName - Set the name of this named metadata.
void setName(StringRef Name);
void setName(const Twine &NewName);
/// getName - Return a constant reference to this named metadata's name.
StringRef getName() const;

23
lib/VMCore/Metadata.cpp
View File

@ -18,6 +18,7 @@
#include "llvm/Instruction.h"
#include "llvm/ADT/DenseMap.h"
#include "llvm/ADT/StringMap.h"
#include "llvm/ADT/SmallString.h"
#include "SymbolTableListTraitsImpl.h"
#include "llvm/Support/ValueHandle.h"
using namespace llvm;
@ -263,7 +264,7 @@ static SmallVector<WeakVH, 4> &getNMDOps(void *Operands) {
return *(SmallVector<WeakVH, 4>*)Operands;
}
NamedMDNode::NamedMDNode(LLVMContext &C, StringRef N,
NamedMDNode::NamedMDNode(LLVMContext &C, const Twine &N,
MDNode *const *MDs,
unsigned NumMDs, Module *ParentModule)
: Value(Type::getMetadataTy(C), Value::NamedMDNodeVal), Parent(0) {
@ -322,11 +323,23 @@ void NamedMDNode::dropAllReferences() {
}
/// setName - Set the name of this named metadata.
void NamedMDNode::setName(StringRef N) {
assert (!N.empty() && "Invalid named metadata name!");
Name = N.str();
void NamedMDNode::setName(const Twine &NewName) {
assert (!NewName.isTriviallyEmpty() && "Invalid named metadata name!");
SmallString<256> NameData;
NewName.toVector(NameData);
const char *NameStr = NameData.data();
unsigned NameLen = NameData.size();
StringRef NameRef = StringRef(NameStr, NameLen);
// Name isn't changing?
if (getName() == NameRef)
return;
Name = NameRef.str();
if (Parent)
Parent->getMDSymbolTable().insert(N, this);
Parent->getMDSymbolTable().insert(NameRef, this);
}
/// getName - Return a constant reference to this named metadata's name.