mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-03-15 07:33:18 +00:00
Fix up a couple of review comments:
Use an if statement instead of a pair of ternary operators checking the same condition. Use a cheap method call rather than returning the local symbol. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198351 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
932aa0d9f6
commit
e151788aae
@ -822,14 +822,14 @@ DwarfCompileUnit *DwarfDebug::constructDwarfCompileUnit(DICompileUnit DIUnit) {
|
||||
if (!FirstCU)
|
||||
FirstCU = NewCU;
|
||||
|
||||
NewCU->initSection(
|
||||
useSplitDwarf() ? Asm->getObjFileLowering().getDwarfInfoDWOSection()
|
||||
: Asm->getObjFileLowering().getDwarfInfoSection(),
|
||||
useSplitDwarf() ? DwarfInfoDWOSectionSym : DwarfInfoSectionSym);
|
||||
|
||||
// If we're splitting the dwarf then construct the skeleton CU now.
|
||||
if (useSplitDwarf())
|
||||
if (useSplitDwarf()) {
|
||||
NewCU->initSection(Asm->getObjFileLowering().getDwarfInfoDWOSection(),
|
||||
DwarfInfoDWOSectionSym);
|
||||
// If we're splitting the dwarf then construct the skeleton CU now.
|
||||
NewCU->setSkeleton(constructSkeletonCU(NewCU));
|
||||
} else
|
||||
NewCU->initSection(Asm->getObjFileLowering().getDwarfInfoSection(),
|
||||
DwarfInfoSectionSym);
|
||||
|
||||
CUMap.insert(std::make_pair(DIUnit, NewCU));
|
||||
CUDieMap.insert(std::make_pair(Die, NewCU));
|
||||
|
@ -185,7 +185,7 @@ public:
|
||||
MCSymbol *getLocalSectionSym() const {
|
||||
if (Skeleton)
|
||||
return Skeleton->getSectionSym();
|
||||
return SectionSym;
|
||||
return getSectionSym();
|
||||
}
|
||||
|
||||
MCSymbol *getSectionSym() const {
|
||||
@ -198,7 +198,7 @@ public:
|
||||
MCSymbol *getLocalLabelBegin() const {
|
||||
if (Skeleton)
|
||||
return Skeleton->getLabelBegin();
|
||||
return LabelBegin;
|
||||
return getLabelBegin();
|
||||
}
|
||||
|
||||
MCSymbol *getLabelBegin() const {
|
||||
|
Loading…
x
Reference in New Issue
Block a user