llvm-6502/lib
David Blaikie 38a4f3bbec Ensure ErrorOr cannot implicitly invoke explicit ctors of the underlying type.
An unpleasant surprise while migrating unique_ptrs (see changes in
lib/Object): ErrorOr<int*> was implicitly convertible to
ErrorOr<std::unique_ptr<int>>.

Keep the explicit conversions otherwise it's a pain to convert
ErrorOr<int*> to ErrorOr<std::unique_ptr<int>>.

I'm not sure if there should be more SFINAE on those explicit ctors (I
could check if !is_convertible && is_constructible, but since the ctor
has to be called explicitly I don't think there's any need to disable
them when !is_constructible - they'll just fail anyway. It's the
converting ctors that can create interesting ambiguities without proper
SFINAE). I had to SFINAE the explicit ones because otherwise they'd be
ambiguous with the implicit ones in an explicit context, so far as I
could tell.

The converting assignment operators seemed unnecessary (and similarly
buggy/dangerous) - just rely on the converting ctors to convert to the
right type for assignment instead.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217048 91177308-0d34-0410-b5e6-96231b3b80d8
2014-09-03 17:31:25 +00:00
..
Analysis Add override to overriden virtual methods, remove virtual keywords. 2014-09-03 11:41:21 +00:00
AsmParser
Bitcode
CodeGen Reinstate "Nuke the old JIT." 2014-09-02 22:28:02 +00:00
DebugInfo
ExecutionEngine Add override to overriden virtual methods, remove virtual keywords. 2014-09-03 11:41:21 +00:00
IR Change name of copyFlags() to copyIRFlags(). Add convenience method for logical 'and' of all flags. NFC. 2014-09-03 01:06:50 +00:00
IRReader
LineEditor
Linker
LTO unique_ptrify LTOCodeGenerator::NativeObjectFile 2014-09-02 18:21:06 +00:00
MC Add override to overriden virtual methods, remove virtual keywords. 2014-09-03 11:41:21 +00:00
Object Ensure ErrorOr cannot implicitly invoke explicit ctors of the underlying type. 2014-09-03 17:31:25 +00:00
Option
ProfileData
Support Cleaning up remaining static initializers in Signals.inc 2014-09-02 23:48:13 +00:00
TableGen Comment only: Annotate loop as per mailing list discussion 2014-08-29 22:43:30 +00:00
Target R600/SI: Add a pattern for i64 and in a branch 2014-09-03 15:22:41 +00:00
Transforms Change name of copyFlags() to copyIRFlags(). Add convenience method for logical 'and' of all flags. NFC. 2014-09-03 01:06:50 +00:00
CMakeLists.txt
LLVMBuild.txt
Makefile