David Blaikie 38a4f3bbec Ensure ErrorOr cannot implicitly invoke explicit ctors of the underlying type. ... An unpleasant surprise while migrating unique_ptrs (see changes in lib/Object): ErrorOr<int*> was implicitly convertible to ErrorOr<std::unique_ptr<int>>. Keep the explicit conversions otherwise it's a pain to convert ErrorOr<int*> to ErrorOr<std::unique_ptr<int>>. I'm not sure if there should be more SFINAE on those explicit ctors (I could check if !is_convertible && is_constructible, but since the ctor has to be called explicitly I don't think there's any need to disable them when !is_constructible - they'll just fail anyway. It's the converting ctors that can create interesting ambiguities without proper SFINAE). I had to SFINAE the explicit ones because otherwise they'd be ambiguous with the implicit ones in an explicit context, so far as I could tell. The converting assignment operators seemed unnecessary (and similarly buggy/dangerous) - just rely on the converting ctors to convert to the right type for assignment instead. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@217048 91177308-0d34-0410-b5e6-96231b3b80d8		2014-09-03 17:31:25 +00:00
..
Archive.cpp	Don't own the buffer in object::Binary.	2014-08-19 18:44:46 +00:00
Binary.cpp	Ensure ErrorOr cannot implicitly invoke explicit ctors of the underlying type.	2014-09-03 17:31:25 +00:00
CMakeLists.txt	Add support for inline asm symbols to IRObjectFile.	2014-07-03 18:59:23 +00:00
COFFObjectFile.cpp	Simplify creation of a bunch of ArrayRefs by using None, makeArrayRef or just letting them be implicitly created.	2014-08-27 05:25:25 +00:00
COFFYAML.cpp
ELF.cpp	AArch64: add support for dynamic-loader relocations	2014-08-11 10:10:27 +00:00
ELFObjectFile.cpp	Don't own the buffer in object::Binary.	2014-08-19 18:44:46 +00:00
ELFYAML.cpp	Add forgotten break statement.	2014-07-13 16:18:56 +00:00
Error.cpp	Added forgotten noexcept.	2014-08-18 07:48:18 +00:00
IRObjectFile.cpp	Pass a std::unique_ptr<MemoryBuffer>& to getLazyBitcodeModule.	2014-08-26 22:00:09 +00:00
LLVMBuild.txt	Object/LLVMBuild.txt: Sort required_libraries by alphabetical order.	2014-07-14 02:52:08 +00:00
MachOObjectFile.cpp	Code review tweaks	2014-09-02 18:50:24 +00:00
MachOUniversal.cpp	Fix a pair of use after free. Should bring the bots back.	2014-08-19 18:59:14 +00:00
Makefile
Object.cpp	Don't own the buffer in object::Binary.	2014-08-19 18:44:46 +00:00
ObjectFile.cpp	Don't own the buffer in object::Binary.	2014-08-19 18:44:46 +00:00
RecordStreamer.cpp	Make RecordStreamer.h private.	2014-07-04 22:44:18 +00:00
RecordStreamer.h	Canonicalize header guards into a common format.	2014-08-13 16:26:38 +00:00
SymbolicFile.cpp	Ensure ErrorOr cannot implicitly invoke explicit ctors of the underlying type.	2014-09-03 17:31:25 +00:00