Tim Northover d0dbe02fd2 ARM & AArch64: make use of common cmpxchg idioms after expansion ... The C and C++ semantics for compare_exchange require it to return a bool indicating success. This gets mapped to LLVM IR which follows each cmpxchg with an icmp of the value loaded against the desired value. When lowered to ldxr/stxr loops, this extra comparison is redundant: its results are implicit in the control-flow of the function. This commit makes two changes: it replaces that icmp with appropriate PHI nodes, and then makes sure earlyCSE is called after expansion to actually make use of the opportunities revealed. I've also added -{arm,aarch64}-enable-atomic-tidy options, so that existing fragile tests aren't perturbed too much by the change. Many of them either rely on undef/unreachable too pervasively to be restored to something well-defined (particularly while making sure they test the same obscure assert from many years ago), or depend on a particular CFG shape, which is disrupted by SimplifyCFG. rdar://problem/16227836 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@209883 91177308-0d34-0410-b5e6-96231b3b80d8		2014-05-30 10:09:59 +00:00
..
2009-07-17-CrossRegClassCopy.ll
2009-07-21-ISelBug.ll
2009-07-23-CPIslandBug.ll
2009-07-30-PEICrash.ll
2009-08-01-WrongLDRBOpc.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
2009-08-02-CoalescerBug.ll
2009-08-04-CoalescerAssert.ll
2009-08-04-CoalescerBug.ll
2009-08-04-ScavengerAssert.ll
2009-08-04-SubregLoweringBug2.ll
2009-08-04-SubregLoweringBug3.ll
2009-08-04-SubregLoweringBug.ll
2009-08-06-SpDecBug.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
2009-08-07-CoalescerBug.ll
2009-08-07-NeonFPBug.ll
2009-08-08-ScavengerAssert.ll
2009-08-10-ISelBug.ll
2009-08-21-PostRAKill4.ll
2009-09-01-PostRAProlog.ll
2009-09-28-ITBlockBug.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
2009-10-15-ITBlockBranch.ll
2009-11-01-CopyReg2RegBug.ll
2009-11-11-ScavengerAssert.ll
2009-11-13-STRDBug.ll
2009-12-01-LoopIVUsers.ll
2010-01-06-TailDuplicateLabels.ll
2010-01-19-RemovePredicates.ll
2010-02-11-phi-cycle.ll
2010-02-24-BigStack.ll
2010-03-08-addi12-ccout.ll
2010-03-15-AsmCCClobber.ll
2010-04-15-DynAllocBug.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
2010-04-26-CopyRegCrash.ll
2010-05-24-rsbs.ll
2010-06-14-NEONCoalescer.ll
2010-06-19-ITBlockCrash.ll
2010-06-21-TailMergeBug.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
2010-08-10-VarSizedAllocaBug.ll
2010-11-22-EpilogueBug.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
2010-12-03-AddSPNarrowing.ll
2011-04-21-FILoweringBug.ll
2011-06-07-TwoAddrEarlyClobber.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
2011-12-16-T2SizeReduceAssert.ll
2012-01-13-CBNZBug.ll
2013-02-19-tail-call-register-hint.ll
2013-03-02-vduplane-nonconstant-source-index.ll
2013-03-06-vector-sext-operand-scalarize.ll
aligned-constants.ll
aligned-spill.ll
bfi.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
bfx.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
buildvector-crash.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
carry.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
constant-islands.ll	Remove -arm-disable-ehabi option	2014-02-07 20:12:49 +00:00
cortex-fp.ll	Add extra CHECK prefix to tests with explicit prefix	2014-02-16 13:28:15 +00:00
crash.ll
cross-rc-coalescing-1.ll
cross-rc-coalescing-2.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
div.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
frameless2.ll
frameless.ll
ifcvt-neon.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
inflate-regs.ll
inlineasm.ll
large-call.ll
large-stack.ll
ldr-str-imm12.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
lit.local.cfg
longMACt.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
lsr-deficiency.ll
machine-licm.ll
mul_const.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
pic-load.ll
segmented-stacks.ll	Move the segmented stack switch to a function attribute	2014-04-10 22:58:43 +00:00
tail-call-r9.ll
thumb2-adc.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-add2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-add3.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-add4.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-add5.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-add6.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-add.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-and2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-and.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-asr2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-asr.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-bcc.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-bfc.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-bic.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-branch.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
thumb2-call-tc.ll
thumb2-call.ll
thumb2-cbnz.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
thumb2-clz.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-cmn2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-cmn.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-cmp2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-cmp.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-eor2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-eor.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-ifcvt1-tc.ll
thumb2-ifcvt1.ll
thumb2-ifcvt2.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
thumb2-ifcvt3.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
thumb2-jtb.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-ldm.ll	Fix the Load/Store optimization pass to work with Thumb1.	2014-05-16 14:14:30 +00:00
thumb2-ldr_ext.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-ldr_post.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-ldr_pre.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-ldr.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-ldrb.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-ldrd.ll
thumb2-ldrh.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-lsl2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-lsl.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-lsr2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-lsr3.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-lsr.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-mla.ll	ARM: fix test case missed in previous roundup	2014-04-04 01:19:56 +00:00
thumb2-mls.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-mov.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-mul.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-mulhi.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-mvn2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-mvn.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-neg.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-orn2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-orn.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-orr2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-orr.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-pack.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-rev16.ll
thumb2-rev.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-ror.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-rsb2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-rsb.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-sbc.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-select_xform.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-select.ll	ARM: update even more tests	2014-04-03 17:35:22 +00:00
thumb2-shifter.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-smla.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-smul.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-spill-q.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
thumb2-str_post.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-str_pre.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-str.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-strb.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-strh.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-sub2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-sub3.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-sub4.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-sub5.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-sub.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-sxt_rot.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-sxt-uxt.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-tbb.ll
thumb2-tbh.ll
thumb2-teq2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-teq.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-tst2.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-tst.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-uxt_rot.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
thumb2-uxtb.ll	ARM: yet another round of ARM test clean ups	2014-04-03 23:47:24 +00:00
tls1.ll
tls2.ll
v8_IT_1.ll
v8_IT_2.ll
v8_IT_3.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
v8_IT_4.ll
v8_IT_5.ll	ARM & AArch64: make use of common cmpxchg idioms after expansion	2014-05-30 10:09:59 +00:00
v8_IT_6.ll	ARMv8 IfConversion must skip narrow instructions that a) define CPSR and b) wouldn't affect CPSR in an IT block	2014-02-26 11:27:28 +00:00