optimize Ben Eater unlock setAddress timing

unlock-ben-eater-hardware/README.md

@@ -13,3 +13,8 @@ but would require changes for other platforms.
 
 **NOTE** that this sketch **will not** work on TommyPROM hardware.  It is included here
 to help people with locked chips who are using the Ben Eater design.
+
+![Unlock timing with Ben Eater Hardware](../docs/images/ben-eater-unlock-timing.png)
+
+The timing trace shows the tBLC for the bytes of the unlock sequence within 65us, well
+within the required 150us in the datasheet.

unlock-ben-eater-hardware/unlock-ben-eater-hardware.ino

@@ -56,17 +56,50 @@ void loop() {
 
 
 // Output the address bits and outputEnable signal using shift registers.
-void setAddress(int address, bool outputEnable) {
+void setAddress(int addr, bool outputEnable) {
-    // Shift the address bits in
+    // Set the highest bit as the output enable bit (active low)
-    shiftOut(SHIFT_DATA, SHIFT_CLK, MSBFIRST, (address >> 8) | (outputEnable ? 0x00 : 0x80));
+    if (outputEnable) {
-    shiftOut(SHIFT_DATA, SHIFT_CLK, MSBFIRST, address);
+        addr &= ~0x8000;
+    } else {
+        addr |= 0x8000;
+    }
+    byte dataMask = 0x04;
+    byte clkMask = 0x08;
+    byte latchMask = 0x10;
+
+    // Make sure the clock is low to start.
+    PORTD &= ~clkMask;
+
+    // Shift 16 bits in, starting with the MSB.
+    for (uint16_t ix = 0; (ix < 16); ix++)
+    {
+        // Set the data bit
+        if (addr & 0x8000)
+        {
+            PORTD |= dataMask;
+        }
+        else
+        {
+            PORTD &= ~dataMask;
+        }
+
+        // Toggle the clock high then low
+        PORTD |= clkMask;
+        delayMicroseconds(3);
+        PORTD &= ~clkMask;
+        addr <<= 1;
+    }
 
     // Latch the shift register contents into the output register.
-    digitalWrite(SHIFT_LATCH, LOW);
+    PORTD &= ~latchMask;
-    digitalWrite(SHIFT_LATCH, HIGH);
+    delayMicroseconds(1);
-    digitalWrite(SHIFT_LATCH, LOW);
+    PORTD |= latchMask;
+    delayMicroseconds(1);
+    PORTD &= ~latchMask;
 }
 
+
+
 // Read a byte from the EEPROM at the specified address.
 byte readEEPROM(int address) {
     setDataBusMode(INPUT);