Apple-2-Tools/AppleWin
1
0
Fork 0
mirror of https://github.com/AppleWin/AppleWin.git synced 2024-12-23 00:30:17 +00:00
Code Issues Projects Releases Wiki Activity

#479 (b) Add Warning for long symbols when symbol table is loaded

Browse Source
This commit is contained in:
michaelangel007 2017-08-24 09:40:28 -07:00
parent a276bef7df
commit 975230b46d
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/Debugger_Changelog.txt
View File

@ -1,4 +1,5 @@
/*
.11 Added:"Warning" for long symbols when symbol table is loaded
.10 Changed: "Warning" of symbols that alias to "Info."
.9 Continuation of 2.8.0.8: Fix overflowing disassembly pane for long symbols
.8 Fixed: Inactive Language Card bank now grayed out, main memory no longer double inverse.

16
source/Debugger/Debugger_Symbols.cpp
View File

@ -555,6 +555,8 @@ int ParseSymbolTable( TCHAR *pPathFileName, SymbolTable_Index_e eSymbolTableWrit
char sText[ CONSOLE_WIDTH * 3 ];
bool bFileDisplayed = false;
const int nMaxLen = min(MAX_TARGET_LEN,MAX_SYMBOLS_LEN);
int nSymbolsLoaded = 0;
if (! pPathFileName)
@ -637,6 +639,20 @@ int ParseSymbolTable( TCHAR *pPathFileName, SymbolTable_Index_e eSymbolTableWrit
WORD nAddressPrev;
int iTable;
// 2.9.0.11 Bug #479
int nLen = strlen( sName );
if (nLen >= nMaxLen)
{
ConsolePrintFormat( sText, " %sWarn.: %s%s (%d > %d)"
, CHC_WARNING
, CHC_SYMBOL
, sName
, nLen
, nMaxLen
);
ConsoleUpdate(); // Flush buffered output so we don't ask the user to pause
}
// 2.8.0.5 Bug #244 (Debugger) Duplicate symbols for identical memory addresses in APPLE2E.SYM
const char *pSymbolPrev = FindSymbolFromAddress( (WORD)nAddress, &iTable ); // don't care which table it is in
if( pSymbolPrev )