Add check for buffer overflow when globbing, expanding variables, or
inserting aliases (PR#110). Increase buffer size from 1024 to 4096.
Increase buffer for reading commands from 256 to 1024 bytes in order
to match the maximum length used when reading.
Changed to match the base builds.
binprint.asm:
Renamed to doline.asm. The default makefiles don't like to have
name overloading like there was with binprint.c and binprint.asm
doline.asm:
- added a dummy segment
- added the setcom directive
binprint.c:
- added stack checking code
- prototyped functions
- removed extraneous declarations
- fflush stdout before writing to STDOUT_FILENO
binprint.1, binprint.desc, binprint.rez:
- initial checkin
- checked and reduced stack size to 1k (actually used is about 748)
- changed awgs.h --> aroff.h
- minor formatting changes
- added some missing header files
- eliminated a call to some old GNO v1.0 (?) stdio initialization
print.c:
- changed awgs.h --> aroff.h
- minor formatting changes
Added additional optional debug code. A version of gsh with the memory
checking debug code turned on is available as an exe file.
Lock and unlock the hash mutual exclusion key in when disposing of the
hash table.
Allow five digits rather than four when printing the process number in
the ps command.
Piping the output of a command into a non-executable file no longer
causes gsh to hang.
Fixed several mutual exclusion problems, including a particularly nasty
one that would cause gsh to loop forever inside the memory manager. (You
could identify this one by the "BRA (-23)" at the bottom of the infinite
loop.)
Fixed the string vector print routine to properly handle all numbers of
entries in the hash table. Previously, it would always print duplicate
entries if there were < 6 commands hashed, and would sometimes print
duplicates (depending on previous contents of an internal table) for
other numbers of commands.
gsh would wait on background processes started from an exec file
(executed, not sourced). Now the exec file does not wait on the process,
but the background process is not associated with the parent shell after
the exec file terminates.
Made gsh globbing work more like csh: if none of the requested patterns
are found, print "No match" and exit.
At startup, if /etc/glogin, $HOME/glogin, or $HOME/gshrc does not exist,
don't report a "file not found" error message. (PR#100)
out of 13/RInclude instead of /src/gno/build.tools. This implies that
builddate.rez has to have been previously installed in 13/RInclude; this
is done by the 'install' and 'release' targets in /src/gno/build.tools.
Fixed several memory leaks.
Prefix command without any parameter (to list the prefixes) would cause
memory corruption when prefix had been invoked previously with a parameter.
Sourcing a command file from within an exec file could cause gsh to
wait forever, depending upon the commands executed in the sourced file.
All built-in commands return appropriate status: 1 for error, 0 for no error.
Fixed several cases where incorrect value was set in $status.
Added usage strings for tset, hash, commands, and history.
Fixed memory corruption error when edit command had no parameters.
When system() is called with pointer = NULL or with a command string that
causes gsh to detect an error (e.g., incompatibility with | and <), return
status of -1. In other cases, return process's status rather than always 0.
System would crash when output from a non-forked command was piped to
another process; for example clear | cat > /tmp/list
Fixed defect introduced in version 2.0d5: when a background job completed
while gsh was waiting for command line input, gsh would print a bogus error
message and quit.
Add quotes around null parameters from the command line so they will be
parsed properly (resolves PR#84).
Output piped to an unfound command caused gsh to terminate, due to an
interface change to the GNO 2.0.6 version of getpgrp(2): it now returns the
process group of the caller. To get the process group number for the
pid passed as a parameter pid, the call has to be made to _getpgrp(2).
In addition to fixing invoke.asm, updates were also made in jobs.asm.
When directory stack is full, pushd, reports a new error message: 'pushd:
Directory stack full'. (Previously, 50 pushds would cause a crash.)
When parameter passed to "pushd +n" is <= 0, report a new error message:
'pushd: Invalid number'. (Previously, tried to chdir to the parameter.)
When a command appends to stderr (e.g., echo test >>&/tmp/err), stdin was
closed, due to errappend being defined as pipefds+2 rather than pipefds+4
in cmd.asm.
When there was an error reading stdin, gsh went into an infinite loop of
beeping and requesting more input. Changed getchar (in stdio.asm) and
GetCmdLine (in edit.asm) to report the error and terminate.
Code in cmd.asm set and reset handler for signal SIGSTOP (17). This makes
no sense, since there cannot be a handler for SIGSTOP. This was changed
to set and reset signal SIGTSTP (18) since that handler is used by gsh.
The error message "specify a command before redirecting" was never
caught by the invoke() subroutine because the next higher routine,
command(), checked for argv==0 before calling invoke(). The error
message was moved into command().
(PR#85, PR#86):
For login shells (command line starts with '-'),
If $PATH doesn't start with ':' or contain a space,
change all ":" to " ".
source /etc/glogin
source $HOME/glogin
$HOME/gshrc is sourced afterward for both login and non-login shells.
Don't the print number of hashed commands (from "rehash") until all
initialization is completed.
Only pass exported environment variables to child processes, and prevent child
processes from changing parent's environment.
A null command followed by a redirection of stdout, for example
> /tmp/list
would cause an error message "<garbage> not found" due to incorrect
setting of command buffer pointer.
Filename completion did not work following ">&" or ">" without a trailing
space.
Entabbed all the asm files, saving more than 36,000 bytes.
removed the need for p-string routines, so they were removed. Also
removed alloc256/free256 and associated data structures.
In removing calls, found instances in pwd & prefix commands and prompt
handler where current directory name was assumed to be < 256 characters;
recoded to use a flexible buffer size.
Updated and expanded mmdebug.asm routines that perform error checking on
memory management calls. Added macros ~NEW and ~DISPOSE that invoke either
the real or debug routines.
Fixed call to read $TERM variable's length to fix PR#81.
Removed echo of data when setting value of $< in expandvars (expand.asm).
The characters are echoed as they are typed and do not need to be reprinted
on stdout after carriage-return is typed.
Added error checking to the various flavors of prefix (just like cd):
- Verify 2nd parameter is a valid directory before setting.
- Verify 1st parameter < 32 before displaying or setting.
Set_Variable, Export, etc.) to new ones (ReadVariableGS, SetGS, ExportGS,
etc.) in many places; there are still a few more to change. This change
removed the 256-character limit on strings retrieved by these routines,
such as the value of environment variables. (PR # 9).
At startup do not set $TERM to gnocon if it is already set.
Removed the df command (from builtin.asm).
Defined macro incad to increment a 4-byte address, checking for overflow;
replaced instances of "inc ptr" with "incad ptr".
Changed column offset table to use a 1-word rather than 1-byte entry. This
resolves PR#14 (hash wouldn't print beyond first 256 filenames).
Fixed defect in unalias (alias.asm) where the double quote portion of the
scanner would look for a terminating single quote. This resolves PR#69.
Changed default order for copying files in $PATH dirs into executable list,
so earlier paths files are found first.
Added environment variable flag $OLDPATHMODE to make gsh behave in the old
(backwards order) way when necessary.
Discard duplicate filenames when hashing.
Fix PR#73: directory in $PATH with escaped space (\ ) is not searched.
* When ~ is parsed and next character is a delimiter, make sure contents
of expanded $HOME match the user's delimiter.
* When wildcard patterns don't match, rather than terminating the command
gsh now prints "No match: <pattern> ignored" and passes the command line
minus the unmatched patterns on to be executed.
* Modified echo command so it doesn't add a blank to the end.
* Make "clear" and "source" built-ins non-forked commands. Unforking
"source" allows prefixes to be set in files that are sourced.
* Add loop to parse a single command (removing leading whitespace) before
sending it off to be expanded and executed. Skip null lines and comments
at this level. This allows later commands that depend upon variables set
in the 1st command to work; e.g.: set t_num=1 ; echo "Test number $t_num"
Also fixes problems seen when tab was first character of multiple lines.
* Initialize environment variable flags at startup (for echo, nodirexec,
nonewline, noglob, nobeep, pushdsilent, term, and ignoreeof). Set
flag when env var is set in upper or lower case (formerly, only worked
with lower case).
* Lots of places two-word addresses are incremented using inc, without
checking for overflow into the high-order word. As these are discovered,
they are changed to use adc on both words.
See file UpdateLog for detailed list of changes.
Added direct-page/stack data segment of size 2048 to main.asm. It is
initialized to be filled with "?" characters, so that it can be examined
to see how much space is actually being used.
Added explanation of the (minor) changes made in the initial
v2.0.6 checkin, and what still needs to be done.
UpdateLog:
Minor formatting change on some lines.
link.script, mods:
These files are obsolete.
and link. However, it does not work yet and thus still needs work.
The *.asm files have had the following common changes:
- 'keep' lines were eliminated
- the 'mcopy' now takes the macro from the /obj/gno/bin/gsh
directory. This is in anticipation of having the macro
files generated from a single source file; there is a large
amount of duplication. For the moment, the makefile merely
copies the old macro files from the "M" directory to the
/obj/gno/bin/gsh directory.
- start each file with a dummy routine so that the source
code winds up in the *.o rather than the *.root file.
- added the 'setcom 60' directive; there were many source
lines that were otherwise getting truncated.
The makefile is a complete rewrite.
tar v2.0.1 binary distributed on the 'net that claimed to have fixed
an unspecified bug in this version, but neither the sources nor
the originator of that fix are available.
It may be appropriate to completely replace this implementation.
However, judging from the comments at the top of the source file,
the v2.0 changes were based on more v1.31 rather than 1.4. When
this program is updated, these diffs should be evaluated. (Unless,
of course, the current version is tossed in favor of a recent BSD
derivative.)
Here are the comments for the changes from v1.31 to v1.4 that may have
been dropped while moving to v2.0. See the cvs diffs for details:
> v1.4 - Termcap support has been added and tested. Look for a soon to be
> faster version coming soon to a ~/bin directory near you!
>
> v1.32 - uses isatty(x) instead of fstat. more portable (opinion).
> soon to be added, TERMCAP support, won't that be nice?
