Rob Landley
577905f1e4
Revert duplicate patch.
...
I don't know why patch decided to apply this even though it was already in
the tree. I thought the other hunks failed because they were totally
unrelated leakage from Bernhard's tree (which they are; was the a reason
for bundling them in with this fix? Do they have something to do with
the GCC 2.95 fix? I suspect they prevent me from backporting this
patch to 1.2.2 because the header consolidation into libbb.h hadn't
been done yet, and no I'm not fixing it up: if that's the case then
this patch won't be in 1.2.2 due to extraneous changes bundled with it that
prevent a clean backport without rolling a new patch).
2006-09-12 22:42:03 +00:00
Rob Landley
20cc6d567f
Remove pointless "const". Bloatcheck says 0 bytes difference.
2006-09-12 21:42:17 +00:00
Rob Landley
1b2b5cfba8
Fix from Bernhard for somebody trying to limp along with gcc 2.95.4.
2006-09-12 20:29:22 +00:00
Rob Landley
16bbb20089
Random cleanup hanging around my tree.
2006-09-12 20:28:34 +00:00
Bernhard Reutner-Fischer
b5f50ea344
- small trivia to be gentle to gcc-2.95.x which had no va_copy but only __va_copy.
2006-09-12 13:27:55 +00:00
Bernhard Reutner-Fischer
428a5cd0d3
- fix warning about discarding qualifiers in initialization
2006-09-12 13:25:16 +00:00
Denis Vlasenko
00d7d6cef6
nfsmount: sanitize it. It had a rather peculiar idea of implementing "bg"
...
option - it was going to return a special flag back to caller and
expecting caller to call it again with special parameter! Also
caller was charged with calling mount() syscall...
mount: mtab support was non-functional. Enabling it revealed serious bug
which is not fixed yet.
2006-09-11 17:42:44 +00:00
Bernhard Reutner-Fischer
64d7e93081
- convert a few xopen3(,,0) into xopen(,). Also peruse the fact that xopen defaults to 0777 on it's own, so we don't need to xopen3(,,0777).
...
Saves a few bytes:
$ size busybox.old busybox text data bss dec hex filename
839676 8780 243592 1092048 10a9d0 busybox.old
839660 8780 243592 1092032 10a9c0 busybox
$ make CC=gcc-4.2-HEAD bloatcheck
function old new delta
static.vconfig_main 281 279 -2
static.rx_main 1076 1074 -2
static.mt_main 294 292 -2
static.gzip_main 753 751 -2
static.mkfs_minix_main 4034 4030 -4
static.unzip_main 1771 1766 -5
static.crontab_main 1513 1507 -6
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/7 up/down: 0/-23) Total: -23 bytes
2006-09-11 16:01:40 +00:00
Bernhard Reutner-Fischer
57b56674a3
- merge xstat.c into xfuncs.c
2006-09-11 09:18:09 +00:00
Bernhard Reutner-Fischer
dea6e3d3cf
- Tito pointed out that Rob forgot to add e2fsprogs/blkid/list.c
2006-09-11 09:16:12 +00:00
Rob Landley
49ea46667f
Build fixes for gcc 4.0 with -Werror, from Tito.
2006-09-11 01:34:21 +00:00
Rob Landley
69674941dd
Error reporting fix for sulogin, plus remove help entries for options we never
...
implemented. (Plus a bit more of bbsh leaking in from my tree, but it
shouldn't hurt anything and I'm lazy...)
2006-09-11 00:34:01 +00:00
Denis Vlasenko
3077294615
nfsmount: remove some really old code (for kernels 1.x!) + small cleanups.
2006-09-10 18:48:16 +00:00
Denis Vlasenko
d2b13eab98
nfsmount: delete nfsmount.h
2006-09-10 18:40:18 +00:00
Denis Vlasenko
39e93cc951
nfsmount: nfsmount.h merged into nfsmount.c
2006-09-10 18:38:17 +00:00
Denis Vlasenko
2244a21a8e
nfsmount: style fix
2006-09-10 18:28:23 +00:00
Denis Vlasenko
5983914c1b
ipcs: silly trick with strings. saves ~200 bytes.
2006-09-10 18:26:51 +00:00
Rob Landley
1bfca7bac7
Cleanup headers and replace the zero padding with an even smaller version.
...
One of the pads turned out to be unnecessary: sizeof(struct TarHeader) is
TAR_BLOCK_SIZE, the padding's in the struct. The others could be done inline
with bb_common_bufsiz1.
This is a cleanup I did to Denis' patch long ago, but got sidetracked by
what turned into svn 15660.
2006-09-10 03:20:37 +00:00
Denis Vlasenko
9852d5a1e6
sulogin: minor cleanup.
2006-09-09 14:00:58 +00:00
Denis Vlasenko
8fafacd7ec
setkeycodes: something horrible happened here
...
to indentation... fixed now
2006-09-09 13:23:04 +00:00
Denis Vlasenko
42dfcd2612
top: fixed wrong comment, made error message more clear
2006-09-09 12:55:02 +00:00
Denis Vlasenko
0c45bb23d2
tar: fix "xopen with O_CREAT" warning, improve zero padding write
...
(was doing zillions of 1-byte write syscalls)
2006-09-09 12:49:03 +00:00
Denis Vlasenko
d5d614c5f4
xopen3(O_RDONLY) -> xopen(O_RDONLY).
2006-09-09 12:25:20 +00:00
Denis Vlasenko
9cac521f07
using [xa]sprintf for string concatenation is neat and saves
...
~100 bytes according to bloatcheck. Also this fixes bug in rpm
2006-09-09 12:24:19 +00:00
Denis Vlasenko
3526a1320a
wget: wrap one atrociously long line (around 200 chars long!).
2006-09-09 12:20:57 +00:00
Denis Vlasenko
d797fcd726
udhcp: FEATURE_UDHCP_SYSLOG should be selected only if
...
udhcp[cd] really are going to use it.
2006-09-09 12:18:46 +00:00
Denis Vlasenko
2f50aa42c5
login: use some ideas from util-linux's login.
...
O_NONBLOCKing output on login timeout.
fchmod instead of chmod (latter is racy).
is_my_tty() is not needed anymore after race is fixed
(is_my_tty() was racy too anyway...).
2006-09-08 17:56:52 +00:00
Denis Vlasenko
bd8f43dbab
few random readability enhansements. No code changes
2006-09-08 17:31:55 +00:00
Denis Vlasenko
9a9edf200b
login: make it saner and smaller by ~0.5k.
2006-09-08 17:29:53 +00:00
Denis Vlasenko
6bbd174593
login: small fixes like \n removal, bb_error_msg'ification, etc.
2006-09-08 17:26:20 +00:00
Denis Vlasenko
942e4291fe
login: previous commit comment was wrong :)
...
That commit added login script support.
Now _this commit_ is a style fix. Sorry....
2006-09-08 17:25:04 +00:00
Denis Vlasenko
2e502914b0
login: style fixes
2006-09-08 17:22:45 +00:00
Rob Landley
dd93abeaff
Shrinkage/cleanup from Tito.
2006-09-08 17:22:05 +00:00
Rob Landley
ef08184d9e
Fix warnings.
2006-09-08 17:21:19 +00:00
Rob Landley
3476ad651d
Second drop. More infrastructure in place, especially for parsing pipelines.
...
The minimal version got a couple hundred bytes bigger, partly because it's
broken into more functions but mostly because it now dynamically reallocates
and frees everything with no hard-coded limits. (I thought about making
that optional, but there's a limit to what I can debug and maintain. It
should still be reasonably NOMMU friendly, the allocations are small and
short lived, and shouldn't contribute noticeably to long-term memory
fragmentation.)
2006-09-08 16:59:08 +00:00
Rob Landley
c27f4f5445
A quick cleanup pass of some low-hanging mess.
2006-09-08 00:41:48 +00:00
Rob Landley
d35c0efddb
Bugfix for: echo '123456789' | sed 's/./|&/5'
2006-09-08 00:01:02 +00:00
Denis Vlasenko
239369b368
Fix (hopefully) bug 976. Need more thorough audit.
...
Restore erroneously removed FEATURE_UDHCP_SYSLOG.
2006-09-07 17:05:44 +00:00
Denis Vlasenko
a9801658ee
getty, sulogin: convert to using bb_msg for syslog output
2006-09-07 16:20:03 +00:00
Denis Vlasenko
b750dec40a
fix if (ENABLE_FEATURE_SYSLOG & (...)) - should be &&
2006-09-07 16:03:45 +00:00
Denis Vlasenko
049d6b8c08
Add CONFIG_FEATURE_SYSLOG which controls whether
...
bb_xx_msg will ever try to send output to syslog.
Add "select CONFIG_FEATURE_SYSLOG" to relevant applets.
This allows to omit syslog code if we do not have
any syslog-capable applets in the build.
2006-09-07 06:02:39 +00:00
Denis Vlasenko
b7d8dd9ab1
CONFIG_FEATURE_COMPRESS_USAGE was impossible to turn on
...
if !CONFIG_NITPICK
2006-09-07 05:43:38 +00:00
Denis Vlasenko
3da6aa878a
adding files missed in prev updates (forgot about svn add)
2006-09-07 05:09:22 +00:00
Rob Landley
f522d1231c
Denis Vlasenko has started to put stuff on his BusyBox home page, so index it.
2006-09-06 22:56:38 +00:00
Denis Vlasenko
6d655be5df
removed a lot of trailing \n in bb_msg() calls. It is added
...
automatically by function itself.
2006-09-06 19:02:46 +00:00
Denis Vlasenko
3538b9a882
Implement optional syslog logging using ordinary
...
bb_xx_msg calls, and convert networking/* to it.
The rest of bbox will be converted gradually.
2006-09-06 18:36:50 +00:00
Bernhard Reutner-Fischer
5d725462d4
- strip 399424 off the bss by making decompress_uncompress buffers config buffers.
...
Compile tested (too lazy to look for a small .Z on the net).
$ size busybox.old busybox
text data bss dec hex filename
859555 10232 645732 1515519 171fff busybox.old
859683 10232 246308 1116223 11083f busybox
$ make bloatcheck
function old new delta
uncompress 1036 1160 +124
inbuf 2116 4 -2112
outbuf 4100 4 -4096
htab 131072 - -131072
codetab 262144 - -262144
------------------------------------------------------------------------------
(add/remove: 0/2 grow/shrink: 1/2 up/down: 124/-399424) Total: -399300 bytes
2006-09-06 15:28:32 +00:00
Bernhard Reutner-Fischer
e614eaf40d
- mdev and grep use xregcomp. Closes bug #1021
2006-09-06 13:24:39 +00:00
Rob Landley
4cb035dd23
Vladimir Dronnikov (ybrnj80 at yandex dot ru) pointed out that my cleanup of
...
his code introduced a bug (an extra backslash in the CIFS mount string).
2006-09-05 14:00:21 +00:00
Rob Landley
02496aa69e
The bb_ prefixes were removed from xasprintf() and xopen() a month ago (in
...
svn 15767).
2006-09-05 13:48:21 +00:00
