Fix logic for needing file name #1092

This commit is contained in:
Tony Kuker 2023-02-04 22:58:25 -06:00
parent e9b3949122
commit e43a05c0cb
1 changed files with 6 additions and 2 deletions

View File

@ -68,7 +68,7 @@ bool ScsiDump::Banner(const vector<char*>& args) const
<< " -v Enable verbose logging. (deprecated - use -L instead)\n" << " -v Enable verbose logging. (deprecated - use -L instead)\n"
<< " -r Restore instead of dump.\n" << " -r Restore instead of dump.\n"
<< " -p Generate .properties file to be used with the PiSCSI web interface. Only valid for dump mode.\n" << " -p Generate .properties file to be used with the PiSCSI web interface. Only valid for dump mode.\n"
<< " -q Executes Inquiry of the specified target device, then exits.\n" << " -q Executes INQUIRY of the specified target device, then exits.\n"
<< flush; << flush;
return false; return false;
@ -156,7 +156,11 @@ void ScsiDump::ParseArguments(const vector<char*>& args)
throw parser_exception("Target ID and PiSCSI board ID must not be identical"); throw parser_exception("Target ID and PiSCSI board ID must not be identical");
} }
if (!inquiry_only && filename.empty()) { // inq only & !prop = no file
// inq only & prop = need file
// !inq only & !prop = need file
// !inq only & prop = need file
if ((properties_file || !inquiry_only) && filename.empty()) {
throw parser_exception("Missing filename"); throw parser_exception("Missing filename");
} }