fix some warnings

Elf2Mac/Section.cc

@@ -211,6 +211,9 @@ void Section::FixRelocs(bool allowDirectCodeRefs)
 			case SectionKind::bss:
 				relocBase = RelocBase::bss;
 				break;
+			case SectionKind::undefined:
+				assert(false);
+				break;
 		}
 		rela.relocBase = relocBase;
 

LaunchAPPL/Common/ReliableStream.cc

@@ -1,6 +1,7 @@
 #include "ReliableStream.h"
 #include <iterator>
 #include "CRC32.h"
+#include <cassert>
 
 using std::begin;
 using std::end;
@@ -460,4 +461,5 @@ size_t ReliableStream::onReceive(const uint8_t* p, size_t n)
             }
             break;
     }
+    assert(false);
 }

LaunchAPPL/Common/ReliableStream.h

@@ -45,7 +45,7 @@ class ReliableStream : public StreamWrapper
     bool resetResponse = false;
     bool flushRequested = false;
 
-    virtual size_t onReceive(const uint8_t* p, size_t n);
+    virtual size_t onReceive(const uint8_t* p, size_t n) override;
 public:
     explicit ReliableStream(Stream* stream);
     void reset(int sendReset);

LaunchAPPL/Common/Stream.cc

@@ -84,4 +84,5 @@ StreamWrapper& StreamWrapper::operator=(StreamWrapper&& other)
     if(underlying_)
         underlying_->setListener(this);
     other.underlying_ = nullptr;
+    return *this;
 }

Rez/ResourceDefinitions.h

@@ -47,6 +47,8 @@ class Field
 public:
 	yy::location location;
 
+	virtual ~Field() = default;
+
 	virtual bool needsValue() { return true; }
 
 	virtual void compile(ExprPtr expr, ResourceCompiler *compiler, bool prePass) = 0;

Rez/RezLexer.cc

@@ -166,7 +166,7 @@ RezLexer::WaveToken RezLexer::nextWave()
 			return tok;
 		}
 	}
-	catch(preprocess_exception e)
+	catch(const preprocess_exception& e)
 	{
 		curFile = e.file_name();
 		auto yypos = yy::position(&curFile, e.line_no(), e.column_no());

libelf/src/config.h

@@ -52,9 +52,6 @@
 # define rwlock_unlock(lock) ((void) (lock))
 #endif	/* USE_LOCKS */
 
-/* gettext helper macro.  */
-#define N_(Str) Str
-
 /* Compiler-specific definitions.  */
 //#define strong_alias(name, aliasname) \
  // extern __typeof (name) aliasname __attribute__ ((alias (#name)));