2010-12-26 19:39:38 +00:00
|
|
|
//===-- LoopIdiomRecognize.cpp - Loop idiom recognition -------------------===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This pass implements an idiom recognizer that transforms simple loops into a
|
|
|
|
// non-loop form. In cases that this kicks in, it can be a significant
|
|
|
|
// performance win.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
2011-01-02 18:32:09 +00:00
|
|
|
//
|
|
|
|
// TODO List:
|
|
|
|
//
|
|
|
|
// Future loop memory idioms to recognize:
|
2012-11-02 08:33:25 +00:00
|
|
|
// memcmp, memmove, strlen, etc.
|
2011-01-02 18:32:09 +00:00
|
|
|
// Future floating point idioms to recognize in -ffast-math mode:
|
|
|
|
// fpowi
|
|
|
|
// Future integer operation idioms to recognize:
|
|
|
|
// ctpop, ctlz, cttz
|
|
|
|
//
|
|
|
|
// Beware that isel's default lowering for ctpop is highly inefficient for
|
|
|
|
// i64 and larger types when i64 is legal and the value has few bits set. It
|
|
|
|
// would be good to enhance isel to emit a loop for ctpop in this case.
|
|
|
|
//
|
|
|
|
// We should enhance the memset/memcpy recognition to handle multiple stores in
|
|
|
|
// the loop. This would handle things like:
|
|
|
|
// void foo(_Complex float *P)
|
|
|
|
// for (i) { __real__(*P) = 0; __imag__(*P) = 0; }
|
2011-01-02 23:19:45 +00:00
|
|
|
//
|
2011-02-21 02:08:54 +00:00
|
|
|
// We should enhance this to handle negative strides through memory.
|
|
|
|
// Alternatively (and perhaps better) we could rely on an earlier pass to force
|
|
|
|
// forward iteration through memory, which is generally better for cache
|
|
|
|
// behavior. Negative strides *do* happen for memset/memcpy loops.
|
|
|
|
//
|
2011-01-03 01:10:08 +00:00
|
|
|
// This could recognize common matrix multiplies and dot product idioms and
|
2011-01-02 23:19:45 +00:00
|
|
|
// replace them with calls to BLAS (if linked in??).
|
|
|
|
//
|
2011-01-02 18:32:09 +00:00
|
|
|
//===----------------------------------------------------------------------===//
|
2010-12-26 19:39:38 +00:00
|
|
|
|
|
|
|
#include "llvm/Transforms/Scalar.h"
|
2012-06-29 12:38:19 +00:00
|
|
|
#include "llvm/ADT/Statistic.h"
|
2010-12-27 18:39:08 +00:00
|
|
|
#include "llvm/Analysis/AliasAnalysis.h"
|
2010-12-26 19:39:38 +00:00
|
|
|
#include "llvm/Analysis/LoopPass.h"
|
implement enough of the memset inference algorithm to recognize and insert
memsets. This is still missing one important validity check, but this is enough
to compile stuff like this:
void test0(std::vector<char> &X) {
for (std::vector<char>::iterator I = X.begin(), E = X.end(); I != E; ++I)
*I = 0;
}
void test1(std::vector<int> &X) {
for (long i = 0, e = X.size(); i != e; ++i)
X[i] = 0x01010101;
}
With:
$ clang t.cpp -S -o - -O2 -emit-llvm | opt -loop-idiom | opt -O3 | llc
to:
__Z5test0RSt6vectorIcSaIcEE: ## @_Z5test0RSt6vectorIcSaIcEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rsi
cmpq %rsi, %rax
je LBB0_2
## BB#1: ## %bb.nph
subq %rax, %rsi
movq %rax, %rdi
callq ___bzero
LBB0_2: ## %for.end
addq $8, %rsp
ret
...
__Z5test1RSt6vectorIiSaIiEE: ## @_Z5test1RSt6vectorIiSaIiEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rdx
subq %rax, %rdx
cmpq $4, %rdx
jb LBB1_2
## BB#1: ## %for.body.preheader
andq $-4, %rdx
movl $1, %esi
movq %rax, %rdi
callq _memset
LBB1_2: ## %for.end
addq $8, %rsp
ret
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122573 91177308-0d34-0410-b5e6-96231b3b80d8
2010-12-26 23:42:51 +00:00
|
|
|
#include "llvm/Analysis/ScalarEvolutionExpander.h"
|
2012-06-29 12:38:19 +00:00
|
|
|
#include "llvm/Analysis/ScalarEvolutionExpressions.h"
|
2013-01-07 03:08:10 +00:00
|
|
|
#include "llvm/Analysis/TargetTransformInfo.h"
|
2010-12-26 20:45:45 +00:00
|
|
|
#include "llvm/Analysis/ValueTracking.h"
|
2013-01-02 11:36:10 +00:00
|
|
|
#include "llvm/IR/DataLayout.h"
|
2014-01-13 09:26:24 +00:00
|
|
|
#include "llvm/IR/Dominators.h"
|
2013-01-02 11:36:10 +00:00
|
|
|
#include "llvm/IR/IRBuilder.h"
|
|
|
|
#include "llvm/IR/IntrinsicInst.h"
|
|
|
|
#include "llvm/IR/Module.h"
|
2012-06-29 12:38:19 +00:00
|
|
|
#include "llvm/Support/Debug.h"
|
|
|
|
#include "llvm/Support/raw_ostream.h"
|
2015-01-15 02:16:27 +00:00
|
|
|
#include "llvm/Analysis/TargetLibraryInfo.h"
|
2010-12-27 00:03:23 +00:00
|
|
|
#include "llvm/Transforms/Utils/Local.h"
|
2010-12-26 19:39:38 +00:00
|
|
|
using namespace llvm;
|
|
|
|
|
2014-04-22 02:55:47 +00:00
|
|
|
#define DEBUG_TYPE "loop-idiom"
|
|
|
|
|
2012-11-02 08:33:25 +00:00
|
|
|
STATISTIC(NumMemSet, "Number of memset's formed from loop stores");
|
|
|
|
STATISTIC(NumMemCpy, "Number of memcpy's formed from loop load+stores");
|
2010-12-26 19:39:38 +00:00
|
|
|
|
|
|
|
namespace {
|
2012-12-09 03:12:46 +00:00
|
|
|
|
|
|
|
class LoopIdiomRecognize;
|
|
|
|
|
|
|
|
/// This class defines some utility functions for loop idiom recognization.
|
|
|
|
class LIRUtil {
|
|
|
|
public:
|
|
|
|
/// Return true iff the block contains nothing but an uncondition branch
|
|
|
|
/// (aka goto instruction).
|
|
|
|
static bool isAlmostEmpty(BasicBlock *);
|
|
|
|
|
|
|
|
static BranchInst *getBranch(BasicBlock *BB) {
|
|
|
|
return dyn_cast<BranchInst>(BB->getTerminator());
|
|
|
|
}
|
|
|
|
|
2013-07-22 18:59:58 +00:00
|
|
|
/// Derive the precondition block (i.e the block that guards the loop
|
2012-12-09 03:12:46 +00:00
|
|
|
/// preheader) from the given preheader.
|
|
|
|
static BasicBlock *getPrecondBb(BasicBlock *PreHead);
|
|
|
|
};
|
|
|
|
|
|
|
|
/// This class is to recoginize idioms of population-count conducted in
|
|
|
|
/// a noncountable loop. Currently it only recognizes this pattern:
|
|
|
|
/// \code
|
|
|
|
/// while(x) {cnt++; ...; x &= x - 1; ...}
|
|
|
|
/// \endcode
|
|
|
|
class NclPopcountRecognize {
|
|
|
|
LoopIdiomRecognize &LIR;
|
|
|
|
Loop *CurLoop;
|
|
|
|
BasicBlock *PreCondBB;
|
|
|
|
|
|
|
|
typedef IRBuilder<> IRBuilderTy;
|
|
|
|
|
|
|
|
public:
|
|
|
|
explicit NclPopcountRecognize(LoopIdiomRecognize &TheLIR);
|
|
|
|
bool recognize();
|
|
|
|
|
|
|
|
private:
|
|
|
|
/// Take a glimpse of the loop to see if we need to go ahead recoginizing
|
|
|
|
/// the idiom.
|
|
|
|
bool preliminaryScreen();
|
|
|
|
|
|
|
|
/// Check if the given conditional branch is based on the comparison
|
2014-01-24 17:20:08 +00:00
|
|
|
/// between a variable and zero, and if the variable is non-zero, the
|
|
|
|
/// control yields to the loop entry. If the branch matches the behavior,
|
2012-12-09 03:12:46 +00:00
|
|
|
/// the variable involved in the comparion is returned. This function will
|
2013-07-22 18:59:58 +00:00
|
|
|
/// be called to see if the precondition and postcondition of the loop
|
2012-12-09 03:12:46 +00:00
|
|
|
/// are in desirable form.
|
2014-06-14 03:48:29 +00:00
|
|
|
Value *matchCondition(BranchInst *Br, BasicBlock *NonZeroTarget) const;
|
2012-12-09 03:12:46 +00:00
|
|
|
|
|
|
|
/// Return true iff the idiom is detected in the loop. and 1) \p CntInst
|
2014-04-29 22:41:55 +00:00
|
|
|
/// is set to the instruction counting the population bit. 2) \p CntPhi
|
2012-12-09 03:12:46 +00:00
|
|
|
/// is set to the corresponding phi node. 3) \p Var is set to the value
|
|
|
|
/// whose population bits are being counted.
|
|
|
|
bool detectIdiom
|
|
|
|
(Instruction *&CntInst, PHINode *&CntPhi, Value *&Var) const;
|
|
|
|
|
|
|
|
/// Insert ctpop intrinsic function and some obviously dead instructions.
|
2014-06-14 03:48:29 +00:00
|
|
|
void transform(Instruction *CntInst, PHINode *CntPhi, Value *Var);
|
2012-12-09 03:12:46 +00:00
|
|
|
|
|
|
|
/// Create llvm.ctpop.* intrinsic function.
|
|
|
|
CallInst *createPopcntIntrinsic(IRBuilderTy &IRB, Value *Val, DebugLoc DL);
|
|
|
|
};
|
|
|
|
|
2010-12-26 19:39:38 +00:00
|
|
|
class LoopIdiomRecognize : public LoopPass {
|
2010-12-26 20:45:45 +00:00
|
|
|
Loop *CurLoop;
|
2014-02-21 00:06:31 +00:00
|
|
|
const DataLayout *DL;
|
2011-01-02 19:01:03 +00:00
|
|
|
DominatorTree *DT;
|
2010-12-26 20:45:45 +00:00
|
|
|
ScalarEvolution *SE;
|
2011-02-18 22:22:15 +00:00
|
|
|
TargetLibraryInfo *TLI;
|
2013-01-05 10:00:09 +00:00
|
|
|
const TargetTransformInfo *TTI;
|
2010-12-26 19:39:38 +00:00
|
|
|
public:
|
|
|
|
static char ID;
|
|
|
|
explicit LoopIdiomRecognize() : LoopPass(ID) {
|
|
|
|
initializeLoopIdiomRecognizePass(*PassRegistry::getPassRegistry());
|
2014-04-25 05:29:35 +00:00
|
|
|
DL = nullptr; DT = nullptr; SE = nullptr; TLI = nullptr; TTI = nullptr;
|
2010-12-26 19:39:38 +00:00
|
|
|
}
|
|
|
|
|
2014-03-05 09:10:37 +00:00
|
|
|
bool runOnLoop(Loop *L, LPPassManager &LPM) override;
|
2011-01-02 19:01:03 +00:00
|
|
|
bool runOnLoopBlock(BasicBlock *BB, const SCEV *BECount,
|
|
|
|
SmallVectorImpl<BasicBlock*> &ExitBlocks);
|
2010-12-26 19:39:38 +00:00
|
|
|
|
2010-12-26 20:45:45 +00:00
|
|
|
bool processLoopStore(StoreInst *SI, const SCEV *BECount);
|
2011-01-04 07:46:33 +00:00
|
|
|
bool processLoopMemSet(MemSetInst *MSI, const SCEV *BECount);
|
2011-03-14 16:48:10 +00:00
|
|
|
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
bool processLoopStridedStore(Value *DestPtr, unsigned StoreSize,
|
|
|
|
unsigned StoreAlignment,
|
|
|
|
Value *SplatValue, Instruction *TheStore,
|
|
|
|
const SCEVAddRecExpr *Ev,
|
|
|
|
const SCEV *BECount);
|
2011-01-02 03:37:56 +00:00
|
|
|
bool processLoopStoreOfLoopLoad(StoreInst *SI, unsigned StoreSize,
|
|
|
|
const SCEVAddRecExpr *StoreEv,
|
|
|
|
const SCEVAddRecExpr *LoadEv,
|
|
|
|
const SCEV *BECount);
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2010-12-26 19:39:38 +00:00
|
|
|
/// This transformation requires natural loop information & requires that
|
|
|
|
/// loop preheaders be inserted into the CFG.
|
|
|
|
///
|
2014-03-05 09:10:37 +00:00
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
2015-01-17 14:16:18 +00:00
|
|
|
AU.addRequired<LoopInfoWrapperPass>();
|
|
|
|
AU.addPreserved<LoopInfoWrapperPass>();
|
2010-12-26 19:39:38 +00:00
|
|
|
AU.addRequiredID(LoopSimplifyID);
|
|
|
|
AU.addPreservedID(LoopSimplifyID);
|
|
|
|
AU.addRequiredID(LCSSAID);
|
|
|
|
AU.addPreservedID(LCSSAID);
|
2010-12-27 18:39:08 +00:00
|
|
|
AU.addRequired<AliasAnalysis>();
|
|
|
|
AU.addPreserved<AliasAnalysis>();
|
2010-12-26 19:39:38 +00:00
|
|
|
AU.addRequired<ScalarEvolution>();
|
|
|
|
AU.addPreserved<ScalarEvolution>();
|
2014-01-13 13:07:17 +00:00
|
|
|
AU.addPreserved<DominatorTreeWrapperPass>();
|
|
|
|
AU.addRequired<DominatorTreeWrapperPass>();
|
2015-01-15 10:41:28 +00:00
|
|
|
AU.addRequired<TargetLibraryInfoWrapperPass>();
|
[PM] Change the core design of the TTI analysis to use a polymorphic
type erased interface and a single analysis pass rather than an
extremely complex analysis group.
The end result is that the TTI analysis can contain a type erased
implementation that supports the polymorphic TTI interface. We can build
one from a target-specific implementation or from a dummy one in the IR.
I've also factored all of the code into "mix-in"-able base classes,
including CRTP base classes to facilitate calling back up to the most
specialized form when delegating horizontally across the surface. These
aren't as clean as I would like and I'm planning to work on cleaning
some of this up, but I wanted to start by putting into the right form.
There are a number of reasons for this change, and this particular
design. The first and foremost reason is that an analysis group is
complete overkill, and the chaining delegation strategy was so opaque,
confusing, and high overhead that TTI was suffering greatly for it.
Several of the TTI functions had failed to be implemented in all places
because of the chaining-based delegation making there be no checking of
this. A few other functions were implemented with incorrect delegation.
The message to me was very clear working on this -- the delegation and
analysis group structure was too confusing to be useful here.
The other reason of course is that this is *much* more natural fit for
the new pass manager. This will lay the ground work for a type-erased
per-function info object that can look up the correct subtarget and even
cache it.
Yet another benefit is that this will significantly simplify the
interaction of the pass managers and the TargetMachine. See the future
work below.
The downside of this change is that it is very, very verbose. I'm going
to work to improve that, but it is somewhat an implementation necessity
in C++ to do type erasure. =/ I discussed this design really extensively
with Eric and Hal prior to going down this path, and afterward showed
them the result. No one was really thrilled with it, but there doesn't
seem to be a substantially better alternative. Using a base class and
virtual method dispatch would make the code much shorter, but as
discussed in the update to the programmer's manual and elsewhere,
a polymorphic interface feels like the more principled approach even if
this is perhaps the least compelling example of it. ;]
Ultimately, there is still a lot more to be done here, but this was the
huge chunk that I couldn't really split things out of because this was
the interface change to TTI. I've tried to minimize all the other parts
of this. The follow up work should include at least:
1) Improving the TargetMachine interface by having it directly return
a TTI object. Because we have a non-pass object with value semantics
and an internal type erasure mechanism, we can narrow the interface
of the TargetMachine to *just* do what we need: build and return
a TTI object that we can then insert into the pass pipeline.
2) Make the TTI object be fully specialized for a particular function.
This will include splitting off a minimal form of it which is
sufficient for the inliner and the old pass manager.
3) Add a new pass manager analysis which produces TTI objects from the
target machine for each function. This may actually be done as part
of #2 in order to use the new analysis to implement #2.
4) Work on narrowing the API between TTI and the targets so that it is
easier to understand and less verbose to type erase.
5) Work on narrowing the API between TTI and its clients so that it is
easier to understand and less verbose to forward.
6) Try to improve the CRTP-based delegation. I feel like this code is
just a bit messy and exacerbating the complexity of implementing
the TTI in each target.
Many thanks to Eric and Hal for their help here. I ended up blocked on
this somewhat more abruptly than I expected, and so I appreciate getting
it sorted out very quickly.
Differential Revision: http://reviews.llvm.org/D7293
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@227669 91177308-0d34-0410-b5e6-96231b3b80d8
2015-01-31 03:43:40 +00:00
|
|
|
AU.addRequired<TargetTransformInfoWrapperPass>();
|
2010-12-26 19:39:38 +00:00
|
|
|
}
|
2012-12-09 03:12:46 +00:00
|
|
|
|
|
|
|
const DataLayout *getDataLayout() {
|
2014-02-25 17:30:31 +00:00
|
|
|
if (DL)
|
|
|
|
return DL;
|
|
|
|
DataLayoutPass *DLP = getAnalysisIfAvailable<DataLayoutPass>();
|
2014-04-25 05:29:35 +00:00
|
|
|
DL = DLP ? &DLP->getDataLayout() : nullptr;
|
2014-02-25 17:30:31 +00:00
|
|
|
return DL;
|
2012-12-09 03:12:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
DominatorTree *getDominatorTree() {
|
2014-01-13 13:07:17 +00:00
|
|
|
return DT ? DT
|
|
|
|
: (DT = &getAnalysis<DominatorTreeWrapperPass>().getDomTree());
|
2012-12-09 03:12:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
ScalarEvolution *getScalarEvolution() {
|
|
|
|
return SE ? SE : (SE = &getAnalysis<ScalarEvolution>());
|
|
|
|
}
|
|
|
|
|
|
|
|
TargetLibraryInfo *getTargetLibraryInfo() {
|
2015-01-15 10:41:28 +00:00
|
|
|
if (!TLI)
|
|
|
|
TLI = &getAnalysis<TargetLibraryInfoWrapperPass>().getTLI();
|
|
|
|
|
|
|
|
return TLI;
|
2012-12-09 03:12:46 +00:00
|
|
|
}
|
|
|
|
|
2013-01-05 10:00:09 +00:00
|
|
|
const TargetTransformInfo *getTargetTransformInfo() {
|
2015-02-01 12:01:35 +00:00
|
|
|
return TTI ? TTI
|
|
|
|
: (TTI = &getAnalysis<TargetTransformInfoWrapperPass>().getTTI(
|
|
|
|
*CurLoop->getHeader()->getParent()));
|
2012-12-09 03:12:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
Loop *getLoop() const { return CurLoop; }
|
|
|
|
|
|
|
|
private:
|
|
|
|
bool runOnNoncountableLoop();
|
|
|
|
bool runOnCountableLoop();
|
2010-12-26 19:39:38 +00:00
|
|
|
};
|
|
|
|
}
|
|
|
|
|
|
|
|
char LoopIdiomRecognize::ID = 0;
|
|
|
|
INITIALIZE_PASS_BEGIN(LoopIdiomRecognize, "loop-idiom", "Recognize loop idioms",
|
|
|
|
false, false)
|
2015-01-17 14:16:18 +00:00
|
|
|
INITIALIZE_PASS_DEPENDENCY(LoopInfoWrapperPass)
|
2014-01-13 13:07:17 +00:00
|
|
|
INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass)
|
2010-12-26 19:39:38 +00:00
|
|
|
INITIALIZE_PASS_DEPENDENCY(LoopSimplify)
|
|
|
|
INITIALIZE_PASS_DEPENDENCY(LCSSA)
|
|
|
|
INITIALIZE_PASS_DEPENDENCY(ScalarEvolution)
|
2015-01-15 10:41:28 +00:00
|
|
|
INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfoWrapperPass)
|
2010-12-27 18:39:08 +00:00
|
|
|
INITIALIZE_AG_DEPENDENCY(AliasAnalysis)
|
[PM] Change the core design of the TTI analysis to use a polymorphic
type erased interface and a single analysis pass rather than an
extremely complex analysis group.
The end result is that the TTI analysis can contain a type erased
implementation that supports the polymorphic TTI interface. We can build
one from a target-specific implementation or from a dummy one in the IR.
I've also factored all of the code into "mix-in"-able base classes,
including CRTP base classes to facilitate calling back up to the most
specialized form when delegating horizontally across the surface. These
aren't as clean as I would like and I'm planning to work on cleaning
some of this up, but I wanted to start by putting into the right form.
There are a number of reasons for this change, and this particular
design. The first and foremost reason is that an analysis group is
complete overkill, and the chaining delegation strategy was so opaque,
confusing, and high overhead that TTI was suffering greatly for it.
Several of the TTI functions had failed to be implemented in all places
because of the chaining-based delegation making there be no checking of
this. A few other functions were implemented with incorrect delegation.
The message to me was very clear working on this -- the delegation and
analysis group structure was too confusing to be useful here.
The other reason of course is that this is *much* more natural fit for
the new pass manager. This will lay the ground work for a type-erased
per-function info object that can look up the correct subtarget and even
cache it.
Yet another benefit is that this will significantly simplify the
interaction of the pass managers and the TargetMachine. See the future
work below.
The downside of this change is that it is very, very verbose. I'm going
to work to improve that, but it is somewhat an implementation necessity
in C++ to do type erasure. =/ I discussed this design really extensively
with Eric and Hal prior to going down this path, and afterward showed
them the result. No one was really thrilled with it, but there doesn't
seem to be a substantially better alternative. Using a base class and
virtual method dispatch would make the code much shorter, but as
discussed in the update to the programmer's manual and elsewhere,
a polymorphic interface feels like the more principled approach even if
this is perhaps the least compelling example of it. ;]
Ultimately, there is still a lot more to be done here, but this was the
huge chunk that I couldn't really split things out of because this was
the interface change to TTI. I've tried to minimize all the other parts
of this. The follow up work should include at least:
1) Improving the TargetMachine interface by having it directly return
a TTI object. Because we have a non-pass object with value semantics
and an internal type erasure mechanism, we can narrow the interface
of the TargetMachine to *just* do what we need: build and return
a TTI object that we can then insert into the pass pipeline.
2) Make the TTI object be fully specialized for a particular function.
This will include splitting off a minimal form of it which is
sufficient for the inliner and the old pass manager.
3) Add a new pass manager analysis which produces TTI objects from the
target machine for each function. This may actually be done as part
of #2 in order to use the new analysis to implement #2.
4) Work on narrowing the API between TTI and the targets so that it is
easier to understand and less verbose to type erase.
5) Work on narrowing the API between TTI and its clients so that it is
easier to understand and less verbose to forward.
6) Try to improve the CRTP-based delegation. I feel like this code is
just a bit messy and exacerbating the complexity of implementing
the TTI in each target.
Many thanks to Eric and Hal for their help here. I ended up blocked on
this somewhat more abruptly than I expected, and so I appreciate getting
it sorted out very quickly.
Differential Revision: http://reviews.llvm.org/D7293
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@227669 91177308-0d34-0410-b5e6-96231b3b80d8
2015-01-31 03:43:40 +00:00
|
|
|
INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass)
|
2010-12-26 19:39:38 +00:00
|
|
|
INITIALIZE_PASS_END(LoopIdiomRecognize, "loop-idiom", "Recognize loop idioms",
|
|
|
|
false, false)
|
|
|
|
|
|
|
|
Pass *llvm::createLoopIdiomPass() { return new LoopIdiomRecognize(); }
|
|
|
|
|
2011-05-22 17:39:56 +00:00
|
|
|
/// deleteDeadInstruction - Delete this instruction. Before we do, go through
|
2010-12-27 00:03:23 +00:00
|
|
|
/// and zero out all the operands of this instruction. If any of them become
|
|
|
|
/// dead, delete them and the computation tree that feeds them.
|
|
|
|
///
|
2015-02-07 21:37:08 +00:00
|
|
|
static void deleteDeadInstruction(Instruction *I,
|
2012-08-29 15:32:21 +00:00
|
|
|
const TargetLibraryInfo *TLI) {
|
2015-02-07 21:37:08 +00:00
|
|
|
SmallVector<Value *, 16> Operands(I->value_op_begin(), I->value_op_end());
|
|
|
|
I->replaceAllUsesWith(UndefValue::get(I->getType()));
|
|
|
|
I->eraseFromParent();
|
|
|
|
for (Value *Op : Operands)
|
|
|
|
RecursivelyDeleteTriviallyDeadInstructions(Op, TLI);
|
2012-11-02 08:33:25 +00:00
|
|
|
}
|
|
|
|
|
2012-12-09 03:12:46 +00:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// Implementation of LIRUtil
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
2012-11-29 19:38:54 +00:00
|
|
|
|
2013-07-22 18:59:58 +00:00
|
|
|
// This function will return true iff the given block contains nothing but goto.
|
|
|
|
// A typical usage of this function is to check if the preheader function is
|
|
|
|
// "almost" empty such that generated intrinsic functions can be moved across
|
|
|
|
// the preheader and be placed at the end of the precondition block without
|
|
|
|
// the concern of breaking data dependence.
|
2012-12-09 03:12:46 +00:00
|
|
|
bool LIRUtil::isAlmostEmpty(BasicBlock *BB) {
|
|
|
|
if (BranchInst *Br = getBranch(BB)) {
|
2015-02-07 21:37:08 +00:00
|
|
|
return Br->isUnconditional() && Br == BB->begin();
|
2012-12-09 03:12:46 +00:00
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
BasicBlock *LIRUtil::getPrecondBb(BasicBlock *PreHead) {
|
|
|
|
if (BasicBlock *BB = PreHead->getSinglePredecessor()) {
|
|
|
|
BranchInst *Br = getBranch(BB);
|
2014-04-25 05:29:35 +00:00
|
|
|
return Br && Br->isConditional() ? BB : nullptr;
|
2012-12-09 03:12:46 +00:00
|
|
|
}
|
2014-04-25 05:29:35 +00:00
|
|
|
return nullptr;
|
2012-12-09 03:12:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// Implementation of NclPopcountRecognize
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
NclPopcountRecognize::NclPopcountRecognize(LoopIdiomRecognize &TheLIR):
|
2014-04-25 05:29:35 +00:00
|
|
|
LIR(TheLIR), CurLoop(TheLIR.getLoop()), PreCondBB(nullptr) {
|
2012-12-09 03:12:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
bool NclPopcountRecognize::preliminaryScreen() {
|
2013-01-05 10:00:09 +00:00
|
|
|
const TargetTransformInfo *TTI = LIR.getTargetTransformInfo();
|
2013-01-07 03:16:03 +00:00
|
|
|
if (TTI->getPopcntSupport(32) != TargetTransformInfo::PSK_FastHardware)
|
2012-11-29 19:38:54 +00:00
|
|
|
return false;
|
|
|
|
|
2013-09-28 13:42:22 +00:00
|
|
|
// Counting population are usually conducted by few arithmetic instructions.
|
2012-12-09 03:12:46 +00:00
|
|
|
// Such instructions can be easilly "absorbed" by vacant slots in a
|
|
|
|
// non-compact loop. Therefore, recognizing popcount idiom only makes sense
|
|
|
|
// in a compact loop.
|
|
|
|
|
|
|
|
// Give up if the loop has multiple blocks or multiple backedges.
|
|
|
|
if (CurLoop->getNumBackEdges() != 1 || CurLoop->getNumBlocks() != 1)
|
2010-12-26 20:45:45 +00:00
|
|
|
return false;
|
2012-11-29 19:38:54 +00:00
|
|
|
|
2012-12-09 03:12:46 +00:00
|
|
|
BasicBlock *LoopBody = *(CurLoop->block_begin());
|
|
|
|
if (LoopBody->size() >= 20) {
|
|
|
|
// The loop is too big, bail out.
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// It should have a preheader containing nothing but a goto instruction.
|
|
|
|
BasicBlock *PreHead = CurLoop->getLoopPreheader();
|
|
|
|
if (!PreHead || !LIRUtil::isAlmostEmpty(PreHead))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// It should have a precondition block where the generated popcount instrinsic
|
|
|
|
// function will be inserted.
|
|
|
|
PreCondBB = LIRUtil::getPrecondBb(PreHead);
|
|
|
|
if (!PreCondBB)
|
2012-11-29 19:38:54 +00:00
|
|
|
return false;
|
2013-07-22 18:59:58 +00:00
|
|
|
|
2012-12-09 03:12:46 +00:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2014-04-29 22:41:58 +00:00
|
|
|
Value *NclPopcountRecognize::matchCondition(BranchInst *Br,
|
|
|
|
BasicBlock *LoopEntry) const {
|
2012-12-09 03:12:46 +00:00
|
|
|
if (!Br || !Br->isConditional())
|
2014-04-25 05:29:35 +00:00
|
|
|
return nullptr;
|
2012-12-09 03:12:46 +00:00
|
|
|
|
|
|
|
ICmpInst *Cond = dyn_cast<ICmpInst>(Br->getCondition());
|
|
|
|
if (!Cond)
|
2014-04-25 05:29:35 +00:00
|
|
|
return nullptr;
|
2012-12-09 03:12:46 +00:00
|
|
|
|
|
|
|
ConstantInt *CmpZero = dyn_cast<ConstantInt>(Cond->getOperand(1));
|
|
|
|
if (!CmpZero || !CmpZero->isZero())
|
2014-04-25 05:29:35 +00:00
|
|
|
return nullptr;
|
2012-12-09 03:12:46 +00:00
|
|
|
|
|
|
|
ICmpInst::Predicate Pred = Cond->getPredicate();
|
|
|
|
if ((Pred == ICmpInst::ICMP_NE && Br->getSuccessor(0) == LoopEntry) ||
|
|
|
|
(Pred == ICmpInst::ICMP_EQ && Br->getSuccessor(1) == LoopEntry))
|
|
|
|
return Cond->getOperand(0);
|
|
|
|
|
2014-04-25 05:29:35 +00:00
|
|
|
return nullptr;
|
2012-12-09 03:12:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
bool NclPopcountRecognize::detectIdiom(Instruction *&CntInst,
|
|
|
|
PHINode *&CntPhi,
|
|
|
|
Value *&Var) const {
|
|
|
|
// Following code tries to detect this idiom:
|
|
|
|
//
|
|
|
|
// if (x0 != 0)
|
|
|
|
// goto loop-exit // the precondition of the loop
|
|
|
|
// cnt0 = init-val;
|
|
|
|
// do {
|
|
|
|
// x1 = phi (x0, x2);
|
|
|
|
// cnt1 = phi(cnt0, cnt2);
|
|
|
|
//
|
|
|
|
// cnt2 = cnt1 + 1;
|
|
|
|
// ...
|
|
|
|
// x2 = x1 & (x1 - 1);
|
|
|
|
// ...
|
|
|
|
// } while(x != 0);
|
|
|
|
//
|
|
|
|
// loop-exit:
|
|
|
|
//
|
|
|
|
|
|
|
|
// step 1: Check to see if the look-back branch match this pattern:
|
|
|
|
// "if (a!=0) goto loop-entry".
|
|
|
|
BasicBlock *LoopEntry;
|
|
|
|
Instruction *DefX2, *CountInst;
|
|
|
|
Value *VarX1, *VarX0;
|
|
|
|
PHINode *PhiX, *CountPhi;
|
|
|
|
|
2014-04-25 05:29:35 +00:00
|
|
|
DefX2 = CountInst = nullptr;
|
|
|
|
VarX1 = VarX0 = nullptr;
|
|
|
|
PhiX = CountPhi = nullptr;
|
2012-12-09 03:12:46 +00:00
|
|
|
LoopEntry = *(CurLoop->block_begin());
|
|
|
|
|
|
|
|
// step 1: Check if the loop-back branch is in desirable form.
|
|
|
|
{
|
|
|
|
if (Value *T = matchCondition (LIRUtil::getBranch(LoopEntry), LoopEntry))
|
|
|
|
DefX2 = dyn_cast<Instruction>(T);
|
|
|
|
else
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// step 2: detect instructions corresponding to "x2 = x1 & (x1 - 1)"
|
|
|
|
{
|
2013-01-10 23:32:01 +00:00
|
|
|
if (!DefX2 || DefX2->getOpcode() != Instruction::And)
|
2012-12-09 03:12:46 +00:00
|
|
|
return false;
|
|
|
|
|
|
|
|
BinaryOperator *SubOneOp;
|
|
|
|
|
|
|
|
if ((SubOneOp = dyn_cast<BinaryOperator>(DefX2->getOperand(0))))
|
|
|
|
VarX1 = DefX2->getOperand(1);
|
|
|
|
else {
|
|
|
|
VarX1 = DefX2->getOperand(0);
|
|
|
|
SubOneOp = dyn_cast<BinaryOperator>(DefX2->getOperand(1));
|
|
|
|
}
|
|
|
|
if (!SubOneOp)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
Instruction *SubInst = cast<Instruction>(SubOneOp);
|
|
|
|
ConstantInt *Dec = dyn_cast<ConstantInt>(SubInst->getOperand(1));
|
|
|
|
if (!Dec ||
|
|
|
|
!((SubInst->getOpcode() == Instruction::Sub && Dec->isOne()) ||
|
|
|
|
(SubInst->getOpcode() == Instruction::Add && Dec->isAllOnesValue()))) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// step 3: Check the recurrence of variable X
|
|
|
|
{
|
|
|
|
PhiX = dyn_cast<PHINode>(VarX1);
|
|
|
|
if (!PhiX ||
|
|
|
|
(PhiX->getOperand(0) != DefX2 && PhiX->getOperand(1) != DefX2)) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// step 4: Find the instruction which count the population: cnt2 = cnt1 + 1
|
|
|
|
{
|
2014-04-25 05:29:35 +00:00
|
|
|
CountInst = nullptr;
|
2012-12-09 03:12:46 +00:00
|
|
|
for (BasicBlock::iterator Iter = LoopEntry->getFirstNonPHI(),
|
|
|
|
IterE = LoopEntry->end(); Iter != IterE; Iter++) {
|
|
|
|
Instruction *Inst = Iter;
|
|
|
|
if (Inst->getOpcode() != Instruction::Add)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
ConstantInt *Inc = dyn_cast<ConstantInt>(Inst->getOperand(1));
|
|
|
|
if (!Inc || !Inc->isOne())
|
|
|
|
continue;
|
|
|
|
|
|
|
|
PHINode *Phi = dyn_cast<PHINode>(Inst->getOperand(0));
|
|
|
|
if (!Phi || Phi->getParent() != LoopEntry)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Check if the result of the instruction is live of the loop.
|
|
|
|
bool LiveOutLoop = false;
|
2014-03-09 03:16:01 +00:00
|
|
|
for (User *U : Inst->users()) {
|
|
|
|
if ((cast<Instruction>(U))->getParent() != LoopEntry) {
|
2012-12-09 03:12:46 +00:00
|
|
|
LiveOutLoop = true; break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (LiveOutLoop) {
|
|
|
|
CountInst = Inst;
|
|
|
|
CountPhi = Phi;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!CountInst)
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// step 5: check if the precondition is in this form:
|
|
|
|
// "if (x != 0) goto loop-head ; else goto somewhere-we-don't-care;"
|
|
|
|
{
|
|
|
|
BranchInst *PreCondBr = LIRUtil::getBranch(PreCondBB);
|
|
|
|
Value *T = matchCondition (PreCondBr, CurLoop->getLoopPreheader());
|
|
|
|
if (T != PhiX->getOperand(0) && T != PhiX->getOperand(1))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
CntInst = CountInst;
|
|
|
|
CntPhi = CountPhi;
|
|
|
|
Var = T;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void NclPopcountRecognize::transform(Instruction *CntInst,
|
|
|
|
PHINode *CntPhi, Value *Var) {
|
|
|
|
|
|
|
|
ScalarEvolution *SE = LIR.getScalarEvolution();
|
|
|
|
TargetLibraryInfo *TLI = LIR.getTargetLibraryInfo();
|
|
|
|
BasicBlock *PreHead = CurLoop->getLoopPreheader();
|
|
|
|
BranchInst *PreCondBr = LIRUtil::getBranch(PreCondBB);
|
|
|
|
const DebugLoc DL = CntInst->getDebugLoc();
|
|
|
|
|
|
|
|
// Assuming before transformation, the loop is following:
|
|
|
|
// if (x) // the precondition
|
|
|
|
// do { cnt++; x &= x - 1; } while(x);
|
2013-07-22 18:59:58 +00:00
|
|
|
|
2012-12-09 03:12:46 +00:00
|
|
|
// Step 1: Insert the ctpop instruction at the end of the precondition block
|
|
|
|
IRBuilderTy Builder(PreCondBr);
|
|
|
|
Value *PopCnt, *PopCntZext, *NewCount, *TripCnt;
|
|
|
|
{
|
|
|
|
PopCnt = createPopcntIntrinsic(Builder, Var, DL);
|
|
|
|
NewCount = PopCntZext =
|
|
|
|
Builder.CreateZExtOrTrunc(PopCnt, cast<IntegerType>(CntPhi->getType()));
|
|
|
|
|
|
|
|
if (NewCount != PopCnt)
|
|
|
|
(cast<Instruction>(NewCount))->setDebugLoc(DL);
|
|
|
|
|
|
|
|
// TripCnt is exactly the number of iterations the loop has
|
|
|
|
TripCnt = NewCount;
|
|
|
|
|
2014-01-24 17:20:08 +00:00
|
|
|
// If the population counter's initial value is not zero, insert Add Inst.
|
2012-12-09 03:12:46 +00:00
|
|
|
Value *CntInitVal = CntPhi->getIncomingValueForBlock(PreHead);
|
|
|
|
ConstantInt *InitConst = dyn_cast<ConstantInt>(CntInitVal);
|
|
|
|
if (!InitConst || !InitConst->isZero()) {
|
|
|
|
NewCount = Builder.CreateAdd(NewCount, CntInitVal);
|
|
|
|
(cast<Instruction>(NewCount))->setDebugLoc(DL);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Step 2: Replace the precondition from "if(x == 0) goto loop-exit" to
|
|
|
|
// "if(NewCount == 0) loop-exit". Withtout this change, the intrinsic
|
|
|
|
// function would be partial dead code, and downstream passes will drag
|
|
|
|
// it back from the precondition block to the preheader.
|
|
|
|
{
|
|
|
|
ICmpInst *PreCond = cast<ICmpInst>(PreCondBr->getCondition());
|
|
|
|
|
|
|
|
Value *Opnd0 = PopCntZext;
|
|
|
|
Value *Opnd1 = ConstantInt::get(PopCntZext->getType(), 0);
|
|
|
|
if (PreCond->getOperand(0) != Var)
|
|
|
|
std::swap(Opnd0, Opnd1);
|
|
|
|
|
|
|
|
ICmpInst *NewPreCond =
|
|
|
|
cast<ICmpInst>(Builder.CreateICmp(PreCond->getPredicate(), Opnd0, Opnd1));
|
|
|
|
PreCond->replaceAllUsesWith(NewPreCond);
|
|
|
|
|
2015-02-07 21:37:08 +00:00
|
|
|
RecursivelyDeleteTriviallyDeadInstructions(PreCond, TLI);
|
2012-12-09 03:12:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Step 3: Note that the population count is exactly the trip count of the
|
|
|
|
// loop in question, which enble us to to convert the loop from noncountable
|
|
|
|
// loop into a countable one. The benefit is twofold:
|
|
|
|
//
|
|
|
|
// - If the loop only counts population, the entire loop become dead after
|
|
|
|
// the transformation. It is lots easier to prove a countable loop dead
|
|
|
|
// than to prove a noncountable one. (In some C dialects, a infite loop
|
|
|
|
// isn't dead even if it computes nothing useful. In general, DCE needs
|
|
|
|
// to prove a noncountable loop finite before safely delete it.)
|
|
|
|
//
|
|
|
|
// - If the loop also performs something else, it remains alive.
|
|
|
|
// Since it is transformed to countable form, it can be aggressively
|
|
|
|
// optimized by some optimizations which are in general not applicable
|
|
|
|
// to a noncountable loop.
|
|
|
|
//
|
|
|
|
// After this step, this loop (conceptually) would look like following:
|
|
|
|
// newcnt = __builtin_ctpop(x);
|
|
|
|
// t = newcnt;
|
|
|
|
// if (x)
|
|
|
|
// do { cnt++; x &= x-1; t--) } while (t > 0);
|
|
|
|
BasicBlock *Body = *(CurLoop->block_begin());
|
|
|
|
{
|
|
|
|
BranchInst *LbBr = LIRUtil::getBranch(Body);
|
|
|
|
ICmpInst *LbCond = cast<ICmpInst>(LbBr->getCondition());
|
|
|
|
Type *Ty = TripCnt->getType();
|
|
|
|
|
|
|
|
PHINode *TcPhi = PHINode::Create(Ty, 2, "tcphi", Body->begin());
|
|
|
|
|
|
|
|
Builder.SetInsertPoint(LbCond);
|
|
|
|
Value *Opnd1 = cast<Value>(TcPhi);
|
|
|
|
Value *Opnd2 = cast<Value>(ConstantInt::get(Ty, 1));
|
|
|
|
Instruction *TcDec =
|
|
|
|
cast<Instruction>(Builder.CreateSub(Opnd1, Opnd2, "tcdec", false, true));
|
|
|
|
|
|
|
|
TcPhi->addIncoming(TripCnt, PreHead);
|
|
|
|
TcPhi->addIncoming(TcDec, Body);
|
|
|
|
|
|
|
|
CmpInst::Predicate Pred = (LbBr->getSuccessor(0) == Body) ?
|
|
|
|
CmpInst::ICMP_UGT : CmpInst::ICMP_SLE;
|
|
|
|
LbCond->setPredicate(Pred);
|
|
|
|
LbCond->setOperand(0, TcDec);
|
|
|
|
LbCond->setOperand(1, cast<Value>(ConstantInt::get(Ty, 0)));
|
|
|
|
}
|
|
|
|
|
|
|
|
// Step 4: All the references to the original population counter outside
|
|
|
|
// the loop are replaced with the NewCount -- the value returned from
|
|
|
|
// __builtin_ctpop().
|
2015-02-07 21:37:08 +00:00
|
|
|
CntInst->replaceUsesOutsideBlock(NewCount, Body);
|
2012-12-09 03:12:46 +00:00
|
|
|
|
|
|
|
// step 5: Forget the "non-computable" trip-count SCEV associated with the
|
|
|
|
// loop. The loop would otherwise not be deleted even if it becomes empty.
|
|
|
|
SE->forgetLoop(CurLoop);
|
|
|
|
}
|
|
|
|
|
2013-07-22 18:59:58 +00:00
|
|
|
CallInst *NclPopcountRecognize::createPopcntIntrinsic(IRBuilderTy &IRBuilder,
|
2012-12-09 03:12:46 +00:00
|
|
|
Value *Val, DebugLoc DL) {
|
|
|
|
Value *Ops[] = { Val };
|
|
|
|
Type *Tys[] = { Val->getType() };
|
|
|
|
|
|
|
|
Module *M = (*(CurLoop->block_begin()))->getParent()->getParent();
|
|
|
|
Value *Func = Intrinsic::getDeclaration(M, Intrinsic::ctpop, Tys);
|
|
|
|
CallInst *CI = IRBuilder.CreateCall(Func, Ops);
|
|
|
|
CI->setDebugLoc(DL);
|
|
|
|
|
|
|
|
return CI;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// recognize - detect population count idiom in a non-countable loop. If
|
|
|
|
/// detected, transform the relevant code to popcount intrinsic function
|
|
|
|
/// call, and return true; otherwise, return false.
|
|
|
|
bool NclPopcountRecognize::recognize() {
|
|
|
|
|
2013-01-05 10:00:09 +00:00
|
|
|
if (!LIR.getTargetTransformInfo())
|
2012-12-09 03:12:46 +00:00
|
|
|
return false;
|
|
|
|
|
|
|
|
LIR.getScalarEvolution();
|
|
|
|
|
|
|
|
if (!preliminaryScreen())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
Instruction *CntInst;
|
|
|
|
PHINode *CntPhi;
|
|
|
|
Value *Val;
|
|
|
|
if (!detectIdiom(CntInst, CntPhi, Val))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
transform(CntInst, CntPhi, Val);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// Implementation of LoopIdiomRecognize
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
bool LoopIdiomRecognize::runOnCountableLoop() {
|
|
|
|
const SCEV *BECount = SE->getBackedgeTakenCount(CurLoop);
|
2010-12-26 20:45:45 +00:00
|
|
|
if (isa<SCEVCouldNotCompute>(BECount)) return false;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-02 20:24:21 +00:00
|
|
|
// If this loop executes exactly one time, then it should be peeled, not
|
|
|
|
// optimized by this pass.
|
|
|
|
if (const SCEVConstant *BECst = dyn_cast<SCEVConstant>(BECount))
|
|
|
|
if (BECst->getValue()->getValue() == 0)
|
|
|
|
return false;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2010-12-26 20:45:45 +00:00
|
|
|
// We require target data for now.
|
2012-12-09 03:12:46 +00:00
|
|
|
if (!getDataLayout())
|
|
|
|
return false;
|
|
|
|
|
2013-07-22 18:59:58 +00:00
|
|
|
// set DT
|
2013-01-02 18:26:31 +00:00
|
|
|
(void)getDominatorTree();
|
2011-01-02 19:01:03 +00:00
|
|
|
|
2015-01-17 14:16:18 +00:00
|
|
|
LoopInfo &LI = getAnalysis<LoopInfoWrapperPass>().getLoopInfo();
|
2015-01-15 10:41:28 +00:00
|
|
|
TLI = &getAnalysis<TargetLibraryInfoWrapperPass>().getTLI();
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2013-07-22 18:59:58 +00:00
|
|
|
// set TLI
|
2013-01-02 18:26:31 +00:00
|
|
|
(void)getTargetLibraryInfo();
|
2012-12-09 03:12:46 +00:00
|
|
|
|
2011-01-02 19:01:03 +00:00
|
|
|
SmallVector<BasicBlock*, 8> ExitBlocks;
|
|
|
|
CurLoop->getUniqueExitBlocks(ExitBlocks);
|
|
|
|
|
2011-01-02 21:14:18 +00:00
|
|
|
DEBUG(dbgs() << "loop-idiom Scanning: F["
|
2012-12-09 03:12:46 +00:00
|
|
|
<< CurLoop->getHeader()->getParent()->getName()
|
|
|
|
<< "] Loop %" << CurLoop->getHeader()->getName() << "\n");
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-02 19:01:03 +00:00
|
|
|
bool MadeChange = false;
|
|
|
|
// Scan all the blocks in the loop that are not in subloops.
|
2012-12-09 03:12:46 +00:00
|
|
|
for (Loop::block_iterator BI = CurLoop->block_begin(),
|
|
|
|
E = CurLoop->block_end(); BI != E; ++BI) {
|
2011-01-02 19:01:03 +00:00
|
|
|
// Ignore blocks in subloops.
|
|
|
|
if (LI.getLoopFor(*BI) != CurLoop)
|
|
|
|
continue;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-02 19:01:03 +00:00
|
|
|
MadeChange |= runOnLoopBlock(*BI, BECount, ExitBlocks);
|
|
|
|
}
|
|
|
|
return MadeChange;
|
|
|
|
}
|
2010-12-26 19:39:38 +00:00
|
|
|
|
2012-12-09 03:12:46 +00:00
|
|
|
bool LoopIdiomRecognize::runOnNoncountableLoop() {
|
|
|
|
NclPopcountRecognize Popcount(*this);
|
|
|
|
if (Popcount.recognize())
|
|
|
|
return true;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool LoopIdiomRecognize::runOnLoop(Loop *L, LPPassManager &LPM) {
|
2014-02-06 00:07:05 +00:00
|
|
|
if (skipOptnoneFunction(L))
|
|
|
|
return false;
|
|
|
|
|
2012-12-09 03:12:46 +00:00
|
|
|
CurLoop = L;
|
|
|
|
|
|
|
|
// If the loop could not be converted to canonical form, it must have an
|
|
|
|
// indirectbr in it, just give up.
|
|
|
|
if (!L->getLoopPreheader())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// Disable loop idiom recognition if the function's name is a common idiom.
|
|
|
|
StringRef Name = L->getHeader()->getParent()->getName();
|
|
|
|
if (Name == "memset" || Name == "memcpy")
|
|
|
|
return false;
|
|
|
|
|
|
|
|
SE = &getAnalysis<ScalarEvolution>();
|
|
|
|
if (SE->hasLoopInvariantBackedgeTakenCount(L))
|
|
|
|
return runOnCountableLoop();
|
|
|
|
return runOnNoncountableLoop();
|
|
|
|
}
|
|
|
|
|
2011-01-02 19:01:03 +00:00
|
|
|
/// runOnLoopBlock - Process the specified block, which lives in a counted loop
|
|
|
|
/// with the specified backedge count. This block is known to be in the current
|
|
|
|
/// loop and not in any subloops.
|
|
|
|
bool LoopIdiomRecognize::runOnLoopBlock(BasicBlock *BB, const SCEV *BECount,
|
|
|
|
SmallVectorImpl<BasicBlock*> &ExitBlocks) {
|
|
|
|
// We can only promote stores in this block if they are unconditionally
|
|
|
|
// executed in the loop. For a block to be unconditionally executed, it has
|
|
|
|
// to dominate all the exit blocks of the loop. Verify this now.
|
|
|
|
for (unsigned i = 0, e = ExitBlocks.size(); i != e; ++i)
|
|
|
|
if (!DT->dominates(BB, ExitBlocks[i]))
|
|
|
|
return false;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2010-12-26 20:45:45 +00:00
|
|
|
bool MadeChange = false;
|
|
|
|
for (BasicBlock::iterator I = BB->begin(), E = BB->end(); I != E; ) {
|
2011-01-04 07:27:30 +00:00
|
|
|
Instruction *Inst = I++;
|
|
|
|
// Look for store instructions, which may be optimized to memset/memcpy.
|
|
|
|
if (StoreInst *SI = dyn_cast<StoreInst>(Inst)) {
|
|
|
|
WeakVH InstPtr(I);
|
|
|
|
if (!processLoopStore(SI, BECount)) continue;
|
|
|
|
MadeChange = true;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-04 07:27:30 +00:00
|
|
|
// If processing the store invalidated our iterator, start over from the
|
2011-01-04 07:46:33 +00:00
|
|
|
// top of the block.
|
2014-04-25 05:29:35 +00:00
|
|
|
if (!InstPtr)
|
2011-01-04 07:27:30 +00:00
|
|
|
I = BB->begin();
|
|
|
|
continue;
|
|
|
|
}
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-04 07:46:33 +00:00
|
|
|
// Look for memset instructions, which may be optimized to a larger memset.
|
|
|
|
if (MemSetInst *MSI = dyn_cast<MemSetInst>(Inst)) {
|
|
|
|
WeakVH InstPtr(I);
|
|
|
|
if (!processLoopMemSet(MSI, BECount)) continue;
|
|
|
|
MadeChange = true;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-04 07:46:33 +00:00
|
|
|
// If processing the memset invalidated our iterator, start over from the
|
|
|
|
// top of the block.
|
2014-04-25 05:29:35 +00:00
|
|
|
if (!InstPtr)
|
2011-01-04 07:46:33 +00:00
|
|
|
I = BB->begin();
|
|
|
|
continue;
|
|
|
|
}
|
2010-12-26 20:45:45 +00:00
|
|
|
}
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2010-12-26 20:45:45 +00:00
|
|
|
return MadeChange;
|
2010-12-26 19:39:38 +00:00
|
|
|
}
|
|
|
|
|
2011-01-02 19:01:03 +00:00
|
|
|
|
2011-01-04 07:46:33 +00:00
|
|
|
/// processLoopStore - See if this store can be promoted to a memset or memcpy.
|
2010-12-26 20:45:45 +00:00
|
|
|
bool LoopIdiomRecognize::processLoopStore(StoreInst *SI, const SCEV *BECount) {
|
2011-09-12 20:23:13 +00:00
|
|
|
if (!SI->isSimple()) return false;
|
2011-01-04 07:46:33 +00:00
|
|
|
|
2010-12-26 20:45:45 +00:00
|
|
|
Value *StoredVal = SI->getValueOperand();
|
implement enough of the memset inference algorithm to recognize and insert
memsets. This is still missing one important validity check, but this is enough
to compile stuff like this:
void test0(std::vector<char> &X) {
for (std::vector<char>::iterator I = X.begin(), E = X.end(); I != E; ++I)
*I = 0;
}
void test1(std::vector<int> &X) {
for (long i = 0, e = X.size(); i != e; ++i)
X[i] = 0x01010101;
}
With:
$ clang t.cpp -S -o - -O2 -emit-llvm | opt -loop-idiom | opt -O3 | llc
to:
__Z5test0RSt6vectorIcSaIcEE: ## @_Z5test0RSt6vectorIcSaIcEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rsi
cmpq %rsi, %rax
je LBB0_2
## BB#1: ## %bb.nph
subq %rax, %rsi
movq %rax, %rdi
callq ___bzero
LBB0_2: ## %for.end
addq $8, %rsp
ret
...
__Z5test1RSt6vectorIiSaIiEE: ## @_Z5test1RSt6vectorIiSaIiEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rdx
subq %rax, %rdx
cmpq $4, %rdx
jb LBB1_2
## BB#1: ## %for.body.preheader
andq $-4, %rdx
movl $1, %esi
movq %rax, %rdi
callq _memset
LBB1_2: ## %for.end
addq $8, %rsp
ret
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122573 91177308-0d34-0410-b5e6-96231b3b80d8
2010-12-26 23:42:51 +00:00
|
|
|
Value *StorePtr = SI->getPointerOperand();
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2010-12-28 18:53:48 +00:00
|
|
|
// Reject stores that are so large that they overflow an unsigned.
|
2014-02-21 00:06:31 +00:00
|
|
|
uint64_t SizeInBits = DL->getTypeSizeInBits(StoredVal->getType());
|
2010-12-28 18:53:48 +00:00
|
|
|
if ((SizeInBits & 7) || (SizeInBits >> 32) != 0)
|
2010-12-26 20:45:45 +00:00
|
|
|
return false;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2010-12-26 20:45:45 +00:00
|
|
|
// See if the pointer expression is an AddRec like {base,+,1} on the current
|
|
|
|
// loop, which indicates a strided store. If we have something else, it's a
|
|
|
|
// random store we can't handle.
|
2011-01-02 03:37:56 +00:00
|
|
|
const SCEVAddRecExpr *StoreEv =
|
|
|
|
dyn_cast<SCEVAddRecExpr>(SE->getSCEV(StorePtr));
|
2014-04-25 05:29:35 +00:00
|
|
|
if (!StoreEv || StoreEv->getLoop() != CurLoop || !StoreEv->isAffine())
|
2010-12-26 20:45:45 +00:00
|
|
|
return false;
|
|
|
|
|
|
|
|
// Check to see if the stride matches the size of the store. If so, then we
|
|
|
|
// know that every byte is touched in the loop.
|
2011-03-14 16:48:10 +00:00
|
|
|
unsigned StoreSize = (unsigned)SizeInBits >> 3;
|
2011-01-02 03:37:56 +00:00
|
|
|
const SCEVConstant *Stride = dyn_cast<SCEVConstant>(StoreEv->getOperand(1));
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2014-04-25 05:29:35 +00:00
|
|
|
if (!Stride || StoreSize != Stride->getValue()->getValue()) {
|
2011-02-21 02:08:54 +00:00
|
|
|
// TODO: Could also handle negative stride here someday, that will require
|
|
|
|
// the validity check in mayLoopAccessLocation to be updated though.
|
|
|
|
// Enable this to print exact negative strides.
|
2011-02-21 17:02:55 +00:00
|
|
|
if (0 && Stride && StoreSize == -Stride->getValue()->getValue()) {
|
2011-02-21 02:08:54 +00:00
|
|
|
dbgs() << "NEGATIVE STRIDE: " << *SI << "\n";
|
|
|
|
dbgs() << "BB: " << *SI->getParent();
|
|
|
|
}
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2010-12-26 20:45:45 +00:00
|
|
|
return false;
|
2011-02-21 02:08:54 +00:00
|
|
|
}
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
|
|
|
|
// See if we can optimize just this store in isolation.
|
|
|
|
if (processLoopStridedStore(StorePtr, StoreSize, SI->getAlignment(),
|
|
|
|
StoredVal, SI, StoreEv, BECount))
|
|
|
|
return true;
|
implement enough of the memset inference algorithm to recognize and insert
memsets. This is still missing one important validity check, but this is enough
to compile stuff like this:
void test0(std::vector<char> &X) {
for (std::vector<char>::iterator I = X.begin(), E = X.end(); I != E; ++I)
*I = 0;
}
void test1(std::vector<int> &X) {
for (long i = 0, e = X.size(); i != e; ++i)
X[i] = 0x01010101;
}
With:
$ clang t.cpp -S -o - -O2 -emit-llvm | opt -loop-idiom | opt -O3 | llc
to:
__Z5test0RSt6vectorIcSaIcEE: ## @_Z5test0RSt6vectorIcSaIcEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rsi
cmpq %rsi, %rax
je LBB0_2
## BB#1: ## %bb.nph
subq %rax, %rsi
movq %rax, %rdi
callq ___bzero
LBB0_2: ## %for.end
addq $8, %rsp
ret
...
__Z5test1RSt6vectorIiSaIiEE: ## @_Z5test1RSt6vectorIiSaIiEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rdx
subq %rax, %rdx
cmpq $4, %rdx
jb LBB1_2
## BB#1: ## %for.body.preheader
andq $-4, %rdx
movl $1, %esi
movq %rax, %rdi
callq _memset
LBB1_2: ## %for.end
addq $8, %rsp
ret
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122573 91177308-0d34-0410-b5e6-96231b3b80d8
2010-12-26 23:42:51 +00:00
|
|
|
|
2011-01-02 03:37:56 +00:00
|
|
|
// If the stored value is a strided load in the same loop with the same stride
|
|
|
|
// this this may be transformable into a memcpy. This kicks in for stuff like
|
|
|
|
// for (i) A[i] = B[i];
|
|
|
|
if (LoadInst *LI = dyn_cast<LoadInst>(StoredVal)) {
|
|
|
|
const SCEVAddRecExpr *LoadEv =
|
|
|
|
dyn_cast<SCEVAddRecExpr>(SE->getSCEV(LI->getOperand(0)));
|
|
|
|
if (LoadEv && LoadEv->getLoop() == CurLoop && LoadEv->isAffine() &&
|
2011-09-12 20:23:13 +00:00
|
|
|
StoreEv->getOperand(1) == LoadEv->getOperand(1) && LI->isSimple())
|
2011-01-02 03:37:56 +00:00
|
|
|
if (processLoopStoreOfLoopLoad(SI, StoreSize, StoreEv, LoadEv, BECount))
|
|
|
|
return true;
|
|
|
|
}
|
2011-01-02 07:36:44 +00:00
|
|
|
//errs() << "UNHANDLED strided store: " << *StoreEv << " - " << *SI << "\n";
|
2010-12-26 20:45:45 +00:00
|
|
|
|
2010-12-26 19:39:38 +00:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2011-01-04 07:46:33 +00:00
|
|
|
/// processLoopMemSet - See if this memset can be promoted to a large memset.
|
|
|
|
bool LoopIdiomRecognize::
|
|
|
|
processLoopMemSet(MemSetInst *MSI, const SCEV *BECount) {
|
|
|
|
// We can only handle non-volatile memsets with a constant size.
|
|
|
|
if (MSI->isVolatile() || !isa<ConstantInt>(MSI->getLength())) return false;
|
|
|
|
|
2011-02-18 22:22:15 +00:00
|
|
|
// If we're not allowed to hack on memset, we fail.
|
|
|
|
if (!TLI->has(LibFunc::memset))
|
|
|
|
return false;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-04 07:46:33 +00:00
|
|
|
Value *Pointer = MSI->getDest();
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-04 07:46:33 +00:00
|
|
|
// See if the pointer expression is an AddRec like {base,+,1} on the current
|
|
|
|
// loop, which indicates a strided store. If we have something else, it's a
|
|
|
|
// random store we can't handle.
|
|
|
|
const SCEVAddRecExpr *Ev = dyn_cast<SCEVAddRecExpr>(SE->getSCEV(Pointer));
|
2014-04-25 05:29:35 +00:00
|
|
|
if (!Ev || Ev->getLoop() != CurLoop || !Ev->isAffine())
|
2011-01-04 07:46:33 +00:00
|
|
|
return false;
|
|
|
|
|
|
|
|
// Reject memsets that are so large that they overflow an unsigned.
|
|
|
|
uint64_t SizeInBytes = cast<ConstantInt>(MSI->getLength())->getZExtValue();
|
|
|
|
if ((SizeInBytes >> 32) != 0)
|
|
|
|
return false;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-04 07:46:33 +00:00
|
|
|
// Check to see if the stride matches the size of the memset. If so, then we
|
|
|
|
// know that every byte is touched in the loop.
|
|
|
|
const SCEVConstant *Stride = dyn_cast<SCEVConstant>(Ev->getOperand(1));
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-04 07:46:33 +00:00
|
|
|
// TODO: Could also handle negative stride here someday, that will require the
|
|
|
|
// validity check in mayLoopAccessLocation to be updated though.
|
2014-04-25 05:29:35 +00:00
|
|
|
if (!Stride || MSI->getLength() != Stride->getValue())
|
2011-01-04 07:46:33 +00:00
|
|
|
return false;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
return processLoopStridedStore(Pointer, (unsigned)SizeInBytes,
|
|
|
|
MSI->getAlignment(), MSI->getValue(),
|
|
|
|
MSI, Ev, BECount);
|
2011-01-04 07:46:33 +00:00
|
|
|
}
|
|
|
|
|
2012-11-02 08:33:25 +00:00
|
|
|
|
|
|
|
/// mayLoopAccessLocation - Return true if the specified loop might access the
|
|
|
|
/// specified pointer location, which is a loop-strided access. The 'Access'
|
|
|
|
/// argument specifies what the verboten forms of access are (read or write).
|
|
|
|
static bool mayLoopAccessLocation(Value *Ptr,AliasAnalysis::ModRefResult Access,
|
|
|
|
Loop *L, const SCEV *BECount,
|
|
|
|
unsigned StoreSize, AliasAnalysis &AA,
|
|
|
|
Instruction *IgnoredStore) {
|
|
|
|
// Get the location that may be stored across the loop. Since the access is
|
|
|
|
// strided positively through memory, we say that the modified location starts
|
|
|
|
// at the pointer and has infinite size.
|
|
|
|
uint64_t AccessSize = AliasAnalysis::UnknownSize;
|
|
|
|
|
|
|
|
// If the loop iterates a fixed number of times, we can refine the access size
|
|
|
|
// to be exactly the size of the memset, which is (BECount+1)*StoreSize
|
|
|
|
if (const SCEVConstant *BECst = dyn_cast<SCEVConstant>(BECount))
|
|
|
|
AccessSize = (BECst->getValue()->getZExtValue()+1)*StoreSize;
|
|
|
|
|
|
|
|
// TODO: For this to be really effective, we have to dive into the pointer
|
|
|
|
// operand in the store. Store to &A[i] of 100 will always return may alias
|
|
|
|
// with store of &A[100], we need to StoreLoc to be "A" with size of 100,
|
|
|
|
// which will then no-alias a store to &A[100].
|
|
|
|
AliasAnalysis::Location StoreLoc(Ptr, AccessSize);
|
|
|
|
|
|
|
|
for (Loop::block_iterator BI = L->block_begin(), E = L->block_end(); BI != E;
|
|
|
|
++BI)
|
|
|
|
for (BasicBlock::iterator I = (*BI)->begin(), E = (*BI)->end(); I != E; ++I)
|
|
|
|
if (&*I != IgnoredStore &&
|
|
|
|
(AA.getModRefInfo(I, StoreLoc) & Access))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
/// getMemSetPatternValue - If a strided store of the specified value is safe to
|
|
|
|
/// turn into a memset_pattern16, return a ConstantArray of 16 bytes that should
|
|
|
|
/// be passed in. Otherwise, return null.
|
|
|
|
///
|
|
|
|
/// Note that we don't ever attempt to use memset_pattern8 or 4, because these
|
|
|
|
/// just replicate their input array and then pass on to memset_pattern16.
|
2014-02-21 00:06:31 +00:00
|
|
|
static Constant *getMemSetPatternValue(Value *V, const DataLayout &DL) {
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
// If the value isn't a constant, we can't promote it to being in a constant
|
|
|
|
// array. We could theoretically do a store to an alloca or something, but
|
|
|
|
// that doesn't seem worthwhile.
|
|
|
|
Constant *C = dyn_cast<Constant>(V);
|
2014-04-25 05:29:35 +00:00
|
|
|
if (!C) return nullptr;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
// Only handle simple values that are a power of two bytes in size.
|
2014-02-21 00:06:31 +00:00
|
|
|
uint64_t Size = DL.getTypeSizeInBits(V->getType());
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
if (Size == 0 || (Size & 7) || (Size & (Size-1)))
|
2014-04-25 05:29:35 +00:00
|
|
|
return nullptr;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
rewrite the memset_pattern pattern generation stuff to accept any 2/4/8/16-byte
constant, including globals. This makes us generate much more "pretty" pattern
globals as well because it doesn't break it down to an array of bytes all the
time.
This enables us to handle stores of relocatable globals. This kicks in about
48 times in 254.gap, giving us stuff like this:
@.memset_pattern40 = internal constant [2 x %struct.TypHeader* (%struct.TypHeader*, %struct.TypHeader*)*] [%struct.TypHeader* (%struct.TypHeader*, %struct
.TypHeader*)* @IsFalse, %struct.TypHeader* (%struct.TypHeader*, %struct.TypHeader*)* @IsFalse], align 16
...
call void @memset_pattern16(i8* %scevgep5859, i8* bitcast ([2 x %struct.TypHeader* (%struct.TypHeader*, %struct.TypHeader*)*]* @.memset_pattern40 to i8*
), i64 %tmp75) nounwind
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126044 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:56:44 +00:00
|
|
|
// Don't care enough about darwin/ppc to implement this.
|
2014-02-21 00:06:31 +00:00
|
|
|
if (DL.isBigEndian())
|
2014-04-25 05:29:35 +00:00
|
|
|
return nullptr;
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
|
|
|
|
// Convert to size in bytes.
|
|
|
|
Size /= 8;
|
2011-02-18 22:22:15 +00:00
|
|
|
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
// TODO: If CI is larger than 16-bytes, we can try slicing it in half to see
|
rewrite the memset_pattern pattern generation stuff to accept any 2/4/8/16-byte
constant, including globals. This makes us generate much more "pretty" pattern
globals as well because it doesn't break it down to an array of bytes all the
time.
This enables us to handle stores of relocatable globals. This kicks in about
48 times in 254.gap, giving us stuff like this:
@.memset_pattern40 = internal constant [2 x %struct.TypHeader* (%struct.TypHeader*, %struct.TypHeader*)*] [%struct.TypHeader* (%struct.TypHeader*, %struct
.TypHeader*)* @IsFalse, %struct.TypHeader* (%struct.TypHeader*, %struct.TypHeader*)* @IsFalse], align 16
...
call void @memset_pattern16(i8* %scevgep5859, i8* bitcast ([2 x %struct.TypHeader* (%struct.TypHeader*, %struct.TypHeader*)*]* @.memset_pattern40 to i8*
), i64 %tmp75) nounwind
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126044 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:56:44 +00:00
|
|
|
// if the top and bottom are the same (e.g. for vectors and large integers).
|
2014-04-25 05:29:35 +00:00
|
|
|
if (Size > 16) return nullptr;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
rewrite the memset_pattern pattern generation stuff to accept any 2/4/8/16-byte
constant, including globals. This makes us generate much more "pretty" pattern
globals as well because it doesn't break it down to an array of bytes all the
time.
This enables us to handle stores of relocatable globals. This kicks in about
48 times in 254.gap, giving us stuff like this:
@.memset_pattern40 = internal constant [2 x %struct.TypHeader* (%struct.TypHeader*, %struct.TypHeader*)*] [%struct.TypHeader* (%struct.TypHeader*, %struct
.TypHeader*)* @IsFalse, %struct.TypHeader* (%struct.TypHeader*, %struct.TypHeader*)* @IsFalse], align 16
...
call void @memset_pattern16(i8* %scevgep5859, i8* bitcast ([2 x %struct.TypHeader* (%struct.TypHeader*, %struct.TypHeader*)*]* @.memset_pattern40 to i8*
), i64 %tmp75) nounwind
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126044 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:56:44 +00:00
|
|
|
// If the constant is exactly 16 bytes, just use it.
|
|
|
|
if (Size == 16) return C;
|
|
|
|
|
|
|
|
// Otherwise, we'll use an array of the constants.
|
|
|
|
unsigned ArraySize = 16/Size;
|
|
|
|
ArrayType *AT = ArrayType::get(V->getType(), ArraySize);
|
|
|
|
return ConstantArray::get(AT, std::vector<Constant*>(ArraySize, C));
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/// processLoopStridedStore - We see a strided store of some value. If we can
|
|
|
|
/// transform this into a memset or memset_pattern in the loop preheader, do so.
|
|
|
|
bool LoopIdiomRecognize::
|
|
|
|
processLoopStridedStore(Value *DestPtr, unsigned StoreSize,
|
|
|
|
unsigned StoreAlignment, Value *StoredVal,
|
|
|
|
Instruction *TheStore, const SCEVAddRecExpr *Ev,
|
|
|
|
const SCEV *BECount) {
|
2011-03-14 16:48:10 +00:00
|
|
|
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
// If the stored value is a byte-wise value (like i32 -1), then it may be
|
|
|
|
// turned into a memset of i8 -1, assuming that all the consecutive bytes
|
|
|
|
// are stored. A store of i32 0x01020304 can never be turned into a memset,
|
|
|
|
// but it can be turned into memset_pattern if the target supports it.
|
|
|
|
Value *SplatValue = isBytewiseValue(StoredVal);
|
2014-04-25 05:29:35 +00:00
|
|
|
Constant *PatternValue = nullptr;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2013-09-11 05:09:42 +00:00
|
|
|
unsigned DestAS = DestPtr->getType()->getPointerAddressSpace();
|
|
|
|
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
// If we're allowed to form a memset, and the stored value would be acceptable
|
|
|
|
// for memset, use it.
|
|
|
|
if (SplatValue && TLI->has(LibFunc::memset) &&
|
|
|
|
// Verify that the stored value is loop invariant. If not, we can't
|
|
|
|
// promote the memset.
|
|
|
|
CurLoop->isLoopInvariant(SplatValue)) {
|
|
|
|
// Keep and use SplatValue.
|
2014-04-25 05:29:35 +00:00
|
|
|
PatternValue = nullptr;
|
2013-09-11 05:09:42 +00:00
|
|
|
} else if (DestAS == 0 &&
|
|
|
|
TLI->has(LibFunc::memset_pattern16) &&
|
2014-02-21 00:06:31 +00:00
|
|
|
(PatternValue = getMemSetPatternValue(StoredVal, *DL))) {
|
2013-09-11 05:09:42 +00:00
|
|
|
// Don't create memset_pattern16s with address spaces.
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
// It looks like we can use PatternValue!
|
2014-04-25 05:29:35 +00:00
|
|
|
SplatValue = nullptr;
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
} else {
|
|
|
|
// Otherwise, this isn't an idiom we can transform. For example, we can't
|
2011-09-13 00:44:16 +00:00
|
|
|
// do anything with a 3-byte store.
|
2011-01-01 20:12:04 +00:00
|
|
|
return false;
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
}
|
2011-03-14 16:48:10 +00:00
|
|
|
|
implement enough of the memset inference algorithm to recognize and insert
memsets. This is still missing one important validity check, but this is enough
to compile stuff like this:
void test0(std::vector<char> &X) {
for (std::vector<char>::iterator I = X.begin(), E = X.end(); I != E; ++I)
*I = 0;
}
void test1(std::vector<int> &X) {
for (long i = 0, e = X.size(); i != e; ++i)
X[i] = 0x01010101;
}
With:
$ clang t.cpp -S -o - -O2 -emit-llvm | opt -loop-idiom | opt -O3 | llc
to:
__Z5test0RSt6vectorIcSaIcEE: ## @_Z5test0RSt6vectorIcSaIcEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rsi
cmpq %rsi, %rax
je LBB0_2
## BB#1: ## %bb.nph
subq %rax, %rsi
movq %rax, %rdi
callq ___bzero
LBB0_2: ## %for.end
addq $8, %rsp
ret
...
__Z5test1RSt6vectorIiSaIiEE: ## @_Z5test1RSt6vectorIiSaIiEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rdx
subq %rax, %rdx
cmpq $4, %rdx
jb LBB1_2
## BB#1: ## %for.body.preheader
andq $-4, %rdx
movl $1, %esi
movq %rax, %rdi
callq _memset
LBB1_2: ## %for.end
addq $8, %rsp
ret
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122573 91177308-0d34-0410-b5e6-96231b3b80d8
2010-12-26 23:42:51 +00:00
|
|
|
// The trip count of the loop and the base pointer of the addrec SCEV is
|
|
|
|
// guaranteed to be loop invariant, which means that it should dominate the
|
2011-05-22 17:39:56 +00:00
|
|
|
// header. This allows us to insert code for it in the preheader.
|
|
|
|
BasicBlock *Preheader = CurLoop->getLoopPreheader();
|
|
|
|
IRBuilder<> Builder(Preheader->getTerminator());
|
2011-06-28 05:07:32 +00:00
|
|
|
SCEVExpander Expander(*SE, "loop-idiom");
|
2011-06-28 05:04:16 +00:00
|
|
|
|
2013-09-11 05:09:42 +00:00
|
|
|
Type *DestInt8PtrTy = Builder.getInt8PtrTy(DestAS);
|
|
|
|
|
2011-05-22 17:39:56 +00:00
|
|
|
// Okay, we have a strided store "p[i]" of a splattable value. We can turn
|
2012-10-21 19:31:16 +00:00
|
|
|
// this into a memset in the loop preheader now if we want. However, this
|
|
|
|
// would be unsafe to do if there is anything else in the loop that may read
|
2012-11-01 08:07:29 +00:00
|
|
|
// or write to the aliased location. Check for any overlap by generating the
|
|
|
|
// base pointer and checking the region.
|
2011-03-14 16:48:10 +00:00
|
|
|
Value *BasePtr =
|
2013-09-11 05:09:42 +00:00
|
|
|
Expander.expandCodeFor(Ev->getStart(), DestInt8PtrTy,
|
implement enough of the memset inference algorithm to recognize and insert
memsets. This is still missing one important validity check, but this is enough
to compile stuff like this:
void test0(std::vector<char> &X) {
for (std::vector<char>::iterator I = X.begin(), E = X.end(); I != E; ++I)
*I = 0;
}
void test1(std::vector<int> &X) {
for (long i = 0, e = X.size(); i != e; ++i)
X[i] = 0x01010101;
}
With:
$ clang t.cpp -S -o - -O2 -emit-llvm | opt -loop-idiom | opt -O3 | llc
to:
__Z5test0RSt6vectorIcSaIcEE: ## @_Z5test0RSt6vectorIcSaIcEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rsi
cmpq %rsi, %rax
je LBB0_2
## BB#1: ## %bb.nph
subq %rax, %rsi
movq %rax, %rdi
callq ___bzero
LBB0_2: ## %for.end
addq $8, %rsp
ret
...
__Z5test1RSt6vectorIiSaIiEE: ## @_Z5test1RSt6vectorIiSaIiEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rdx
subq %rax, %rdx
cmpq $4, %rdx
jb LBB1_2
## BB#1: ## %for.body.preheader
andq $-4, %rdx
movl $1, %esi
movq %rax, %rdi
callq _memset
LBB1_2: ## %for.end
addq $8, %rsp
ret
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122573 91177308-0d34-0410-b5e6-96231b3b80d8
2010-12-26 23:42:51 +00:00
|
|
|
Preheader->getTerminator());
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2012-11-02 08:33:25 +00:00
|
|
|
if (mayLoopAccessLocation(BasePtr, AliasAnalysis::ModRef,
|
|
|
|
CurLoop, BECount,
|
2013-09-11 05:09:35 +00:00
|
|
|
StoreSize, getAnalysis<AliasAnalysis>(), TheStore)) {
|
2012-11-02 08:33:25 +00:00
|
|
|
Expander.clear();
|
|
|
|
// If we generated new code for the base pointer, clean up.
|
2015-02-07 21:37:08 +00:00
|
|
|
RecursivelyDeleteTriviallyDeadInstructions(BasePtr, TLI);
|
2012-11-02 08:33:25 +00:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2011-05-22 17:39:56 +00:00
|
|
|
// Okay, everything looks good, insert the memset.
|
|
|
|
|
implement enough of the memset inference algorithm to recognize and insert
memsets. This is still missing one important validity check, but this is enough
to compile stuff like this:
void test0(std::vector<char> &X) {
for (std::vector<char>::iterator I = X.begin(), E = X.end(); I != E; ++I)
*I = 0;
}
void test1(std::vector<int> &X) {
for (long i = 0, e = X.size(); i != e; ++i)
X[i] = 0x01010101;
}
With:
$ clang t.cpp -S -o - -O2 -emit-llvm | opt -loop-idiom | opt -O3 | llc
to:
__Z5test0RSt6vectorIcSaIcEE: ## @_Z5test0RSt6vectorIcSaIcEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rsi
cmpq %rsi, %rax
je LBB0_2
## BB#1: ## %bb.nph
subq %rax, %rsi
movq %rax, %rdi
callq ___bzero
LBB0_2: ## %for.end
addq $8, %rsp
ret
...
__Z5test1RSt6vectorIiSaIiEE: ## @_Z5test1RSt6vectorIiSaIiEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rdx
subq %rax, %rdx
cmpq $4, %rdx
jb LBB1_2
## BB#1: ## %for.body.preheader
andq $-4, %rdx
movl $1, %esi
movq %rax, %rdi
callq _memset
LBB1_2: ## %for.end
addq $8, %rsp
ret
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122573 91177308-0d34-0410-b5e6-96231b3b80d8
2010-12-26 23:42:51 +00:00
|
|
|
// The # stored bytes is (BECount+1)*Size. Expand the trip count out to
|
|
|
|
// pointer size if it isn't already.
|
2014-02-21 00:06:31 +00:00
|
|
|
Type *IntPtr = Builder.getIntPtrTy(DL, DestAS);
|
2011-01-04 00:06:55 +00:00
|
|
|
BECount = SE->getTruncateOrZeroExtend(BECount, IntPtr);
|
2011-03-14 16:48:10 +00:00
|
|
|
|
implement enough of the memset inference algorithm to recognize and insert
memsets. This is still missing one important validity check, but this is enough
to compile stuff like this:
void test0(std::vector<char> &X) {
for (std::vector<char>::iterator I = X.begin(), E = X.end(); I != E; ++I)
*I = 0;
}
void test1(std::vector<int> &X) {
for (long i = 0, e = X.size(); i != e; ++i)
X[i] = 0x01010101;
}
With:
$ clang t.cpp -S -o - -O2 -emit-llvm | opt -loop-idiom | opt -O3 | llc
to:
__Z5test0RSt6vectorIcSaIcEE: ## @_Z5test0RSt6vectorIcSaIcEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rsi
cmpq %rsi, %rax
je LBB0_2
## BB#1: ## %bb.nph
subq %rax, %rsi
movq %rax, %rdi
callq ___bzero
LBB0_2: ## %for.end
addq $8, %rsp
ret
...
__Z5test1RSt6vectorIiSaIiEE: ## @_Z5test1RSt6vectorIiSaIiEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rdx
subq %rax, %rdx
cmpq $4, %rdx
jb LBB1_2
## BB#1: ## %for.body.preheader
andq $-4, %rdx
movl $1, %esi
movq %rax, %rdi
callq _memset
LBB1_2: ## %for.end
addq $8, %rsp
ret
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122573 91177308-0d34-0410-b5e6-96231b3b80d8
2010-12-26 23:42:51 +00:00
|
|
|
const SCEV *NumBytesS = SE->getAddExpr(BECount, SE->getConstant(IntPtr, 1),
|
2011-03-14 16:50:06 +00:00
|
|
|
SCEV::FlagNUW);
|
2013-09-11 05:09:35 +00:00
|
|
|
if (StoreSize != 1) {
|
implement enough of the memset inference algorithm to recognize and insert
memsets. This is still missing one important validity check, but this is enough
to compile stuff like this:
void test0(std::vector<char> &X) {
for (std::vector<char>::iterator I = X.begin(), E = X.end(); I != E; ++I)
*I = 0;
}
void test1(std::vector<int> &X) {
for (long i = 0, e = X.size(); i != e; ++i)
X[i] = 0x01010101;
}
With:
$ clang t.cpp -S -o - -O2 -emit-llvm | opt -loop-idiom | opt -O3 | llc
to:
__Z5test0RSt6vectorIcSaIcEE: ## @_Z5test0RSt6vectorIcSaIcEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rsi
cmpq %rsi, %rax
je LBB0_2
## BB#1: ## %bb.nph
subq %rax, %rsi
movq %rax, %rdi
callq ___bzero
LBB0_2: ## %for.end
addq $8, %rsp
ret
...
__Z5test1RSt6vectorIiSaIiEE: ## @_Z5test1RSt6vectorIiSaIiEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rdx
subq %rax, %rdx
cmpq $4, %rdx
jb LBB1_2
## BB#1: ## %for.body.preheader
andq $-4, %rdx
movl $1, %esi
movq %rax, %rdi
callq _memset
LBB1_2: ## %for.end
addq $8, %rsp
ret
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122573 91177308-0d34-0410-b5e6-96231b3b80d8
2010-12-26 23:42:51 +00:00
|
|
|
NumBytesS = SE->getMulExpr(NumBytesS, SE->getConstant(IntPtr, StoreSize),
|
2011-03-14 16:50:06 +00:00
|
|
|
SCEV::FlagNUW);
|
2013-09-11 05:09:35 +00:00
|
|
|
}
|
2011-03-14 16:48:10 +00:00
|
|
|
|
|
|
|
Value *NumBytes =
|
implement enough of the memset inference algorithm to recognize and insert
memsets. This is still missing one important validity check, but this is enough
to compile stuff like this:
void test0(std::vector<char> &X) {
for (std::vector<char>::iterator I = X.begin(), E = X.end(); I != E; ++I)
*I = 0;
}
void test1(std::vector<int> &X) {
for (long i = 0, e = X.size(); i != e; ++i)
X[i] = 0x01010101;
}
With:
$ clang t.cpp -S -o - -O2 -emit-llvm | opt -loop-idiom | opt -O3 | llc
to:
__Z5test0RSt6vectorIcSaIcEE: ## @_Z5test0RSt6vectorIcSaIcEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rsi
cmpq %rsi, %rax
je LBB0_2
## BB#1: ## %bb.nph
subq %rax, %rsi
movq %rax, %rdi
callq ___bzero
LBB0_2: ## %for.end
addq $8, %rsp
ret
...
__Z5test1RSt6vectorIiSaIiEE: ## @_Z5test1RSt6vectorIiSaIiEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rdx
subq %rax, %rdx
cmpq $4, %rdx
jb LBB1_2
## BB#1: ## %for.body.preheader
andq $-4, %rdx
movl $1, %esi
movq %rax, %rdi
callq _memset
LBB1_2: ## %for.end
addq $8, %rsp
ret
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122573 91177308-0d34-0410-b5e6-96231b3b80d8
2010-12-26 23:42:51 +00:00
|
|
|
Expander.expandCodeFor(NumBytesS, IntPtr, Preheader->getTerminator());
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-03-07 22:43:45 +00:00
|
|
|
CallInst *NewCall;
|
2013-09-11 05:09:35 +00:00
|
|
|
if (SplatValue) {
|
|
|
|
NewCall = Builder.CreateMemSet(BasePtr,
|
|
|
|
SplatValue,
|
|
|
|
NumBytes,
|
|
|
|
StoreAlignment);
|
|
|
|
} else {
|
2013-09-11 05:09:42 +00:00
|
|
|
// Everything is emitted in default address space
|
|
|
|
Type *Int8PtrTy = DestInt8PtrTy;
|
|
|
|
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
Module *M = TheStore->getParent()->getParent()->getParent();
|
|
|
|
Value *MSP = M->getOrInsertFunction("memset_pattern16",
|
|
|
|
Builder.getVoidTy(),
|
2013-09-11 05:09:42 +00:00
|
|
|
Int8PtrTy,
|
|
|
|
Int8PtrTy,
|
|
|
|
IntPtr,
|
2014-04-25 05:29:35 +00:00
|
|
|
(void*)nullptr);
|
2011-03-14 16:48:10 +00:00
|
|
|
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
// Otherwise we should form a memset_pattern16. PatternValue is known to be
|
|
|
|
// an constant array of 16-bytes. Plop the value into a mergable global.
|
|
|
|
GlobalVariable *GV = new GlobalVariable(*M, PatternValue->getType(), true,
|
|
|
|
GlobalValue::InternalLinkage,
|
|
|
|
PatternValue, ".memset_pattern");
|
|
|
|
GV->setUnnamedAddr(true); // Ok to merge these.
|
|
|
|
GV->setAlignment(16);
|
2013-09-11 05:09:42 +00:00
|
|
|
Value *PatternPtr = ConstantExpr::getBitCast(GV, Int8PtrTy);
|
Implement rdar://9009151, transforming strided loop stores of
unsplatable values into memset_pattern16 when it is available
(recent darwins). This transforms lots of strided loop stores
of ints for example, like 5 in vpr:
Formed memset: call void @memset_pattern16(i8* %4, i8* getelementptr inbounds ([16 x i8]* @.memset_pattern9, i32 0, i32 0), i64 %tmp25)
from store to: {%3,+,4}<%11> at: store i32 3, i32* %scevgep, align 4, !tbaa !4
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126040 91177308-0d34-0410-b5e6-96231b3b80d8
2011-02-19 19:31:39 +00:00
|
|
|
NewCall = Builder.CreateCall3(MSP, BasePtr, PatternPtr, NumBytes);
|
|
|
|
}
|
2011-03-14 16:48:10 +00:00
|
|
|
|
implement enough of the memset inference algorithm to recognize and insert
memsets. This is still missing one important validity check, but this is enough
to compile stuff like this:
void test0(std::vector<char> &X) {
for (std::vector<char>::iterator I = X.begin(), E = X.end(); I != E; ++I)
*I = 0;
}
void test1(std::vector<int> &X) {
for (long i = 0, e = X.size(); i != e; ++i)
X[i] = 0x01010101;
}
With:
$ clang t.cpp -S -o - -O2 -emit-llvm | opt -loop-idiom | opt -O3 | llc
to:
__Z5test0RSt6vectorIcSaIcEE: ## @_Z5test0RSt6vectorIcSaIcEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rsi
cmpq %rsi, %rax
je LBB0_2
## BB#1: ## %bb.nph
subq %rax, %rsi
movq %rax, %rdi
callq ___bzero
LBB0_2: ## %for.end
addq $8, %rsp
ret
...
__Z5test1RSt6vectorIiSaIiEE: ## @_Z5test1RSt6vectorIiSaIiEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rdx
subq %rax, %rdx
cmpq $4, %rdx
jb LBB1_2
## BB#1: ## %for.body.preheader
andq $-4, %rdx
movl $1, %esi
movq %rax, %rdi
callq _memset
LBB1_2: ## %for.end
addq $8, %rsp
ret
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122573 91177308-0d34-0410-b5e6-96231b3b80d8
2010-12-26 23:42:51 +00:00
|
|
|
DEBUG(dbgs() << " Formed memset: " << *NewCall << "\n"
|
2011-01-04 07:46:33 +00:00
|
|
|
<< " from store to: " << *Ev << " at: " << *TheStore << "\n");
|
2011-03-07 22:43:45 +00:00
|
|
|
NewCall->setDebugLoc(TheStore->getDebugLoc());
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2010-12-27 00:03:23 +00:00
|
|
|
// Okay, the memset has been formed. Zap the original store and anything that
|
|
|
|
// feeds into it.
|
2015-02-07 21:37:08 +00:00
|
|
|
deleteDeadInstruction(TheStore, TLI);
|
2011-01-02 07:36:44 +00:00
|
|
|
++NumMemSet;
|
implement enough of the memset inference algorithm to recognize and insert
memsets. This is still missing one important validity check, but this is enough
to compile stuff like this:
void test0(std::vector<char> &X) {
for (std::vector<char>::iterator I = X.begin(), E = X.end(); I != E; ++I)
*I = 0;
}
void test1(std::vector<int> &X) {
for (long i = 0, e = X.size(); i != e; ++i)
X[i] = 0x01010101;
}
With:
$ clang t.cpp -S -o - -O2 -emit-llvm | opt -loop-idiom | opt -O3 | llc
to:
__Z5test0RSt6vectorIcSaIcEE: ## @_Z5test0RSt6vectorIcSaIcEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rsi
cmpq %rsi, %rax
je LBB0_2
## BB#1: ## %bb.nph
subq %rax, %rsi
movq %rax, %rdi
callq ___bzero
LBB0_2: ## %for.end
addq $8, %rsp
ret
...
__Z5test1RSt6vectorIiSaIiEE: ## @_Z5test1RSt6vectorIiSaIiEE
## BB#0: ## %entry
subq $8, %rsp
movq (%rdi), %rax
movq 8(%rdi), %rdx
subq %rax, %rdx
cmpq $4, %rdx
jb LBB1_2
## BB#1: ## %for.body.preheader
andq $-4, %rdx
movl $1, %esi
movq %rax, %rdi
callq _memset
LBB1_2: ## %for.end
addq $8, %rsp
ret
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122573 91177308-0d34-0410-b5e6-96231b3b80d8
2010-12-26 23:42:51 +00:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2011-01-02 03:37:56 +00:00
|
|
|
/// processLoopStoreOfLoopLoad - We see a strided store whose value is a
|
|
|
|
/// same-strided load.
|
|
|
|
bool LoopIdiomRecognize::
|
|
|
|
processLoopStoreOfLoopLoad(StoreInst *SI, unsigned StoreSize,
|
|
|
|
const SCEVAddRecExpr *StoreEv,
|
|
|
|
const SCEVAddRecExpr *LoadEv,
|
|
|
|
const SCEV *BECount) {
|
2011-02-18 22:22:15 +00:00
|
|
|
// If we're not allowed to form memcpy, we fail.
|
2012-11-02 08:33:25 +00:00
|
|
|
if (!TLI->has(LibFunc::memcpy))
|
2011-02-18 22:22:15 +00:00
|
|
|
return false;
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-02 03:37:56 +00:00
|
|
|
LoadInst *LI = cast<LoadInst>(SI->getValueOperand());
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-05-22 17:39:56 +00:00
|
|
|
// The trip count of the loop and the base pointer of the addrec SCEV is
|
|
|
|
// guaranteed to be loop invariant, which means that it should dominate the
|
|
|
|
// header. This allows us to insert code for it in the preheader.
|
|
|
|
BasicBlock *Preheader = CurLoop->getLoopPreheader();
|
|
|
|
IRBuilder<> Builder(Preheader->getTerminator());
|
2011-06-28 05:07:32 +00:00
|
|
|
SCEVExpander Expander(*SE, "loop-idiom");
|
2011-06-28 05:04:16 +00:00
|
|
|
|
2011-01-02 03:37:56 +00:00
|
|
|
// Okay, we have a strided store "p[i]" of a loaded value. We can turn
|
2012-11-02 08:33:25 +00:00
|
|
|
// this into a memcpy in the loop preheader now if we want. However, this
|
|
|
|
// would be unsafe to do if there is anything else in the loop that may read
|
|
|
|
// or write the memory region we're storing to. This includes the load that
|
|
|
|
// feeds the stores. Check for an alias by generating the base address and
|
|
|
|
// checking everything.
|
2011-05-22 17:39:56 +00:00
|
|
|
Value *StoreBasePtr =
|
|
|
|
Expander.expandCodeFor(StoreEv->getStart(),
|
|
|
|
Builder.getInt8PtrTy(SI->getPointerAddressSpace()),
|
|
|
|
Preheader->getTerminator());
|
2012-11-02 08:33:25 +00:00
|
|
|
|
|
|
|
if (mayLoopAccessLocation(StoreBasePtr, AliasAnalysis::ModRef,
|
|
|
|
CurLoop, BECount, StoreSize,
|
|
|
|
getAnalysis<AliasAnalysis>(), SI)) {
|
|
|
|
Expander.clear();
|
|
|
|
// If we generated new code for the base pointer, clean up.
|
2015-02-07 21:37:08 +00:00
|
|
|
RecursivelyDeleteTriviallyDeadInstructions(StoreBasePtr, TLI);
|
2012-11-02 08:33:25 +00:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// For a memcpy, we have to make sure that the input array is not being
|
|
|
|
// mutated by the loop.
|
2011-03-14 16:48:10 +00:00
|
|
|
Value *LoadBasePtr =
|
2011-01-02 03:37:56 +00:00
|
|
|
Expander.expandCodeFor(LoadEv->getStart(),
|
|
|
|
Builder.getInt8PtrTy(LI->getPointerAddressSpace()),
|
|
|
|
Preheader->getTerminator());
|
2011-05-22 17:39:56 +00:00
|
|
|
|
2012-11-02 08:33:25 +00:00
|
|
|
if (mayLoopAccessLocation(LoadBasePtr, AliasAnalysis::Mod, CurLoop, BECount,
|
|
|
|
StoreSize, getAnalysis<AliasAnalysis>(), SI)) {
|
|
|
|
Expander.clear();
|
|
|
|
// If we generated new code for the base pointer, clean up.
|
2015-02-07 21:37:08 +00:00
|
|
|
RecursivelyDeleteTriviallyDeadInstructions(LoadBasePtr, TLI);
|
|
|
|
RecursivelyDeleteTriviallyDeadInstructions(StoreBasePtr, TLI);
|
2012-11-02 08:33:25 +00:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2011-05-22 17:39:56 +00:00
|
|
|
// Okay, everything is safe, we can transform this!
|
2011-06-28 05:04:16 +00:00
|
|
|
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-02 03:37:56 +00:00
|
|
|
// The # stored bytes is (BECount+1)*Size. Expand the trip count out to
|
|
|
|
// pointer size if it isn't already.
|
2014-02-21 00:06:31 +00:00
|
|
|
Type *IntPtrTy = Builder.getIntPtrTy(DL, SI->getPointerAddressSpace());
|
2013-09-11 05:09:42 +00:00
|
|
|
BECount = SE->getTruncateOrZeroExtend(BECount, IntPtrTy);
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2013-09-11 05:09:42 +00:00
|
|
|
const SCEV *NumBytesS = SE->getAddExpr(BECount, SE->getConstant(IntPtrTy, 1),
|
2011-03-14 16:50:06 +00:00
|
|
|
SCEV::FlagNUW);
|
2011-01-02 03:37:56 +00:00
|
|
|
if (StoreSize != 1)
|
2013-09-11 05:09:42 +00:00
|
|
|
NumBytesS = SE->getMulExpr(NumBytesS, SE->getConstant(IntPtrTy, StoreSize),
|
2011-03-14 16:50:06 +00:00
|
|
|
SCEV::FlagNUW);
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-02 03:37:56 +00:00
|
|
|
Value *NumBytes =
|
2013-09-11 05:09:42 +00:00
|
|
|
Expander.expandCodeFor(NumBytesS, IntPtrTy, Preheader->getTerminator());
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2012-11-02 08:33:25 +00:00
|
|
|
CallInst *NewCall =
|
|
|
|
Builder.CreateMemCpy(StoreBasePtr, LoadBasePtr, NumBytes,
|
|
|
|
std::min(SI->getAlignment(), LI->getAlignment()));
|
2011-05-04 21:37:05 +00:00
|
|
|
NewCall->setDebugLoc(SI->getDebugLoc());
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2012-11-02 08:33:25 +00:00
|
|
|
DEBUG(dbgs() << " Formed memcpy: " << *NewCall << "\n"
|
2011-01-02 03:37:56 +00:00
|
|
|
<< " from load ptr=" << *LoadEv << " at: " << *LI << "\n"
|
|
|
|
<< " from store ptr=" << *StoreEv << " at: " << *SI << "\n");
|
2011-06-28 05:04:16 +00:00
|
|
|
|
2011-03-14 16:48:10 +00:00
|
|
|
|
2011-01-02 03:37:56 +00:00
|
|
|
// Okay, the memset has been formed. Zap the original store and anything that
|
|
|
|
// feeds into it.
|
2015-02-07 21:37:08 +00:00
|
|
|
deleteDeadInstruction(SI, TLI);
|
2012-11-02 08:33:25 +00:00
|
|
|
++NumMemCpy;
|
2011-01-02 03:37:56 +00:00
|
|
|
return true;
|
|
|
|
}
|