llvm-6502/lib/CodeGen
Chris Lattner 7cb384dcca devirtualize AsmPrinter::printBasicBlockLabel since it is never overridden.
Move GetMBBSymbol up to AsmPrinter and make printBasicBlockLabel use it so that
we only have one place that decides what to name bb labels.  Hopefully various
clients of printBasicBlockLabel can start using GetMBBSymbol instead.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@81652 91177308-0d34-0410-b5e6-96231b3b80d8
2009-09-12 23:02:08 +00:00
..
AsmPrinter devirtualize AsmPrinter::printBasicBlockLabel since it is never overridden. 2009-09-12 23:02:08 +00:00
PBQP Mark more constants unsigned, as warned about by icc (#68). 2009-09-06 12:56:52 +00:00
SelectionDAG Make fast-isel try ISD::FNEG before resorting to bitcasts and xors. 2009-09-11 00:36:43 +00:00
BranchFolding.cpp Run branch folding if if-converter make some transformations. 2009-09-04 07:47:40 +00:00
BranchFolding.h Run branch folding if if-converter make some transformations. 2009-09-04 07:47:40 +00:00
CMakeLists.txt fix a gone file. 2009-08-23 01:11:21 +00:00
CodePlacementOpt.cpp
DeadMachineInstructionElim.cpp Convert DOUT to DEBUG(errs()...). 2009-08-22 20:04:03 +00:00
DwarfEHPrepare.cpp If there's a calling convention attach it to the rewind function call. 2009-09-04 01:14:14 +00:00
ELF.h
ELFCodeEmitter.cpp Rename TargetAsmInfo (and its subclasses) to MCAsmInfo. 2009-08-22 20:48:53 +00:00
ELFCodeEmitter.h
ELFWriter.cpp Fix ELF Writter related memory leaks 2009-09-01 19:25:52 +00:00
ELFWriter.h rename TAI -> MAI, being careful not to make MAILJMP instructions :) 2009-08-22 21:43:10 +00:00
ExactHazardRecognizer.cpp Use delete[] to match new[] (found by valgrind). 2009-09-04 11:59:43 +00:00
ExactHazardRecognizer.h
GCMetadata.cpp Change Pass::print to take a raw ostream instead of std::ostream, 2009-08-23 06:03:38 +00:00
GCMetadataPrinter.cpp rename TAI -> MAI, being careful not to make MAILJMP instructions :) 2009-08-22 21:43:10 +00:00
GCStrategy.cpp When emitting a label for a PostCall safe point, the machine 2009-09-08 07:39:27 +00:00
IfConversion.cpp Run branch folding if if-converter make some transformations. 2009-09-04 07:47:40 +00:00
IntrinsicLowering.cpp Change Pass::print to take a raw ostream instead of std::ostream, 2009-08-23 06:03:38 +00:00
LatencyPriorityQueue.cpp
LazyLiveness.cpp Add missing includes. 2009-08-19 22:05:21 +00:00
LiveInterval.cpp Moved some more index operations over to LiveIntervals. 2009-09-12 03:34:03 +00:00
LiveIntervalAnalysis.cpp Moved some more index operations over to LiveIntervals. 2009-09-12 03:34:03 +00:00
LiveStackAnalysis.cpp Change Pass::print to take a raw ostream instead of std::ostream, 2009-08-23 06:03:38 +00:00
LiveVariables.cpp remove the last uses of Config/alloca.h 2009-08-23 22:57:38 +00:00
LLVMTargetMachine.cpp -fast is now -O0. -fast-isel is no longer experimental. 2009-08-26 15:57:57 +00:00
LowerSubregs.cpp Convert DOUT to DEBUG(errs()...). 2009-08-22 20:23:49 +00:00
MachineBasicBlock.cpp remove std::ostream versions of printing stuff for MBB and MF, 2009-08-23 03:13:20 +00:00
MachineDominators.cpp Change Pass::print to take a raw ostream instead of std::ostream, 2009-08-23 06:03:38 +00:00
MachineFunction.cpp Reapply 79977. 2009-08-28 23:24:31 +00:00
MachineFunctionAnalysis.cpp
MachineFunctionPass.cpp
MachineInstr.cpp remove some uses of llvm/Support/Streams.h 2009-08-23 08:43:55 +00:00
MachineLICM.cpp Convert DOUT to DEBUG(errs()...). 2009-08-22 20:25:44 +00:00
MachineLoopInfo.cpp
MachineModuleInfo.cpp Rework getPersonalityIndex slightly - 0 is now a valid and not-NULL 2009-08-26 21:44:57 +00:00
MachinePassRegistry.cpp
MachineRegisterInfo.cpp
MachineSink.cpp remove std::ostream versions of printing stuff for MBB and MF, 2009-08-23 03:13:20 +00:00
MachineVerifier.cpp Adjust the MachineBasicBlock verifier rules to be more 2009-08-27 18:14:26 +00:00
MachO.h rename TAI -> MAI, being careful not to make MAILJMP instructions :) 2009-08-22 21:43:10 +00:00
MachOCodeEmitter.cpp rename TAI -> MAI, being careful not to make MAILJMP instructions :) 2009-08-22 21:43:10 +00:00
MachOCodeEmitter.h rename TAI -> MAI, being careful not to make MAILJMP instructions :) 2009-08-22 21:43:10 +00:00
MachOWriter.cpp eliminate the "Value" printing methods that print to a std::ostream. 2009-08-23 04:37:46 +00:00
MachOWriter.h rename TAI -> MAI, being careful not to make MAILJMP instructions :) 2009-08-22 21:43:10 +00:00
Makefile
ObjectCodeEmitter.cpp
OcamlGC.cpp
Passes.cpp
PHIElimination.cpp
PHIElimination.h Fix comment for consistency sake. 2009-09-04 07:46:30 +00:00
PostRASchedulerList.cpp It's a bool, so treat it like one. Fixes a MSVC warning. 2009-09-06 12:10:17 +00:00
PreAllocSplitting.cpp Removed static qualifier from a few index related methods. These methods may require a LiveIntervals instance in future. 2009-09-09 20:14:17 +00:00
PrologEpilogInserter.cpp Record variable debug info at ISel time directly. 2009-08-22 17:12:53 +00:00
PrologEpilogInserter.h
PseudoSourceValue.cpp
README.txt
RegAllocLinearScan.cpp Replaces uses of unsigned for indexes in LiveInterval and VNInfo with 2009-09-04 20:41:11 +00:00
RegAllocLocal.cpp Convert DOUT to DEBUG(errs()...). 2009-08-22 20:38:09 +00:00
RegAllocPBQP.cpp Remove some not-really-used variables, as warned 2009-09-06 12:41:19 +00:00
RegAllocSimple.cpp Convert DOUT to DEBUG(errs()...). 2009-08-22 20:40:21 +00:00
RegisterCoalescer.cpp
RegisterScavenging.cpp Simplify RegScavenger::FindUnusedReg. 2009-08-18 21:14:54 +00:00
ScheduleDAG.cpp Convert DOUT to DEBUG(errs()...). 2009-08-22 20:41:06 +00:00
ScheduleDAGEmit.cpp
ScheduleDAGInstrs.cpp Use the schedule itinerary operand use/def cycle information to adjust dependence edge latency for post-RA scheduling. 2009-08-19 16:08:58 +00:00
ScheduleDAGInstrs.h Use the schedule itinerary operand use/def cycle information to adjust dependence edge latency for post-RA scheduling. 2009-08-19 16:08:58 +00:00
ScheduleDAGPrinter.cpp Fix some refactos for iostream changes (in -Asserts mode). 2009-08-23 08:50:52 +00:00
ShadowStackGC.cpp
ShrinkWrapping.cpp Convert DOUT to DEBUG(errs()...). 2009-08-22 20:46:59 +00:00
SimpleHazardRecognizer.h
SimpleRegisterCoalescing.cpp Remove -new-coalescer-heuristic. It's not useful. 2009-09-12 02:14:41 +00:00
SimpleRegisterCoalescing.h Remove -new-coalescer-heuristic. It's not useful. 2009-09-12 02:14:41 +00:00
SjLjEHPrepare.cpp PR4747 2009-08-31 01:35:03 +00:00
Spiller.cpp Replaces uses of unsigned for indexes in LiveInterval and VNInfo with 2009-09-04 20:41:11 +00:00
Spiller.h
StackProtector.cpp
StackSlotColoring.cpp Remove some not-really-used variables, as warned 2009-09-06 12:41:19 +00:00
StrongPHIElimination.cpp Removed static qualifier from a few index related methods. These methods may require a LiveIntervals instance in future. 2009-09-09 20:14:17 +00:00
TargetInstrInfoImpl.cpp
TwoAddressInstructionPass.cpp Overhaul the TwoAddressInstructionPass to simplify the logic, especially 2009-09-03 20:58:42 +00:00
UnreachableBlockElim.cpp Preserve ProfileInfo. 2009-09-09 17:53:39 +00:00
VirtRegMap.cpp remove some uses of llvm/Support/Streams.h 2009-08-23 08:43:55 +00:00
VirtRegMap.h Replaces uses of unsigned for indexes in LiveInterval and VNInfo with 2009-09-04 20:41:11 +00:00
VirtRegRewriter.cpp Remove some unused variables and methods warned about by 2009-09-06 08:33:48 +00:00
VirtRegRewriter.h Kill off more cerr/cout uses and prune includes a bit. 2009-08-23 11:37:21 +00:00

//===---------------------------------------------------------------------===//

Common register allocation / spilling problem:

        mul lr, r4, lr
        str lr, [sp, #+52]
        ldr lr, [r1, #+32]
        sxth r3, r3
        ldr r4, [sp, #+52]
        mla r4, r3, lr, r4

can be:

        mul lr, r4, lr
        mov r4, lr
        str lr, [sp, #+52]
        ldr lr, [r1, #+32]
        sxth r3, r3
        mla r4, r3, lr, r4

and then "merge" mul and mov:

        mul r4, r4, lr
        str lr, [sp, #+52]
        ldr lr, [r1, #+32]
        sxth r3, r3
        mla r4, r3, lr, r4

It also increase the likelyhood the store may become dead.

//===---------------------------------------------------------------------===//

I think we should have a "hasSideEffects" flag (which is automatically set for
stuff that "isLoad" "isCall" etc), and the remat pass should eventually be able
to remat any instruction that has no side effects, if it can handle it and if
profitable.

For now, I'd suggest having the remat stuff work like this:

1. I need to spill/reload this thing.
2. Check to see if it has side effects.
3. Check to see if it is simple enough: e.g. it only has one register
destination and no register input.
4. If so, clone the instruction, do the xform, etc.

Advantages of this are:

1. the .td file describes the behavior of the instructions, not the way the
   algorithm should work.
2. as remat gets smarter in the future, we shouldn't have to be changing the .td
   files.
3. it is easier to explain what the flag means in the .td file, because you
   don't have to pull in the explanation of how the current remat algo works.

Some potential added complexities:

1. Some instructions have to be glued to it's predecessor or successor. All of
   the PC relative instructions and condition code setting instruction. We could
   mark them as hasSideEffects, but that's not quite right. PC relative loads
   from constantpools can be remat'ed, for example. But it requires more than
   just cloning the instruction. Some instructions can be remat'ed but it
   expands to more than one instruction. But allocator will have to make a
   decision.

4. As stated in 3, not as simple as cloning in some cases. The target will have
   to decide how to remat it. For example, an ARM 2-piece constant generation
   instruction is remat'ed as a load from constantpool.

//===---------------------------------------------------------------------===//

bb27 ...
        ...
        %reg1037 = ADDri %reg1039, 1
        %reg1038 = ADDrs %reg1032, %reg1039, %NOREG, 10
    Successors according to CFG: 0x8b03bf0 (#5)

bb76 (0x8b03bf0, LLVM BB @0x8b032d0, ID#5):
    Predecessors according to CFG: 0x8b0c5f0 (#3) 0x8b0a7c0 (#4)
        %reg1039 = PHI %reg1070, mbb<bb76.outer,0x8b0c5f0>, %reg1037, mbb<bb27,0x8b0a7c0>

Note ADDri is not a two-address instruction. However, its result %reg1037 is an
operand of the PHI node in bb76 and its operand %reg1039 is the result of the
PHI node. We should treat it as a two-address code and make sure the ADDri is
scheduled after any node that reads %reg1039.

//===---------------------------------------------------------------------===//

Use local info (i.e. register scavenger) to assign it a free register to allow
reuse:
        ldr r3, [sp, #+4]
        add r3, r3, #3
        ldr r2, [sp, #+8]
        add r2, r2, #2
        ldr r1, [sp, #+4]  <==
        add r1, r1, #1
        ldr r0, [sp, #+4]
        add r0, r0, #2

//===---------------------------------------------------------------------===//

LLVM aggressively lift CSE out of loop. Sometimes this can be negative side-
effects:

R1 = X + 4
R2 = X + 7
R3 = X + 15

loop:
load [i + R1]
...
load [i + R2]
...
load [i + R3]

Suppose there is high register pressure, R1, R2, R3, can be spilled. We need
to implement proper re-materialization to handle this:

R1 = X + 4
R2 = X + 7
R3 = X + 15

loop:
R1 = X + 4  @ re-materialized
load [i + R1]
...
R2 = X + 7 @ re-materialized
load [i + R2]
...
R3 = X + 15 @ re-materialized
load [i + R3]

Furthermore, with re-association, we can enable sharing:

R1 = X + 4
R2 = X + 7
R3 = X + 15

loop:
T = i + X
load [T + 4]
...
load [T + 7]
...
load [T + 15]
//===---------------------------------------------------------------------===//

It's not always a good idea to choose rematerialization over spilling. If all
the load / store instructions would be folded then spilling is cheaper because
it won't require new live intervals / registers. See 2003-05-31-LongShifts for
an example.

//===---------------------------------------------------------------------===//

With a copying garbage collector, derived pointers must not be retained across
collector safe points; the collector could move the objects and invalidate the
derived pointer. This is bad enough in the first place, but safe points can
crop up unpredictably. Consider:

        %array = load { i32, [0 x %obj] }** %array_addr
        %nth_el = getelementptr { i32, [0 x %obj] }* %array, i32 0, i32 %n
        %old = load %obj** %nth_el
        %z = div i64 %x, %y
        store %obj* %new, %obj** %nth_el

If the i64 division is lowered to a libcall, then a safe point will (must)
appear for the call site. If a collection occurs, %array and %nth_el no longer
point into the correct object.

The fix for this is to copy address calculations so that dependent pointers
are never live across safe point boundaries. But the loads cannot be copied
like this if there was an intervening store, so may be hard to get right.

Only a concurrent mutator can trigger a collection at the libcall safe point.
So single-threaded programs do not have this requirement, even with a copying
collector. Still, LLVM optimizations would probably undo a front-end's careful
work.

//===---------------------------------------------------------------------===//

The ocaml frametable structure supports liveness information. It would be good
to support it.

//===---------------------------------------------------------------------===//

The FIXME in ComputeCommonTailLength in BranchFolding.cpp needs to be
revisited. The check is there to work around a misuse of directives in inline
assembly.

//===---------------------------------------------------------------------===//

It would be good to detect collector/target compatibility instead of silently
doing the wrong thing.

//===---------------------------------------------------------------------===//

It would be really nice to be able to write patterns in .td files for copies,
which would eliminate a bunch of explicit predicates on them (e.g. no side 
effects).  Once this is in place, it would be even better to have tblgen 
synthesize the various copy insertion/inspection methods in TargetInstrInfo.

//===---------------------------------------------------------------------===//

Stack coloring improvments:

1. Do proper LiveStackAnalysis on all stack objects including those which are
   not spill slots.
2. Reorder objects to fill in gaps between objects.
   e.g. 4, 1, <gap>, 4, 1, 1, 1, <gap>, 4 => 4, 1, 1, 1, 1, 4, 4