Commit Graph

1127 Commits

Author SHA1 Message Date
Daniel Markstedt
8d26807573
Correct upload dir path validation logic (#1338)
* Correct upload and download  dir path validation logic

* Improve file download labels

* Clean up tmp file before attempting to upload again
2023-11-11 03:46:31 -08:00
Uwe Seimet
bd30073cb0
Fix daynaport statistics read count calculation (#1336) 2023-11-11 09:56:52 +01:00
Uwe Seimet
a164340179
Reduce logging in controller (#1332) 2023-11-10 15:47:43 +01:00
Kamel Makhloufi
9ce1bce592 Updated french translation 2023-11-10 23:40:22 +09:00
Uwe Seimet
979d25ae76
Add missing time unit (#1329) 2023-11-10 11:45:40 +01:00
Daniel Markstedt
2e2df10531 Install the dhcpcd package with the common bundle 2023-11-10 19:33:09 +09:00
Daniel Markstedt
bd33f66694
Freeze Python dependencies with pip freeze -l (#1322)
* Freeze Python dependencies with 'pip freeze -l'

* Freeze common dependencies; add section to README
2023-11-09 02:44:32 -08:00
Daniel Markstedt
1585a2fb70 Notify when network bridge is missing, but allow attaching DP 2023-11-09 08:41:32 +09:00
Uwe Seimet
f90f8eaf4e
Fix daynaport emulation regression (#1306) (#1318) 2023-11-09 00:39:00 +01:00
Daniel Markstedt
76b0f43bc1
Web UI: Inject a Go Back link on all pages, except the index and upload page (#1302)
* Move the manual and go back elements into footer; log controls in log page

* Move inline css style to stylesheet

* Touch up page layout

* Use a Home icon for going to the index page

* Use one vertical table for device info
2023-11-08 14:52:49 -08:00
Uwe Seimet
5542fa9e7c
Re-add CONNECT_TYPE_CONNECT_TYPE_AIBOM and CONNECT_TYPE_GAMERNIUM (#1315) (#1317)
* Re-add CONNECT_TYPE_CONNECT_TYPE_AIBOM and CONNECT_TYPE_GAMERNIUM
2023-11-08 13:27:49 +01:00
Uwe Seimet
0ab2f20a00
Fix MESSAGE OUT handling for initiator mode (#1283) (#1284)
* Fix MESSAGE OUT handling

* Update logging

* Add assertion
2023-11-08 11:25:35 +01:00
Daniel Markstedt
a6136c7f4a Check for webmin module config before modifying 2023-11-08 18:17:14 +09:00
Uwe Seimet
616e11ebe2
Only build scsidump when building for the FULLSPEC board (#1285) (#1286)
* Only build scsidump when building for the FULLSPEC board

* Only install scsidump manpage when building for the FULLSPEC board

* Only install scsidump binary when building for the FULLSPEC board

* Revert debug optimization back to -O0, -Og omits some information
2023-11-08 00:26:07 +01:00
Uwe Seimet
5715ec1470
Add note on OS to ISSUE_TEMPLATE (#1310) 2023-11-07 14:54:31 +01:00
Benjamin Krein
bd5341d62d address review items 2023-11-05 20:10:01 +09:00
Benjamin Krein
51220d41ad remove redundant package install 2023-11-05 20:10:01 +09:00
Benjamin Krein
3c00716b06 add missing dependency 2023-11-05 20:10:01 +09:00
Benjamin Krein
cde190a2cb fix netatalk paths in webmin 2023-11-05 20:10:01 +09:00
Uwe Seimet
39dd1d38a2
Fix assertion when creating a removable media drive without filename (#1308) 2023-11-05 09:11:53 +01:00
Eric Helgeson
eb8afa8319 Remove myself from CODEOWNERS 2023-11-05 00:21:13 +09:00
Daniel Markstedt
07a4826167 The Webmin netatalk module depends on libcgi-session-perl 2023-11-04 22:13:39 +09:00
Daniel Markstedt
cad3df690e Deliberately remove a previous venv for the python clients 2023-11-04 21:21:52 +09:00
Daniel Markstedt
0589a0efad
Improve UX for file upload forms (#1299)
* Improve UX for file upload forms

* Fix styles for admin service list

* Turn tabs into spaces
2023-11-04 02:21:54 -07:00
Daniel Markstedt
7deb359886 Update tests 2023-11-04 11:59:54 +09:00
Daniel Markstedt
4eca0495a4 Refactor file upload code to make it safer 2023-11-04 11:59:54 +09:00
dependabot[bot]
a3e6ff6015
Bump pillow from 9.3.0 to 10.0.1 in /python/ctrlboard (#1297)
* Bump pillow from 9.3.0 to 10.0.1 in /python/ctrlboard

Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.3.0 to 10.0.1.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](https://github.com/python-pillow/Pillow/compare/9.3.0...10.0.1)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-11-03 17:13:28 -07:00
dependabot[bot]
c9476a94a3
Bump pillow from 9.3.0 to 10.0.1 in /python/oled (#1296)
* Bump pillow from 9.3.0 to 10.0.1 in /python/oled

Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.3.0 to 10.0.1.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](https://github.com/python-pillow/Pillow/compare/9.3.0...10.0.1)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-11-03 17:12:30 -07:00
Daniel Markstedt
0a138eb1be Add back branch rule that fell off 2023-11-03 21:40:48 +09:00
Daniel Markstedt
cf5421d1f5 Move branches rule from push trigger to PR trigger 2023-11-03 21:37:13 +09:00
Daniel Markstedt
cb6174fc1d
Web UI: Remove workaround for listing English locale (#1291)
* Remove workaround for listing English locale

* Use pathlib object to construct upload path
2023-11-03 05:22:01 -07:00
Daniel Markstedt
b69c039a0c
Restore workflow events for pushs to paths (#1289) 2023-11-03 04:28:53 -07:00
Tony Kuker
776d84104c
Translation updates for 23.10 release (October, 2023) (#1243)
* Computer translated messages using Microsoft AI

---------

Co-authored-by: Tony Kuker <akuker@gmail.com>
Co-authored-by: Daniel Markstedt <markstedt@gmail.com>
2023-11-03 04:22:32 -07:00
Daniel Markstedt
e4c9b33778 Web UI: Create a system settings page 2023-11-03 19:25:19 +09:00
Daniel Markstedt
d1a080b7d0 Remove workflow events that used the wrong syntax. Fall back to the default: opened, synchronize, and reopened 2023-11-03 16:54:39 +09:00
Daniel Markstedt
063e8ed32b
Static analysis fixes for Python codebase (#1277)
* Don't log names of internal symbols that can be used for attacks

* Add integrity check to dropzone.js library

* Better a11y of web form labels

* Safer handling of file download paths

* Don't invert boolean check

* Make backend auth check a flask abort

* Clean up indentation to remove unwanted tabs

* Run workflow either on PR events, or branch pushes, not both
2023-11-01 06:28:53 -07:00
Daniel Markstedt
37b9110c99 When Python code changes, build C++ and run static analysis 2023-11-01 21:55:51 +09:00
Uwe Seimet
8cb4105409
Fix SonarQube issues (#1276)
* Fix SonarQube issues

* Fix error handling when target ID for INQUIRY is missing
2023-11-01 12:53:05 +01:00
Daniel Markstedt
029cf06c72
Web UI: Upload to tmp file name then rename if successful (#1272)
* Upload to tmp file name then rename if successful

* Move the dropzone.js operations back into web.py

* Move list_images() from file commands into piscsi commands (it was the only class method in that package that calls the protobuf interface)

* Remove now-redundant helptext
2023-10-31 14:54:04 -07:00
Uwe Seimet
7bbcf59c76
scsictl shall accept generic key/value pairs for options that take parameters (#1240) (#1274)
* scsictl accepts generic key/value pairs for options that take parameters
2023-10-31 09:02:28 +01:00
Uwe Seimet
8bd06ea5cd
Improve how commands are internally executed (#1247)
* Improve how commands are internally executed
* Use const CommandContext for execution
* Update error handling
* Fix SonarQube issues
* Remove duplicate code
* Use mutex instead of atomic_bool
* Add hasher
* Add param_map
* Do not log unknown operations as an error for backward/foward compatibility
2023-10-30 13:57:46 +01:00
Uwe Seimet
b7cb23e391
Add statistics and make scsictl accept generic key/value parameters (#1237/#1238) (#1262)
* Add statistics and make scsictl accept generic key/value parameters
2023-10-30 13:32:45 +01:00
Uwe Seimet
8f45e4f491
Add options to only run INQUIRY and to scan the bus to scsidump (#1092) (#1261)
* Add options to only run INQUIRY and to scan the bus to scsidump
2023-10-30 11:34:07 +01:00
Uwe Seimet
c78ba80088
Move default device parameters from DeviceFactory to the respective devices #1257 (#1259)
* Move default parameter handling
2023-10-30 11:24:18 +01:00
Daniel Markstedt
2de0aa090a Stop supporting Python 3.7, start supporting 3.11 2023-10-30 08:46:06 +09:00
Daniel Markstedt
b5323d0cd3 Bump to Flask 3 / Werkzeug 3 2023-10-30 08:46:06 +09:00
Uwe Seimet
d6116bf5c2
Remove unused duplicate code dealing with MODE SELECT (#1268) (#1269)
* Remove unused code
2023-10-29 13:01:12 +01:00
Uwe Seimet
43088ab3bc
Remove non-working Banana Pi code (#1252)
* Remove non-working Banana Pi code

* Remove SonarQube suppressions which can be resolved by a code update

* Update device detection
2023-10-22 17:29:26 +02:00
Uwe Seimet
2acb742043
Fix output formatting (#1254) 2023-10-22 16:19:40 +02:00
Uwe Seimet
02d18b3359
Do not write data when executing VERIFY10/VERIFY16 (#1250) 2023-10-22 16:18:33 +02:00