2007-02-23 01:01:19 +00:00
|
|
|
//===-- RegisterScavenging.cpp - Machine register scavenging --------------===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
2007-12-29 20:36:04 +00:00
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
2007-02-23 01:01:19 +00:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This file implements the machine register scavenger. It can provide
|
2008-03-06 23:22:43 +00:00
|
|
|
// information, such as unused registers, at any point in a machine basic block.
|
|
|
|
// It also provides a mechanism to make registers available by evicting them to
|
|
|
|
// spill slots.
|
2007-02-23 01:01:19 +00:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "llvm/CodeGen/RegisterScavenging.h"
|
2012-12-03 16:50:05 +00:00
|
|
|
#include "llvm/CodeGen/MachineBasicBlock.h"
|
2009-08-06 16:32:47 +00:00
|
|
|
#include "llvm/CodeGen/MachineFrameInfo.h"
|
2007-02-23 01:01:19 +00:00
|
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
|
|
|
#include "llvm/CodeGen/MachineInstr.h"
|
2008-04-05 01:27:09 +00:00
|
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
2010-09-02 00:51:37 +00:00
|
|
|
#include "llvm/Support/Debug.h"
|
2009-07-11 13:10:19 +00:00
|
|
|
#include "llvm/Support/ErrorHandling.h"
|
2010-09-02 00:51:37 +00:00
|
|
|
#include "llvm/Support/raw_ostream.h"
|
2007-02-23 01:01:19 +00:00
|
|
|
#include "llvm/Target/TargetInstrInfo.h"
|
2012-12-03 16:50:05 +00:00
|
|
|
#include "llvm/Target/TargetRegisterInfo.h"
|
2014-08-04 21:25:23 +00:00
|
|
|
#include "llvm/Target/TargetSubtargetInfo.h"
|
2007-02-23 01:01:19 +00:00
|
|
|
using namespace llvm;
|
|
|
|
|
2014-04-22 02:02:50 +00:00
|
|
|
#define DEBUG_TYPE "reg-scavenging"
|
|
|
|
|
2014-08-04 23:07:49 +00:00
|
|
|
/// setUsed - Set the register units of this register as used.
|
|
|
|
void RegScavenger::setRegUsed(unsigned Reg) {
|
|
|
|
for (MCRegUnitIterator RUI(Reg, TRI); RUI.isValid(); ++RUI)
|
|
|
|
RegUnitsAvailable.reset(*RUI);
|
2009-08-11 06:25:12 +00:00
|
|
|
}
|
|
|
|
|
2009-08-06 16:32:47 +00:00
|
|
|
void RegScavenger::initRegState() {
|
2013-07-03 05:11:49 +00:00
|
|
|
for (SmallVectorImpl<ScavengedInfo>::iterator I = Scavenged.begin(),
|
|
|
|
IE = Scavenged.end(); I != IE; ++I) {
|
2013-03-22 23:32:27 +00:00
|
|
|
I->Reg = 0;
|
2014-04-14 00:51:57 +00:00
|
|
|
I->Restore = nullptr;
|
2013-03-22 23:32:27 +00:00
|
|
|
}
|
2009-08-06 16:32:47 +00:00
|
|
|
|
2014-08-04 23:07:49 +00:00
|
|
|
// All register units start out unused.
|
|
|
|
RegUnitsAvailable.set();
|
2009-08-06 16:32:47 +00:00
|
|
|
|
2009-08-13 16:20:04 +00:00
|
|
|
if (!MBB)
|
2009-08-07 22:39:43 +00:00
|
|
|
return;
|
2009-08-13 16:20:04 +00:00
|
|
|
|
|
|
|
// Live-in registers are in use.
|
2010-04-13 16:57:55 +00:00
|
|
|
for (MachineBasicBlock::livein_iterator I = MBB->livein_begin(),
|
2009-08-07 22:39:43 +00:00
|
|
|
E = MBB->livein_end(); I != E; ++I)
|
2014-08-04 23:07:49 +00:00
|
|
|
setRegUsed(*I);
|
2009-08-13 16:20:04 +00:00
|
|
|
|
|
|
|
// Pristine CSRs are also unavailable.
|
|
|
|
BitVector PR = MBB->getParent()->getFrameInfo()->getPristineRegs(MBB);
|
|
|
|
for (int I = PR.find_first(); I>0; I = PR.find_next(I))
|
2014-08-04 23:07:49 +00:00
|
|
|
setRegUsed(I);
|
2009-08-06 16:32:47 +00:00
|
|
|
}
|
|
|
|
|
2007-03-01 02:19:39 +00:00
|
|
|
void RegScavenger::enterBasicBlock(MachineBasicBlock *mbb) {
|
2008-07-07 20:06:06 +00:00
|
|
|
MachineFunction &MF = *mbb->getParent();
|
2014-10-14 07:22:00 +00:00
|
|
|
TII = MF.getSubtarget().getInstrInfo();
|
|
|
|
TRI = MF.getSubtarget().getRegisterInfo();
|
2008-04-05 01:27:09 +00:00
|
|
|
MRI = &MF.getRegInfo();
|
2007-02-23 01:01:19 +00:00
|
|
|
|
2014-08-04 23:07:49 +00:00
|
|
|
assert((NumRegUnits == 0 || NumRegUnits == TRI->getNumRegUnits()) &&
|
2007-02-27 22:58:43 +00:00
|
|
|
"Target changed?");
|
|
|
|
|
2012-03-27 15:13:58 +00:00
|
|
|
// It is not possible to use the register scavenger after late optimization
|
|
|
|
// passes that don't preserve accurate liveness information.
|
|
|
|
assert(MRI->tracksLiveness() &&
|
|
|
|
"Cannot use register scavenger with inaccurate liveness");
|
|
|
|
|
2009-08-06 16:32:47 +00:00
|
|
|
// Self-initialize.
|
2007-02-27 22:58:43 +00:00
|
|
|
if (!MBB) {
|
2014-08-04 23:07:49 +00:00
|
|
|
NumRegUnits = TRI->getNumRegUnits();
|
|
|
|
RegUnitsAvailable.resize(NumRegUnits);
|
|
|
|
KillRegUnits.resize(NumRegUnits);
|
|
|
|
DefRegUnits.resize(NumRegUnits);
|
|
|
|
TmpRegUnits.resize(NumRegUnits);
|
2007-02-27 22:58:43 +00:00
|
|
|
}
|
|
|
|
|
2009-11-12 07:49:10 +00:00
|
|
|
MBB = mbb;
|
|
|
|
initRegState();
|
2007-03-01 02:19:39 +00:00
|
|
|
|
|
|
|
Tracking = false;
|
2007-02-23 01:01:19 +00:00
|
|
|
}
|
|
|
|
|
2014-08-04 23:07:49 +00:00
|
|
|
void RegScavenger::addRegUnits(BitVector &BV, unsigned Reg) {
|
|
|
|
for (MCRegUnitIterator RUI(Reg, TRI); RUI.isValid(); ++RUI)
|
|
|
|
BV.set(*RUI);
|
2009-08-08 13:18:47 +00:00
|
|
|
}
|
|
|
|
|
Reapply r178845 with fix - Fix bug in PEI's virtual-register scavenging
This fixes PEI as previously described, but correctly handles the case where
the instruction defining the virtual register to be scavenged is the first in
the block. Arnold provided me with a bugpoint-reduced test case, but even that
seems too large to use as a regression test. If I'm successful in cleaning it
up then I'll commit that as well.
Original commit message:
This change fixes a bug that I introduced in r178058. After a register is
scavenged using one of the available spills slots the instruction defining the
virtual register needs to be moved to after the spill code. The scavenger has
already processed the defining instruction so that registers killed by that
instruction are available for definition in that same instruction. Unfortunately,
after this, the scavenger needs to iterate through the spill code and then
visit, again, the instruction that defines the now-scavenged register. In order
to avoid confusion, the register scavenger needs the ability to 'back up'
through the spill code so that it can again process the instructions in the
appropriate order. Prior to this fix, once the scavenger reached the
just-moved instruction, it would assert if it killed any registers because,
having already processed the instruction, it believed they were undefined.
Unfortunately, I don't yet have a small test case. Thanks to Pranav Bhandarkar
for diagnosing the problem and testing this fix.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@178919 91177308-0d34-0410-b5e6-96231b3b80d8
2013-04-05 22:31:56 +00:00
|
|
|
void RegScavenger::determineKillsAndDefs() {
|
|
|
|
assert(Tracking && "Must be tracking to determine kills and defs");
|
2007-02-27 01:58:48 +00:00
|
|
|
|
2007-02-23 01:01:19 +00:00
|
|
|
MachineInstr *MI = MBBI;
|
Reapply r178845 with fix - Fix bug in PEI's virtual-register scavenging
This fixes PEI as previously described, but correctly handles the case where
the instruction defining the virtual register to be scavenged is the first in
the block. Arnold provided me with a bugpoint-reduced test case, but even that
seems too large to use as a regression test. If I'm successful in cleaning it
up then I'll commit that as well.
Original commit message:
This change fixes a bug that I introduced in r178058. After a register is
scavenged using one of the available spills slots the instruction defining the
virtual register needs to be moved to after the spill code. The scavenger has
already processed the defining instruction so that registers killed by that
instruction are available for definition in that same instruction. Unfortunately,
after this, the scavenger needs to iterate through the spill code and then
visit, again, the instruction that defines the now-scavenged register. In order
to avoid confusion, the register scavenger needs the ability to 'back up'
through the spill code so that it can again process the instructions in the
appropriate order. Prior to this fix, once the scavenger reached the
just-moved instruction, it would assert if it killed any registers because,
having already processed the instruction, it believed they were undefined.
Unfortunately, I don't yet have a small test case. Thanks to Pranav Bhandarkar
for diagnosing the problem and testing this fix.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@178919 91177308-0d34-0410-b5e6-96231b3b80d8
2013-04-05 22:31:56 +00:00
|
|
|
assert(!MI->isDebugValue() && "Debug values have no kills or defs");
|
2010-04-15 20:28:39 +00:00
|
|
|
|
2009-08-08 13:18:47 +00:00
|
|
|
// Find out which registers are early clobbered, killed, defined, and marked
|
|
|
|
// def-dead in this instruction.
|
2010-06-16 07:35:02 +00:00
|
|
|
// FIXME: The scavenger is not predication aware. If the instruction is
|
|
|
|
// predicated, conservatively assume "kill" markers do not actually kill the
|
|
|
|
// register. Similarly ignores "dead" markers.
|
|
|
|
bool isPred = TII->isPredicated(MI);
|
2014-08-04 23:07:49 +00:00
|
|
|
KillRegUnits.reset();
|
|
|
|
DefRegUnits.reset();
|
2007-02-23 01:01:19 +00:00
|
|
|
for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) {
|
|
|
|
const MachineOperand &MO = MI->getOperand(i);
|
2014-08-04 23:07:49 +00:00
|
|
|
if (MO.isRegMask()) {
|
|
|
|
|
|
|
|
TmpRegUnits.clear();
|
|
|
|
for (unsigned RU = 0, RUEnd = TRI->getNumRegUnits(); RU != RUEnd; ++RU) {
|
|
|
|
for (MCRegUnitRootIterator RURI(RU, TRI); RURI.isValid(); ++RURI) {
|
|
|
|
if (MO.clobbersPhysReg(*RURI)) {
|
|
|
|
TmpRegUnits.set(RU);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Apply the mask.
|
|
|
|
(isPred ? DefRegUnits : KillRegUnits) |= TmpRegUnits;
|
|
|
|
}
|
2011-05-02 20:06:28 +00:00
|
|
|
if (!MO.isReg())
|
2007-02-23 01:01:19 +00:00
|
|
|
continue;
|
|
|
|
unsigned Reg = MO.getReg();
|
2013-03-26 18:56:54 +00:00
|
|
|
if (!Reg || TargetRegisterInfo::isVirtualRegister(Reg) || isReserved(Reg))
|
2009-08-08 13:18:47 +00:00
|
|
|
continue;
|
2008-03-03 22:12:25 +00:00
|
|
|
|
2009-08-08 13:18:47 +00:00
|
|
|
if (MO.isUse()) {
|
2011-05-02 20:06:28 +00:00
|
|
|
// Ignore undef uses.
|
|
|
|
if (MO.isUndef())
|
|
|
|
continue;
|
2012-01-29 01:29:28 +00:00
|
|
|
if (!isPred && MO.isKill())
|
2014-08-04 23:07:49 +00:00
|
|
|
addRegUnits(KillRegUnits, Reg);
|
2009-08-08 13:18:47 +00:00
|
|
|
} else {
|
|
|
|
assert(MO.isDef());
|
2010-06-16 07:35:02 +00:00
|
|
|
if (!isPred && MO.isDead())
|
2014-08-04 23:07:49 +00:00
|
|
|
addRegUnits(KillRegUnits, Reg);
|
2009-08-08 13:18:47 +00:00
|
|
|
else
|
2014-08-04 23:07:49 +00:00
|
|
|
addRegUnits(DefRegUnits, Reg);
|
2008-03-03 22:12:25 +00:00
|
|
|
}
|
2007-02-23 01:01:19 +00:00
|
|
|
}
|
Reapply r178845 with fix - Fix bug in PEI's virtual-register scavenging
This fixes PEI as previously described, but correctly handles the case where
the instruction defining the virtual register to be scavenged is the first in
the block. Arnold provided me with a bugpoint-reduced test case, but even that
seems too large to use as a regression test. If I'm successful in cleaning it
up then I'll commit that as well.
Original commit message:
This change fixes a bug that I introduced in r178058. After a register is
scavenged using one of the available spills slots the instruction defining the
virtual register needs to be moved to after the spill code. The scavenger has
already processed the defining instruction so that registers killed by that
instruction are available for definition in that same instruction. Unfortunately,
after this, the scavenger needs to iterate through the spill code and then
visit, again, the instruction that defines the now-scavenged register. In order
to avoid confusion, the register scavenger needs the ability to 'back up'
through the spill code so that it can again process the instructions in the
appropriate order. Prior to this fix, once the scavenger reached the
just-moved instruction, it would assert if it killed any registers because,
having already processed the instruction, it believed they were undefined.
Unfortunately, I don't yet have a small test case. Thanks to Pranav Bhandarkar
for diagnosing the problem and testing this fix.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@178919 91177308-0d34-0410-b5e6-96231b3b80d8
2013-04-05 22:31:56 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void RegScavenger::unprocess() {
|
|
|
|
assert(Tracking && "Cannot unprocess because we're not tracking");
|
|
|
|
|
|
|
|
MachineInstr *MI = MBBI;
|
|
|
|
if (!MI->isDebugValue()) {
|
|
|
|
determineKillsAndDefs();
|
|
|
|
|
|
|
|
// Commit the changes.
|
2014-08-04 23:07:49 +00:00
|
|
|
setUsed(KillRegUnits);
|
|
|
|
setUnused(DefRegUnits);
|
Reapply r178845 with fix - Fix bug in PEI's virtual-register scavenging
This fixes PEI as previously described, but correctly handles the case where
the instruction defining the virtual register to be scavenged is the first in
the block. Arnold provided me with a bugpoint-reduced test case, but even that
seems too large to use as a regression test. If I'm successful in cleaning it
up then I'll commit that as well.
Original commit message:
This change fixes a bug that I introduced in r178058. After a register is
scavenged using one of the available spills slots the instruction defining the
virtual register needs to be moved to after the spill code. The scavenger has
already processed the defining instruction so that registers killed by that
instruction are available for definition in that same instruction. Unfortunately,
after this, the scavenger needs to iterate through the spill code and then
visit, again, the instruction that defines the now-scavenged register. In order
to avoid confusion, the register scavenger needs the ability to 'back up'
through the spill code so that it can again process the instructions in the
appropriate order. Prior to this fix, once the scavenger reached the
just-moved instruction, it would assert if it killed any registers because,
having already processed the instruction, it believed they were undefined.
Unfortunately, I don't yet have a small test case. Thanks to Pranav Bhandarkar
for diagnosing the problem and testing this fix.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@178919 91177308-0d34-0410-b5e6-96231b3b80d8
2013-04-05 22:31:56 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (MBBI == MBB->begin()) {
|
2014-04-14 00:51:57 +00:00
|
|
|
MBBI = MachineBasicBlock::iterator(nullptr);
|
Reapply r178845 with fix - Fix bug in PEI's virtual-register scavenging
This fixes PEI as previously described, but correctly handles the case where
the instruction defining the virtual register to be scavenged is the first in
the block. Arnold provided me with a bugpoint-reduced test case, but even that
seems too large to use as a regression test. If I'm successful in cleaning it
up then I'll commit that as well.
Original commit message:
This change fixes a bug that I introduced in r178058. After a register is
scavenged using one of the available spills slots the instruction defining the
virtual register needs to be moved to after the spill code. The scavenger has
already processed the defining instruction so that registers killed by that
instruction are available for definition in that same instruction. Unfortunately,
after this, the scavenger needs to iterate through the spill code and then
visit, again, the instruction that defines the now-scavenged register. In order
to avoid confusion, the register scavenger needs the ability to 'back up'
through the spill code so that it can again process the instructions in the
appropriate order. Prior to this fix, once the scavenger reached the
just-moved instruction, it would assert if it killed any registers because,
having already processed the instruction, it believed they were undefined.
Unfortunately, I don't yet have a small test case. Thanks to Pranav Bhandarkar
for diagnosing the problem and testing this fix.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@178919 91177308-0d34-0410-b5e6-96231b3b80d8
2013-04-05 22:31:56 +00:00
|
|
|
Tracking = false;
|
|
|
|
} else
|
|
|
|
--MBBI;
|
|
|
|
}
|
|
|
|
|
|
|
|
void RegScavenger::forward() {
|
|
|
|
// Move ptr forward.
|
|
|
|
if (!Tracking) {
|
|
|
|
MBBI = MBB->begin();
|
|
|
|
Tracking = true;
|
|
|
|
} else {
|
|
|
|
assert(MBBI != MBB->end() && "Already past the end of the basic block!");
|
2014-03-02 12:27:27 +00:00
|
|
|
MBBI = std::next(MBBI);
|
Reapply r178845 with fix - Fix bug in PEI's virtual-register scavenging
This fixes PEI as previously described, but correctly handles the case where
the instruction defining the virtual register to be scavenged is the first in
the block. Arnold provided me with a bugpoint-reduced test case, but even that
seems too large to use as a regression test. If I'm successful in cleaning it
up then I'll commit that as well.
Original commit message:
This change fixes a bug that I introduced in r178058. After a register is
scavenged using one of the available spills slots the instruction defining the
virtual register needs to be moved to after the spill code. The scavenger has
already processed the defining instruction so that registers killed by that
instruction are available for definition in that same instruction. Unfortunately,
after this, the scavenger needs to iterate through the spill code and then
visit, again, the instruction that defines the now-scavenged register. In order
to avoid confusion, the register scavenger needs the ability to 'back up'
through the spill code so that it can again process the instructions in the
appropriate order. Prior to this fix, once the scavenger reached the
just-moved instruction, it would assert if it killed any registers because,
having already processed the instruction, it believed they were undefined.
Unfortunately, I don't yet have a small test case. Thanks to Pranav Bhandarkar
for diagnosing the problem and testing this fix.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@178919 91177308-0d34-0410-b5e6-96231b3b80d8
2013-04-05 22:31:56 +00:00
|
|
|
}
|
|
|
|
assert(MBBI != MBB->end() && "Already at the end of the basic block!");
|
|
|
|
|
|
|
|
MachineInstr *MI = MBBI;
|
|
|
|
|
2013-07-03 05:11:49 +00:00
|
|
|
for (SmallVectorImpl<ScavengedInfo>::iterator I = Scavenged.begin(),
|
|
|
|
IE = Scavenged.end(); I != IE; ++I) {
|
Reapply r178845 with fix - Fix bug in PEI's virtual-register scavenging
This fixes PEI as previously described, but correctly handles the case where
the instruction defining the virtual register to be scavenged is the first in
the block. Arnold provided me with a bugpoint-reduced test case, but even that
seems too large to use as a regression test. If I'm successful in cleaning it
up then I'll commit that as well.
Original commit message:
This change fixes a bug that I introduced in r178058. After a register is
scavenged using one of the available spills slots the instruction defining the
virtual register needs to be moved to after the spill code. The scavenger has
already processed the defining instruction so that registers killed by that
instruction are available for definition in that same instruction. Unfortunately,
after this, the scavenger needs to iterate through the spill code and then
visit, again, the instruction that defines the now-scavenged register. In order
to avoid confusion, the register scavenger needs the ability to 'back up'
through the spill code so that it can again process the instructions in the
appropriate order. Prior to this fix, once the scavenger reached the
just-moved instruction, it would assert if it killed any registers because,
having already processed the instruction, it believed they were undefined.
Unfortunately, I don't yet have a small test case. Thanks to Pranav Bhandarkar
for diagnosing the problem and testing this fix.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@178919 91177308-0d34-0410-b5e6-96231b3b80d8
2013-04-05 22:31:56 +00:00
|
|
|
if (I->Restore != MI)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
I->Reg = 0;
|
2014-04-14 00:51:57 +00:00
|
|
|
I->Restore = nullptr;
|
Reapply r178845 with fix - Fix bug in PEI's virtual-register scavenging
This fixes PEI as previously described, but correctly handles the case where
the instruction defining the virtual register to be scavenged is the first in
the block. Arnold provided me with a bugpoint-reduced test case, but even that
seems too large to use as a regression test. If I'm successful in cleaning it
up then I'll commit that as well.
Original commit message:
This change fixes a bug that I introduced in r178058. After a register is
scavenged using one of the available spills slots the instruction defining the
virtual register needs to be moved to after the spill code. The scavenger has
already processed the defining instruction so that registers killed by that
instruction are available for definition in that same instruction. Unfortunately,
after this, the scavenger needs to iterate through the spill code and then
visit, again, the instruction that defines the now-scavenged register. In order
to avoid confusion, the register scavenger needs the ability to 'back up'
through the spill code so that it can again process the instructions in the
appropriate order. Prior to this fix, once the scavenger reached the
just-moved instruction, it would assert if it killed any registers because,
having already processed the instruction, it believed they were undefined.
Unfortunately, I don't yet have a small test case. Thanks to Pranav Bhandarkar
for diagnosing the problem and testing this fix.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@178919 91177308-0d34-0410-b5e6-96231b3b80d8
2013-04-05 22:31:56 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (MI->isDebugValue())
|
|
|
|
return;
|
|
|
|
|
|
|
|
determineKillsAndDefs();
|
2008-03-03 22:12:25 +00:00
|
|
|
|
2009-08-08 13:18:47 +00:00
|
|
|
// Verify uses and defs.
|
2012-01-29 01:29:28 +00:00
|
|
|
#ifndef NDEBUG
|
2009-08-08 13:18:47 +00:00
|
|
|
for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) {
|
|
|
|
const MachineOperand &MO = MI->getOperand(i);
|
2011-05-02 20:36:53 +00:00
|
|
|
if (!MO.isReg())
|
2009-07-01 01:59:31 +00:00
|
|
|
continue;
|
2009-08-08 13:18:47 +00:00
|
|
|
unsigned Reg = MO.getReg();
|
2013-03-26 18:56:54 +00:00
|
|
|
if (!Reg || TargetRegisterInfo::isVirtualRegister(Reg) || isReserved(Reg))
|
2007-03-02 10:43:16 +00:00
|
|
|
continue;
|
2009-08-08 13:18:47 +00:00
|
|
|
if (MO.isUse()) {
|
2011-05-02 20:36:53 +00:00
|
|
|
if (MO.isUndef())
|
|
|
|
continue;
|
2014-08-04 23:07:49 +00:00
|
|
|
if (!isRegUsed(Reg)) {
|
2009-10-26 04:56:07 +00:00
|
|
|
// Check if it's partial live: e.g.
|
|
|
|
// D0 = insert_subreg D0<undef>, S0
|
|
|
|
// ... D0
|
|
|
|
// The problem is the insert_subreg could be eliminated. The use of
|
|
|
|
// D0 is using a partially undef value. This is not *incorrect* since
|
|
|
|
// S1 is can be freely clobbered.
|
|
|
|
// Ideally we would like a way to model this, but leaving the
|
|
|
|
// insert_subreg around causes both correctness and performance issues.
|
|
|
|
bool SubUsed = false;
|
2012-06-01 23:28:30 +00:00
|
|
|
for (MCSubRegIterator SubRegs(Reg, TRI); SubRegs.isValid(); ++SubRegs)
|
2014-08-04 23:07:49 +00:00
|
|
|
if (isRegUsed(*SubRegs)) {
|
2009-10-26 04:56:07 +00:00
|
|
|
SubUsed = true;
|
|
|
|
break;
|
|
|
|
}
|
2014-08-04 23:07:49 +00:00
|
|
|
bool SuperUsed = false;
|
|
|
|
for (MCSuperRegIterator SR(Reg, TRI); SR.isValid(); ++SR) {
|
|
|
|
if (isRegUsed(*SR)) {
|
|
|
|
SuperUsed = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!SubUsed && !SuperUsed) {
|
2014-04-14 00:51:57 +00:00
|
|
|
MBB->getParent()->verify(nullptr, "In Register Scavenger");
|
2012-01-16 20:38:31 +00:00
|
|
|
llvm_unreachable("Using an undefined register!");
|
|
|
|
}
|
2011-08-12 14:54:45 +00:00
|
|
|
(void)SubUsed;
|
2014-08-04 23:07:49 +00:00
|
|
|
(void)SuperUsed;
|
2009-10-26 04:56:07 +00:00
|
|
|
}
|
2009-08-08 13:18:47 +00:00
|
|
|
} else {
|
|
|
|
assert(MO.isDef());
|
Fix PR5024 with a big hammer: disable the double-def assertion in the scavenger.
LiveVariables add implicit kills to correctly track partial register kills. This works well enough and is fairly accurate. But coalescer can make it impossible to maintain these markers. e.g.
BL <ga:sss1>, %R0<kill,undef>, %S0<kill>, %R0<imp-def>, %R1<imp-def,dead>, %R2<imp-def,dead>, %R3<imp-def,dead>, %R12<imp-def,dead>, %LR<imp-def,dead>, %D0<imp-def>, ...
...
%reg1031<def> = FLDS <cp#1>, 0, 14, %reg0, Mem:LD4[ConstantPool]
...
%S0<def> = FCPYS %reg1031<kill>, 14, %reg0, %D0<imp-use,kill>
When reg1031 and S0 are coalesced, the copy (FCPYS) will be eliminated the the implicit-kill of D0 is lost. In this case it's possible to move the marker to the FLDS. But in many cases, this is not possible. Suppose
%reg1031<def> = FOO <cp#1>, %D0<imp-def>
...
%S0<def> = FCPYS %reg1031<kill>, 14, %reg0, %D0<imp-use,kill>
When FCPYS goes away, the definition of S0 is the "FOO" instruction. However, transferring the D0 implicit-kill to FOO doesn't work since it is the def of D0 itself. We need to fix this in another time by introducing a "kill" pseudo instruction to track liveness.
Disabling the assertion is not ideal, but machine verifier is doing that job now. It's important to know double-def is not a miscomputation since it means a register should be free but it's not tracked as free. It's a performance issue instead.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@82677 91177308-0d34-0410-b5e6-96231b3b80d8
2009-09-24 02:27:09 +00:00
|
|
|
#if 0
|
|
|
|
// FIXME: Enable this once we've figured out how to correctly transfer
|
|
|
|
// implicit kills during codegen passes like the coalescer.
|
Remove RegisterScavenger::isSuperRegUsed(). This completely reverses the mistaken commit r77904.
Now there is no special treatment of instructions that redefine part of a
super-register. Instead, the super-register is marked with <imp-use,kill> and
<imp-def>. For instance, from LowerSubregs on ARM:
subreg: CONVERTING: %Q1<def> = INSERT_SUBREG %Q1<undef>, %D1<kill>, 5
subreg: %D2<def> = FCPYD %D1<kill>, 14, %reg0, %Q1<imp-def>
subreg: CONVERTING: %Q1<def> = INSERT_SUBREG %Q1, %D0<kill>, 6
subreg: %D3<def> = FCPYD %D0<kill>, 14, %reg0, %Q1<imp-use,kill>, %Q1<imp-def>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@78466 91177308-0d34-0410-b5e6-96231b3b80d8
2009-08-08 13:19:10 +00:00
|
|
|
assert((KillRegs.test(Reg) || isUnused(Reg) ||
|
2009-08-08 13:18:47 +00:00
|
|
|
isLiveInButUnusedBefore(Reg, MI, MBB, TRI, MRI)) &&
|
|
|
|
"Re-defining a live register!");
|
Fix PR5024 with a big hammer: disable the double-def assertion in the scavenger.
LiveVariables add implicit kills to correctly track partial register kills. This works well enough and is fairly accurate. But coalescer can make it impossible to maintain these markers. e.g.
BL <ga:sss1>, %R0<kill,undef>, %S0<kill>, %R0<imp-def>, %R1<imp-def,dead>, %R2<imp-def,dead>, %R3<imp-def,dead>, %R12<imp-def,dead>, %LR<imp-def,dead>, %D0<imp-def>, ...
...
%reg1031<def> = FLDS <cp#1>, 0, 14, %reg0, Mem:LD4[ConstantPool]
...
%S0<def> = FCPYS %reg1031<kill>, 14, %reg0, %D0<imp-use,kill>
When reg1031 and S0 are coalesced, the copy (FCPYS) will be eliminated the the implicit-kill of D0 is lost. In this case it's possible to move the marker to the FLDS. But in many cases, this is not possible. Suppose
%reg1031<def> = FOO <cp#1>, %D0<imp-def>
...
%S0<def> = FCPYS %reg1031<kill>, 14, %reg0, %D0<imp-use,kill>
When FCPYS goes away, the definition of S0 is the "FOO" instruction. However, transferring the D0 implicit-kill to FOO doesn't work since it is the def of D0 itself. We need to fix this in another time by introducing a "kill" pseudo instruction to track liveness.
Disabling the assertion is not ideal, but machine verifier is doing that job now. It's important to know double-def is not a miscomputation since it means a register should be free but it's not tracked as free. It's a performance issue instead.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@82677 91177308-0d34-0410-b5e6-96231b3b80d8
2009-09-24 02:27:09 +00:00
|
|
|
#endif
|
2007-03-02 10:43:16 +00:00
|
|
|
}
|
2007-02-23 01:01:19 +00:00
|
|
|
}
|
2012-01-29 01:29:28 +00:00
|
|
|
#endif // NDEBUG
|
2009-08-08 13:18:47 +00:00
|
|
|
|
|
|
|
// Commit the changes.
|
2014-08-04 23:07:49 +00:00
|
|
|
setUnused(KillRegUnits);
|
|
|
|
setUsed(DefRegUnits);
|
2007-02-23 01:01:19 +00:00
|
|
|
}
|
|
|
|
|
2014-08-04 23:07:49 +00:00
|
|
|
bool RegScavenger::isRegUsed(unsigned Reg, bool includeReserved) const {
|
|
|
|
if (includeReserved && isReserved(Reg))
|
|
|
|
return true;
|
|
|
|
for (MCRegUnitIterator RUI(Reg, TRI); RUI.isValid(); ++RUI)
|
|
|
|
if (!RegUnitsAvailable.test(*RUI))
|
|
|
|
return true;
|
|
|
|
return false;
|
2007-03-20 21:35:06 +00:00
|
|
|
}
|
|
|
|
|
2009-08-18 21:14:54 +00:00
|
|
|
unsigned RegScavenger::FindUnusedReg(const TargetRegisterClass *RC) const {
|
|
|
|
for (TargetRegisterClass::iterator I = RC->begin(), E = RC->end();
|
|
|
|
I != E; ++I)
|
2014-08-04 23:07:49 +00:00
|
|
|
if (!isRegUsed(*I)) {
|
2010-09-02 00:51:37 +00:00
|
|
|
DEBUG(dbgs() << "Scavenger found unused reg: " << TRI->getName(*I) <<
|
|
|
|
"\n");
|
2009-08-18 21:14:54 +00:00
|
|
|
return *I;
|
2010-09-02 00:51:37 +00:00
|
|
|
}
|
2009-08-18 21:14:54 +00:00
|
|
|
return 0;
|
2007-02-23 01:01:19 +00:00
|
|
|
}
|
2007-03-06 10:01:25 +00:00
|
|
|
|
2010-07-08 00:38:54 +00:00
|
|
|
/// getRegsAvailable - Return all available registers in the register class
|
|
|
|
/// in Mask.
|
2011-03-05 00:20:19 +00:00
|
|
|
BitVector RegScavenger::getRegsAvailable(const TargetRegisterClass *RC) {
|
|
|
|
BitVector Mask(TRI->getNumRegs());
|
2010-07-08 00:38:54 +00:00
|
|
|
for (TargetRegisterClass::iterator I = RC->begin(), E = RC->end();
|
|
|
|
I != E; ++I)
|
2014-08-04 23:07:49 +00:00
|
|
|
if (!isRegUsed(*I))
|
2010-07-08 00:38:54 +00:00
|
|
|
Mask.set(*I);
|
2011-03-05 00:20:19 +00:00
|
|
|
return Mask;
|
2010-07-08 00:38:54 +00:00
|
|
|
}
|
|
|
|
|
2009-08-16 17:41:39 +00:00
|
|
|
/// findSurvivorReg - Return the candidate register that is unused for the
|
2014-08-04 23:07:49 +00:00
|
|
|
/// longest after StartMII. UseMI is set to the instruction where the search
|
2009-08-16 17:41:39 +00:00
|
|
|
/// stopped.
|
|
|
|
///
|
|
|
|
/// No more than InstrLimit instructions are inspected.
|
|
|
|
///
|
2009-10-25 00:45:07 +00:00
|
|
|
unsigned RegScavenger::findSurvivorReg(MachineBasicBlock::iterator StartMI,
|
2009-08-16 17:41:39 +00:00
|
|
|
BitVector &Candidates,
|
|
|
|
unsigned InstrLimit,
|
|
|
|
MachineBasicBlock::iterator &UseMI) {
|
|
|
|
int Survivor = Candidates.find_first();
|
|
|
|
assert(Survivor > 0 && "No candidates for scavenging");
|
|
|
|
|
|
|
|
MachineBasicBlock::iterator ME = MBB->getFirstTerminator();
|
2009-10-25 00:45:07 +00:00
|
|
|
assert(StartMI != ME && "MI already at terminator");
|
|
|
|
MachineBasicBlock::iterator RestorePointMI = StartMI;
|
|
|
|
MachineBasicBlock::iterator MI = StartMI;
|
2009-08-16 17:41:39 +00:00
|
|
|
|
2009-10-25 00:45:07 +00:00
|
|
|
bool inVirtLiveRange = false;
|
2009-08-16 17:41:39 +00:00
|
|
|
for (++MI; InstrLimit > 0 && MI != ME; ++MI, --InstrLimit) {
|
2010-06-04 20:18:30 +00:00
|
|
|
if (MI->isDebugValue()) {
|
|
|
|
++InstrLimit; // Don't count debug instructions
|
|
|
|
continue;
|
|
|
|
}
|
2009-10-25 00:45:07 +00:00
|
|
|
bool isVirtKillInsn = false;
|
|
|
|
bool isVirtDefInsn = false;
|
2009-08-16 17:41:39 +00:00
|
|
|
// Remove any candidates touched by instruction.
|
|
|
|
for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) {
|
|
|
|
const MachineOperand &MO = MI->getOperand(i);
|
2012-02-22 22:50:14 +00:00
|
|
|
if (MO.isRegMask())
|
|
|
|
Candidates.clearBitsNotInMask(MO.getRegMask());
|
2009-10-25 00:45:07 +00:00
|
|
|
if (!MO.isReg() || MO.isUndef() || !MO.getReg())
|
2009-08-16 17:41:39 +00:00
|
|
|
continue;
|
2009-10-25 00:45:07 +00:00
|
|
|
if (TargetRegisterInfo::isVirtualRegister(MO.getReg())) {
|
|
|
|
if (MO.isDef())
|
|
|
|
isVirtDefInsn = true;
|
|
|
|
else if (MO.isKill())
|
|
|
|
isVirtKillInsn = true;
|
|
|
|
continue;
|
|
|
|
}
|
2012-06-01 22:38:17 +00:00
|
|
|
for (MCRegAliasIterator AI(MO.getReg(), TRI, true); AI.isValid(); ++AI)
|
|
|
|
Candidates.reset(*AI);
|
2009-08-16 17:41:39 +00:00
|
|
|
}
|
2009-10-25 00:45:07 +00:00
|
|
|
// If we're not in a virtual reg's live range, this is a valid
|
|
|
|
// restore point.
|
|
|
|
if (!inVirtLiveRange) RestorePointMI = MI;
|
|
|
|
|
|
|
|
// Update whether we're in the live range of a virtual register
|
|
|
|
if (isVirtKillInsn) inVirtLiveRange = false;
|
|
|
|
if (isVirtDefInsn) inVirtLiveRange = true;
|
2009-08-11 06:25:12 +00:00
|
|
|
|
2009-08-16 17:41:39 +00:00
|
|
|
// Was our survivor untouched by this instruction?
|
|
|
|
if (Candidates.test(Survivor))
|
2009-08-11 06:25:12 +00:00
|
|
|
continue;
|
2009-08-16 17:41:39 +00:00
|
|
|
|
|
|
|
// All candidates gone?
|
|
|
|
if (Candidates.none())
|
|
|
|
break;
|
|
|
|
|
|
|
|
Survivor = Candidates.find_first();
|
2007-03-06 10:01:25 +00:00
|
|
|
}
|
2009-10-25 00:45:07 +00:00
|
|
|
// If we ran off the end, that's where we want to restore.
|
|
|
|
if (MI == ME) RestorePointMI = ME;
|
|
|
|
assert (RestorePointMI != StartMI &&
|
|
|
|
"No available scavenger restore location!");
|
2009-08-16 17:41:39 +00:00
|
|
|
|
|
|
|
// We ran out of candidates, so stop the search.
|
2009-10-25 00:45:07 +00:00
|
|
|
UseMI = RestorePointMI;
|
2009-08-16 17:41:39 +00:00
|
|
|
return Survivor;
|
2007-03-06 10:01:25 +00:00
|
|
|
}
|
|
|
|
|
2013-01-31 20:02:54 +00:00
|
|
|
static unsigned getFrameIndexOperandNum(MachineInstr *MI) {
|
|
|
|
unsigned i = 0;
|
|
|
|
while (!MI->getOperand(i).isFI()) {
|
|
|
|
++i;
|
|
|
|
assert(i < MI->getNumOperands() &&
|
|
|
|
"Instr doesn't have FrameIndex operand!");
|
|
|
|
}
|
|
|
|
return i;
|
|
|
|
}
|
|
|
|
|
2007-03-06 10:01:25 +00:00
|
|
|
unsigned RegScavenger::scavengeRegister(const TargetRegisterClass *RC,
|
2007-05-01 09:01:42 +00:00
|
|
|
MachineBasicBlock::iterator I,
|
|
|
|
int SPAdj) {
|
2010-09-02 18:29:04 +00:00
|
|
|
// Consider all allocatable registers in the register class initially
|
|
|
|
BitVector Candidates =
|
|
|
|
TRI->getAllocatableSet(*I->getParent()->getParent(), RC);
|
2007-03-06 10:01:25 +00:00
|
|
|
|
|
|
|
// Exclude all the registers being used by the instruction.
|
|
|
|
for (unsigned i = 0, e = I->getNumOperands(); i != e; ++i) {
|
|
|
|
MachineOperand &MO = I->getOperand(i);
|
2013-07-11 05:55:57 +00:00
|
|
|
if (MO.isReg() && MO.getReg() != 0 && !(MO.isUse() && MO.isUndef()) &&
|
2009-09-30 01:47:59 +00:00
|
|
|
!TargetRegisterInfo::isVirtualRegister(MO.getReg()))
|
2007-03-06 10:01:25 +00:00
|
|
|
Candidates.reset(MO.getReg());
|
|
|
|
}
|
|
|
|
|
2010-07-08 16:49:26 +00:00
|
|
|
// Try to find a register that's unused if there is one, as then we won't
|
2014-08-04 23:07:49 +00:00
|
|
|
// have to spill.
|
2011-03-05 00:20:19 +00:00
|
|
|
BitVector Available = getRegsAvailable(RC);
|
2012-01-29 01:29:25 +00:00
|
|
|
Available &= Candidates;
|
|
|
|
if (Available.any())
|
|
|
|
Candidates = Available;
|
2010-07-08 16:49:26 +00:00
|
|
|
|
2008-02-16 01:09:25 +00:00
|
|
|
// Find the register whose use is furthest away.
|
2009-08-16 17:41:39 +00:00
|
|
|
MachineBasicBlock::iterator UseMI;
|
|
|
|
unsigned SReg = findSurvivorReg(I, Candidates, 25, UseMI);
|
2009-08-11 06:25:12 +00:00
|
|
|
|
2010-07-08 16:49:26 +00:00
|
|
|
// If we found an unused register there is no reason to spill it.
|
2014-08-04 23:07:49 +00:00
|
|
|
if (!isRegUsed(SReg)) {
|
2010-09-02 00:51:37 +00:00
|
|
|
DEBUG(dbgs() << "Scavenged register: " << TRI->getName(SReg) << "\n");
|
2009-08-16 17:41:39 +00:00
|
|
|
return SReg;
|
2010-09-02 00:51:37 +00:00
|
|
|
}
|
2007-03-06 10:01:25 +00:00
|
|
|
|
2013-03-22 23:32:27 +00:00
|
|
|
// Find an available scavenging slot.
|
2013-03-23 00:07:29 +00:00
|
|
|
unsigned SI;
|
2013-03-22 23:32:27 +00:00
|
|
|
for (SI = 0; SI < Scavenged.size(); ++SI)
|
|
|
|
if (Scavenged[SI].Reg == 0)
|
|
|
|
break;
|
|
|
|
|
2013-03-27 13:00:56 +00:00
|
|
|
if (SI == Scavenged.size()) {
|
2013-03-26 21:20:15 +00:00
|
|
|
// We need to scavenge a register but have no spill slot, the target
|
|
|
|
// must know how to do it (if not, we'll assert below).
|
|
|
|
Scavenged.push_back(ScavengedInfo());
|
|
|
|
}
|
2007-03-06 10:01:25 +00:00
|
|
|
|
2009-08-06 16:32:47 +00:00
|
|
|
// Avoid infinite regress
|
2013-03-22 23:32:27 +00:00
|
|
|
Scavenged[SI].Reg = SReg;
|
2009-08-06 16:32:47 +00:00
|
|
|
|
2009-10-05 22:30:23 +00:00
|
|
|
// If the target knows how to save/restore the register, let it do so;
|
|
|
|
// otherwise, use the emergency stack spill slot.
|
2009-10-19 22:27:30 +00:00
|
|
|
if (!TRI->saveScavengerRegister(*MBB, I, UseMI, RC, SReg)) {
|
2009-10-05 22:30:23 +00:00
|
|
|
// Spill the scavenged register before I.
|
2013-03-22 23:32:27 +00:00
|
|
|
assert(Scavenged[SI].FrameIndex >= 0 &&
|
2009-10-06 15:03:44 +00:00
|
|
|
"Cannot scavenge register without an emergency spill slot!");
|
2013-03-22 23:32:27 +00:00
|
|
|
TII->storeRegToStackSlot(*MBB, I, SReg, true, Scavenged[SI].FrameIndex,
|
|
|
|
RC, TRI);
|
2014-03-02 12:27:27 +00:00
|
|
|
MachineBasicBlock::iterator II = std::prev(I);
|
2013-01-31 20:02:54 +00:00
|
|
|
|
|
|
|
unsigned FIOperandNum = getFrameIndexOperandNum(II);
|
|
|
|
TRI->eliminateFrameIndex(II, SPAdj, FIOperandNum, this);
|
2009-10-05 22:30:23 +00:00
|
|
|
|
|
|
|
// Restore the scavenged register before its use (or first terminator).
|
2013-03-22 23:32:27 +00:00
|
|
|
TII->loadRegFromStackSlot(*MBB, UseMI, SReg, Scavenged[SI].FrameIndex,
|
|
|
|
RC, TRI);
|
2014-03-02 12:27:27 +00:00
|
|
|
II = std::prev(UseMI);
|
2013-01-31 20:02:54 +00:00
|
|
|
|
|
|
|
FIOperandNum = getFrameIndexOperandNum(II);
|
|
|
|
TRI->eliminateFrameIndex(II, SPAdj, FIOperandNum, this);
|
2009-10-19 22:27:30 +00:00
|
|
|
}
|
2008-11-20 02:32:35 +00:00
|
|
|
|
2014-03-02 12:27:27 +00:00
|
|
|
Scavenged[SI].Restore = std::prev(UseMI);
|
2009-10-05 22:30:23 +00:00
|
|
|
|
2009-08-07 22:39:43 +00:00
|
|
|
// Doing this here leads to infinite regress.
|
2013-03-22 23:32:27 +00:00
|
|
|
// Scavenged[SI].Reg = SReg;
|
2007-03-06 10:01:25 +00:00
|
|
|
|
2010-09-02 00:51:37 +00:00
|
|
|
DEBUG(dbgs() << "Scavenged register (with spill): " << TRI->getName(SReg) <<
|
|
|
|
"\n");
|
|
|
|
|
2007-03-06 10:01:25 +00:00
|
|
|
return SReg;
|
|
|
|
}
|